Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Jason Wang
On Fri, Aug 11, 2023 at 5:48 PM Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2023 at 05:41:44PM +0800, Jason Wang wrote: > > On Fri, Aug 11, 2023 at 5:25 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > > > > We try to build affinity mask via

Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2023 at 05:41:44PM +0800, Jason Wang wrote: > On Fri, Aug 11, 2023 at 5:25 PM Michael S. Tsirkin wrote: > > > > On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > > > We try to build affinity mask via create_affinity_masks() > > > unconditionally which may lead several i

Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Jason Wang
On Fri, Aug 11, 2023 at 5:25 PM Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > > We try to build affinity mask via create_affinity_masks() > > unconditionally which may lead several issues: > > > > - the affinity mask is not used for parent without affi

Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > We try to build affinity mask via create_affinity_masks() > unconditionally which may lead several issues: > > - the affinity mask is not used for parent without affinity support > (only VDUSE support the affinity now) > - the logic o

[PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Jason Wang
We try to build affinity mask via create_affinity_masks() unconditionally which may lead several issues: - the affinity mask is not used for parent without affinity support (only VDUSE support the affinity now) - the logic of create_affinity_masks() might not work for devices other than block.