Re: [PATCH] virtio_mem: break device on remove

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 11:25:12AM +0100, David Hildenbrand wrote: > On 17.01.22 09:40, Michael S. Tsirkin wrote: > > On Mon, Jan 17, 2022 at 09:31:56AM +0100, David Hildenbrand wrote: > >> On 17.01.22 08:55, Michael S. Tsirkin wrote: > >>> On Mon, Jan 17, 2022 at 02:40:11PM +0800, Jason Wang wrote

Re: [PATCH] virtio_mem: break device on remove

2022-01-17 Thread David Hildenbrand
On 17.01.22 09:40, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 09:31:56AM +0100, David Hildenbrand wrote: >> On 17.01.22 08:55, Michael S. Tsirkin wrote: >>> On Mon, Jan 17, 2022 at 02:40:11PM +0800, Jason Wang wrote: 在 2022/1/15 上午5:43, Michael S. Tsirkin 写道: > A common patte

Re: [PATCH] virtio_mem: break device on remove

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 09:31:56AM +0100, David Hildenbrand wrote: > On 17.01.22 08:55, Michael S. Tsirkin wrote: > > On Mon, Jan 17, 2022 at 02:40:11PM +0800, Jason Wang wrote: > >> > >> 在 2022/1/15 上午5:43, Michael S. Tsirkin 写道: > >>> A common pattern for device reset is currently: > >>> vdev->co

Re: [PATCH] virtio_mem: break device on remove

2022-01-17 Thread David Hildenbrand
On 17.01.22 08:55, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 02:40:11PM +0800, Jason Wang wrote: >> >> 在 2022/1/15 上午5:43, Michael S. Tsirkin 写道: >>> A common pattern for device reset is currently: >>> vdev->config->reset(vdev); >>> .. cleanup .. >>> >>> reset prevents new interrupts from

Re: [PATCH] virtio_mem: break device on remove

2022-01-16 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 02:40:11PM +0800, Jason Wang wrote: > > 在 2022/1/15 上午5:43, Michael S. Tsirkin 写道: > > A common pattern for device reset is currently: > > vdev->config->reset(vdev); > > .. cleanup .. > > > > reset prevents new interrupts from arriving and waits for interrupt > > handlers

Re: [PATCH] virtio_mem: break device on remove

2022-01-16 Thread Jason Wang
在 2022/1/15 上午5:43, Michael S. Tsirkin 写道: A common pattern for device reset is currently: vdev->config->reset(vdev); .. cleanup .. reset prevents new interrupts from arriving and waits for interrupt handlers to finish. However if - as is common - the handler queues a work request which is flu

[PATCH] virtio_mem: break device on remove

2022-01-14 Thread Michael S. Tsirkin
A common pattern for device reset is currently: vdev->config->reset(vdev); .. cleanup .. reset prevents new interrupts from arriving and waits for interrupt handlers to finish. However if - as is common - the handler queues a work request which is flushed during the cleanup stage, we have code ad