On Thursday 17 July 2008 13:40:14 Hidetoshi Seto wrote:
> Jeremy Fitzhardinge wrote:
> > Hidetoshi Seto wrote:
> >> +#ifdef CONFIG_STOP_MACHINE
> >> +extern unsigned long stopmachine_timeout;
> >> +#endif
> >
> > No externs in C files. Put it in an appropriate header.
>
> sysctl.c already has many
Hidetoshi Seto wrote:
> sysctl.c already has many externs... but I can fix at least
> the above.
>
Yeah, but it's an ugly pattern we'd rather not encourage.
>> I'll do a proper review soon.
>>
>
> Is it better to postpone v4 until your comment comes?
>
No.
J
_
Jeremy Fitzhardinge wrote:
> Hidetoshi Seto wrote:
>> +#ifdef CONFIG_STOP_MACHINE
>> +extern unsigned long stopmachine_timeout;
>> +#endif
>
> No externs in C files. Put it in an appropriate header.
sysctl.c already has many externs... but I can fix at least
the above.
> I'll do a proper review
Hidetoshi Seto wrote:
> +#ifdef CONFIG_STOP_MACHINE
> +extern unsigned long stopmachine_timeout;
> +#endif
>
No externs in C files. Put it in an appropriate header.
I'll do a proper review soon.
J
___
Virtualization mailing list
Virtualization@lists
Max Krasnyansky wrote:
> I'd set the default to zero. I beleive that's what Heiko suggested too.
Oh, yes, you are right. I missed to catch the suggestion.
I'll post fixed version soon. Wait a minutes...
Thanks,
H.Seto
___
Virtualization mailing list
V
Hidetoshi Seto wrote:
> Thank you for useful feedbacks!
> Here is the updated version.
> Could you put this on top of your patches, Rusty?
>
> Thanks,
> H.Seto
>
>
> If stop_machine() invoked while one of onlined cpu is locked up
> by some reason, stop_machine cannot finish its work because th
Thank you for useful feedbacks!
Here is the updated version.
Could you put this on top of your patches, Rusty?
Thanks,
H.Seto
If stop_machine() invoked while one of onlined cpu is locked up
by some reason, stop_machine cannot finish its work because the
locked cpu cannot stop. This means all ot
