Re: [PATCH] Do not name control queue for virtio-net

2022-09-22 Thread Michael S. Tsirkin
On Thu, Sep 22, 2022 at 11:10:37AM +0200, Paolo Abeni wrote: > On Sun, 2022-09-18 at 08:17 -0400, Michael S. Tsirkin wrote: > > On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote: > > > hi Michael > > > > > > in virtio-net.c > > >     /* Parameters for control virtqueue, if any */ > > >     if

Re: [PATCH] Do not name control queue for virtio-net

2022-09-22 Thread Michael S. Tsirkin
On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote: > hi Michael > > in virtio-net.c >     /* Parameters for control virtqueue, if any */ >     if (vi->has_cvq) { >         callbacks[total_vqs - 1] = NULL; >         names[total_vqs - 1] = "control"; >     } > > I think the Author who write the

Re: [PATCH] Do not name control queue for virtio-net

2022-09-22 Thread Paolo Abeni
On Sun, 2022-09-18 at 08:17 -0400, Michael S. Tsirkin wrote: > On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote: > > hi Michael > > > > in virtio-net.c > >     /* Parameters for control virtqueue, if any */ > >     if (vi->has_cvq) { > >         callbacks[total_vqs - 1] = NULL; > >         na

Re: [PATCH] Do not name control queue for virtio-net

2022-09-18 Thread Michael S. Tsirkin
On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote: > hi Michael > > in virtio-net.c >     /* Parameters for control virtqueue, if any */ >     if (vi->has_cvq) { >         callbacks[total_vqs - 1] = NULL; >         names[total_vqs - 1] = "control"; >     } > > I think the Author who write the

Re: [PATCH] Do not name control queue for virtio-net

2022-09-17 Thread Michael S. Tsirkin
On Sat, Sep 17, 2022 at 09:28:57AM +, junbo4...@gmail.com wrote: > From: Junbo > > In virtio drivers, the control queue always named -config. > > Signed-off-by: Junbo I don't think that's right. config is the config interrupt. > --- > drivers/net/virtio_net.c | 3 ++- > 1 file changed,