Re: [PATCH RFC 01/17] iommu: Remove struct iommu_ops *iommu from arch_setup_dma_ops()

2023-11-08 Thread Rob Herring
| 4 ++-- > arch/mips/mm/dma-noncoherent.c | 2 +- > arch/riscv/mm/dma-noncoherent.c | 2 +- > drivers/acpi/scan.c | 3 +-- > drivers/hv/hv_common.c | 2 +- > drivers/of/device.c | 2 +- Acked-by: Rob Herring > include/linux/dma-map-ops.h

Re: [PATCH RFC 02/17] of: Do not return struct iommu_ops from of_iommu_configure()

2023-11-08 Thread Rob Herring
rivers/iommu/of_iommu.c | 29 ++--- > drivers/of/device.c | 22 +++++++++++--- Acked-by: Rob Herring > include/linux/of_iommu.h | 13 ++--- > 3 files changed, 39 insertions(+), 25 deletions(-)

Re: [PATCH RFC 03/17] of: Use -ENODEV consistently in of_iommu_configure()

2023-11-08 Thread Rob Herring
On Fri, Nov 03, 2023 at 01:44:48PM -0300, Jason Gunthorpe wrote: > Instead of returning 1 and trying to handle positive error codes just > stick to the convention of returning -ENODEV. Remove references to ops > from of_iommu_configure(), a NULL ops will already generate an error code. nit: "iommu

[PATCH] iommu: Explicitly include correct DT includes

2023-07-14 Thread Rob Herring
s a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- drivers/iommu/arm/ar

Re: [PATCH v4 4/6] dt-bindings: hypervisor: Rename virtio to hypervisor

2023-02-07 Thread Rob Herring
On Mon, Feb 06, 2023 at 11:49:57PM -0800, Saurabh Sengar wrote: > Rename virtio folder to more generic hypervisor, so that this can > accommodate more devices of similar type. > > Signed-off-by: Saurabh Sengar > --- > Documentation/devicetree/bindings/gpio/gpio-virtio.yaml | 4 > +

Re: [PATCH v4 5/6] dt-bindings: hypervisor: VMBus

2023-02-07 Thread Rob Herring
On Tue, Feb 07, 2023 at 07:00:23AM -0600, Rob Herring wrote: > > On Mon, 06 Feb 2023 23:49:58 -0800, Saurabh Sengar wrote: > > Add dt-bindings for Hyper-V VMBus. > > > > Signed-off-by: Saurabh Sengar > > --- > > .../bindings/hyperv

Re: [PATCH v2 0/6] Device tree support for Hyper-V VMBus driver

2023-02-07 Thread Rob Herring
On Wed, Feb 1, 2023 at 10:34 AM Saurabh Singh Sengar wrote: > > On Wed, Feb 01, 2023 at 08:51:46AM -0600, Rob Herring wrote: > > On Tue, Jan 31, 2023 at 06:04:49PM -0800, Saurabh Singh Sengar wrote: > > > On Tue, Jan 31, 2023 at 02:27:51PM -0600, Rob Herring wrote: > >

Re: [PATCH v2 6/6] Driver: VMBus: Add device tree support

2023-02-07 Thread Rob Herring
On Fri, Feb 3, 2023 at 11:36 AM Saurabh Singh Sengar wrote: > > On Wed, Feb 01, 2023 at 11:46:38AM -0600, Rob Herring wrote: > > On Wed, Feb 01, 2023 at 08:51:33AM -0800, Saurabh Singh Sengar wrote: > > > On Tue, Jan 31, 2023 at 02:12:53PM -0600, Rob Herring wrote: > >

Re: [PATCH v4 5/6] dt-bindings: hypervisor: VMBus

2023-02-07 Thread Rob Herring
On Mon, 06 Feb 2023 23:49:58 -0800, Saurabh Sengar wrote: > Add dt-bindings for Hyper-V VMBus. > > Signed-off-by: Saurabh Sengar > --- > .../bindings/hypervisor/microsoft,vmbus.yaml | 48 > ++ > MAINTAINERS| 1 + > 2 files cha

Re: [PATCH v2 6/6] Driver: VMBus: Add device tree support

2023-02-01 Thread Rob Herring
On Wed, Feb 01, 2023 at 08:51:33AM -0800, Saurabh Singh Sengar wrote: > On Tue, Jan 31, 2023 at 02:12:53PM -0600, Rob Herring wrote: > > On Tue, Jan 31, 2023 at 12:10 PM Saurabh Sengar > > wrote: > > > > > > Update the driver to support device tree boot as well

Re: [PATCH v2 0/6] Device tree support for Hyper-V VMBus driver

2023-02-01 Thread Rob Herring
On Tue, Jan 31, 2023 at 06:04:49PM -0800, Saurabh Singh Sengar wrote: > On Tue, Jan 31, 2023 at 02:27:51PM -0600, Rob Herring wrote: > > On Tue, Jan 31, 2023 at 12:10 PM Saurabh Sengar > > wrote: > > > > > > This set of patches expands the VMBus driver to

Re: [PATCH v2 4/6] dt-bindings: hypervisor: Rename virtio to hypervisor

2023-01-31 Thread Rob Herring
On Tue, 31 Jan 2023 10:10:07 -0800, Saurabh Sengar wrote: > Rename virtio folder to more generic hypervisor, so that this can > accommodate more devices of similar type. > > Signed-off-by: Saurabh Sengar > --- > .../devicetree/bindings/{virtio => hypervisor}/mmio.yaml| 2 +- > .../devi

Re: [RFC PATCH 1/9] dt-bindings: drop redundant part of title of shared bindings

2022-11-17 Thread Rob Herring
On Thu, Nov 17, 2022 at 01:38:42PM +0100, Krzysztof Kozlowski wrote: > The Devicetree bindings document does not have to say in the title that > it is a "binding", but instead just describe the hardware. For shared > (re-usable) schemas, name them all as "common properties". It's titles, so capit

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-24 Thread Rob Herring
+Saravana On Mon, May 23, 2022 at 06:58:13PM -0700, Stefano Stabellini wrote: > On Mon, 23 May 2022, Oleksandr wrote: > > > > On Thu, 19 May 2022, Oleksandr wrote: > > > > > > On Wed, May 18, 2022 at 5:06 PM Oleksandr > > > > > > wrote: > > > > > > > On 18.05.22 17:32, Arnd Bergmann wrote: > > >

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-18 Thread Rob Herring
On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko > wrote: > > > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml > > b/Documentation/devicetree/bindings/virtio/mmio.yaml > > index 10c22b5..29a0932 100644 > > ---

Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-16 Thread Rob Herring
On Sat, May 07, 2022 at 09:19:06PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings

Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-03 Thread Rob Herring
On Tue, May 03, 2022 at 08:09:32PM +0300, Oleksandr wrote: > > On 03.05.22 00:59, Rob Herring wrote: > > Hello Rob > > > > On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > >

Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops

2022-05-02 Thread Rob Herring
On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings

Re: [PATCH] dt-bindings: virtio,mmio: Allow setting devices 'dma-coherent'

2022-03-20 Thread Rob Herring
On Wed, 09 Mar 2022 19:35:27 -0600, Rob Herring wrote: > 'virtio,mmio' devices are always coherent within a guest. As Arm DTs > are default non-coherent, the 'dma-coherent' property needs to be set on > the virtio device to mark them as such. This aligns with

[PATCH] dt-bindings: virtio, mmio: Allow setting devices 'dma-coherent'

2022-03-09 Thread Rob Herring
'virtio,mmio' devices are always coherent within a guest. As Arm DTs are default non-coherent, the 'dma-coherent' property needs to be set on the virtio device to mark them as such. This aligns with the QEMU 'virt' machine DTB. Signed-off-by: Rob Herring --- Doc

Re: [PATCH v4 4/7] Make sure task_struct is available for raw_smp_processor_id

2021-09-10 Thread Rob Herring
On Wed, Sep 08, 2021 at 12:06:02PM -0700, Keith Packard wrote: > To allow architectures to use the 'cpu' field in task_struct for cpu > identification, the task_struct must be visible whereever the > raw_smp_processor_id macro is used. It would be simplest to include > linux/sched.h from the releva

Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio

2021-08-03 Thread Rob Herring
n Mon, Aug 2, 2021 at 10:30 PM Viresh Kumar wrote: > > On 02-08-21, 13:40, Rob Herring wrote: > > Humm, how does one implement interrupts without a parent interrupt? It > > uses the parent virtio,mmio interrupt? > > Kind of, yeah, but not necessarily. > > The interr

Re: [PATCH V4 2/5] dt-bindings: i2c: Add bindings for i2c-virtio

2021-08-02 Thread Rob Herring
c/i2c-virtio.yaml | 51 +++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-virtio.yaml > Reviewed-by: Rob Herring ___ Virtualization mailing list Virtualization

Re: [PATCH V4 1/5] dt-bindings: virtio: Add binding for virtio devices

2021-08-02 Thread Rob Herring
gt; Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/virtio/mmio.yaml | 3 +- > .../bindings/virtio/virtio-device.yaml| 41 +++ > 2 files changed, 43 insertions(+), 1 deletion(-) > create mode 100644 > Documentation/devicetree/bindings/vir

Re: [PATCH V4 3/5] dt-bindings: gpio: Add bindings for gpio-virtio

2021-08-02 Thread Rob Herring
On Tue, Jul 27, 2021 at 10:53:50AM +0530, Viresh Kumar wrote: > This patch adds binding for virtio GPIO controller, it is based on > virtio-device bindings. > > Reviewed-by: Arnd Bergmann > Signed-off-by: Viresh Kumar > --- > .../devicetree/bindings/gpio/gpio-virtio.yaml | 59 ++

Re: [PATCH 5/5] dt-bindings: gpio: Add bindings for gpio-virtio

2021-07-13 Thread Rob Herring
On Tue, 13 Jul 2021 16:20:34 +0530, Viresh Kumar wrote: > gpio-virtio represents a virtio GPIO controller and this patch adds > binding for the same. The gpio-virtio subnode can be part of a > virtio,mmio node and is based on its binding. > > Signed-off-by: Viresh Kumar > --- > Depends on: > > h

Re: [PATCH 3/5] dt-bindings: i2c: Add bindings for i2c-virtio

2021-07-13 Thread Rob Herring
On Tue, 13 Jul 2021 16:20:32 +0530, Viresh Kumar wrote: > i2c-virtio represents a virtio I2C device and this patch adds binding > for the same. The i2c-virtio subnode can be part of a virtio,mmio node > and is based on its binding. > > Cc: Wolfram Sang > Signed-off-by: Viresh Kumar > --- > .../

Re: [PATCH v4 13/16] dt-bindings: arm: Add virtio transport for SCMI

2021-06-24 Thread Rob Herring
ting > mailbox and smc transports, since virtio-scmi does not need it. > > [1] https://lists.oasis-open.org/archives/virtio-comment/202102/msg00018.html > > CC: Rob Herring > CC: devicet...@vger.kernel.org > Signed-off-by: Igor Skalkin > [ Peter: Adapted patch for submissi

Re: [PATCH] dt-bindings: virtio: Convert virtio-mmio to DT schema

2021-06-08 Thread Rob Herring
On Mon, Jun 7, 2021 at 2:39 PM Rob Herring wrote: > > Convert the virtio-mmio binding to DT schema format. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Jean-Philippe Brucker > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Rob Herring

[PATCH] dt-bindings: virtio: Convert virtio-mmio to DT schema

2021-06-07 Thread Rob Herring
Convert the virtio-mmio binding to DT schema format. Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Jean-Philippe Brucker Cc: virtualization@lists.linux-foundation.org Signed-off-by: Rob Herring --- Jean-Philippe, hopefully you are okay with being listed as the maintainer here. You&#

Re: [RFC PATCH v3 10/12] dt-bindings: arm: Add virtio transport for SCMI

2021-05-17 Thread Rob Herring
On Tue, May 11, 2021 at 02:20:38AM +0200, Peter Hilber wrote: > From: Igor Skalkin > > Document the properties for arm,scmi-virtio compatible nodes. The > backing virtio SCMI device is described in patch [1]. > > [1] https://lists.oasis-open.org/archives/virtio-comment/202005/msg00096.html > >

Re: [PATCH RFC v1 12/18] asm-generic/hyperv: update hv_interrupt_entry

2020-10-01 Thread Rob Herring
No functional change. > > Signed-off-by: Wei Liu > --- > drivers/pci/controller/pci-hyperv.c | 2 +- > include/asm-generic/hyperv-tlfs.h | 36 +++-- > 2 files changed, 35 insertions(+), 3 deletions(-) > Acked-by: Rob Herring

Re: [RFC PATCH 6/7] dt-bindings: arm: Add virtio transport for SCMI

2020-09-23 Thread Rob Herring
On Fri, Sep 18, 2020 at 06:55:58PM +0200, Peter Hilber wrote: > From: Igor Skalkin > > Document the properties for arm,scmi-virtio compatible nodes. The > backing virtio SCMI device is described in patch [1]. > > [1] https://lists.oasis-open.org/archives/virtio-comment/202005/msg00096.html > >

Re: [PATCH] VIRTIO CORE AND NET DRIVERS: Replace HTTP links with HTTPS ones

2020-07-20 Thread Rob Herring
On Thu, 09 Jul 2020 08:47:55 +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't con

Re: [PATCH 3/8] drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS

2019-09-16 Thread Rob Herring
changed, 5 insertions(+), 31 deletions(-) Acked-by: Rob Herring ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v4 07/17] drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS

2019-08-08 Thread Rob Herring
us/cirrus.c | 2 +- > drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- > drivers/gpu/drm/v3d/v3d_drv.c | 2 +- > 4 files changed, 3 insertions(+), 29 deletions(-) Acked-by: Rob Herring ___ Virtualization mailing list Virtuali

Re: [PATCH v4 3/7] of: Allow the iommu-map property to omit untranslated devices

2018-11-16 Thread Rob Herring
t; pci_msi_setup_msi_irqs() will return an error when attempting to find the > device's MSI domain. > > Signed-off-by: Jean-Philippe Brucker > --- > drivers/of/base.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH v3 2/7] dt-bindings: virtio: Add virtio-pci-iommu node

2018-10-17 Thread Rob Herring
t; create mode 100644 Documentation/devicetree/bindings/virtio/iommu.txt > Reviewed-by: Rob Herring ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3 1/7] dt-bindings: virtio-mmio: Add IOMMU description

2018-10-17 Thread Rob Herring
n. > > Signed-off-by: Jean-Philippe Brucker > --- > .../devicetree/bindings/virtio/mmio.txt | 30 +++ > 1 file changed, 30 insertions(+) One nit, otherwise, Reviewed-by: Rob Herring > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.txt > b/Do

Re: [PATCH v2 1/5] dt-bindings: virtio: Specify #iommu-cells value for a virtio-iommu

2018-06-27 Thread Rob Herring
On Tue, Jun 26, 2018 at 11:59 AM Jean-Philippe Brucker wrote: > > On 25/06/18 20:27, Rob Herring wrote: > > On Thu, Jun 21, 2018 at 08:06:51PM +0100, Jean-Philippe Brucker wrote: > >> A virtio-mmio node may represent a virtio-iommu device. This is discovered > >>

Re: [PATCH v2 1/5] dt-bindings: virtio: Specify #iommu-cells value for a virtio-iommu

2018-06-25 Thread Rob Herring
On Thu, Jun 21, 2018 at 08:06:51PM +0100, Jean-Philippe Brucker wrote: > A virtio-mmio node may represent a virtio-iommu device. This is discovered > by the virtio driver at probe time, but the DMA topology isn't > discoverable and must be described by firmware. For DT the standard IOMMU > descript

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Rob Herring
On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning

Re: [PATCH v2 2/2] virtio: Document DMA coherency

2017-02-07 Thread Rob Herring
s sailed for legacy virtio, but let's hope that we can head off any > future firmware mishaps. > > Signed-off-by: Robin Murphy > --- > Documentation/devicetree/bindings/virtio/mmio.txt | 11 +++ > 1 file changed, 11 i

Re: [PATCH] virtio: Try to untangle DMA coherency

2017-02-04 Thread Rob Herring
On Wed, Feb 01, 2017 at 02:57:11PM +, Will Deacon wrote: > On Wed, Feb 01, 2017 at 12:25:57PM +, Robin Murphy wrote: > > By forcing on DMA API usage for ARM systems, we have inadvertently > > kicked open a hornets' nest in terms of cache-coherency. Namely that > > unless the virtio device i