Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize

-threaded? -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 2/4] Rename the file hv_utils.c

eat_msg; > + > + buflen = PAGE_SIZE; > + buf = kmalloc(buflen, GFP_ATOMIC); > + > + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid); -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/3]: An implementation of HyperV KVP functionality

d subject lines. Thank you. -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH 2/3]: An implementation of HyperV KVP functionality

cvpacket(channel, buf, buflen, &recvlen, &requestid); This did not change since previous review and this is wrong. It is the right way to crash kernel. I did not read further since this is a show-stopper imo. -- Evgeniy Polyakov ___

Re: [PATCH 2/3]: An Implementation of HyperV KVP functionality

annel, buf, buflen, &recvlen, &requestid); Boom. I did not read further, since this function returns void and thus can not propagate error, which is likely not a good idea. -- Evgeniy Polyakov ___ Virtualization mailing list Vi

Re: [PATCH] AF_VMCHANNEL address family for guest<->host communication.

way > to dynamically allocate them. Looks very good. Especially liked how you used idx.val pairs to register multiple users. Please add some comment in connector header on how you use it and feel free to add my ack if needed. -- Evge

Re: [PATCH] AF_VMCHANNEL address family for guest<->host communication.

u can tune buffer size to match virtual queue size or vice versa. -- Evgeniy Polyakov ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization

Re: [PATCH] AF_VMCHANNEL address family for guest<->host communication.

tun/tap devices can be virtualizen with recent kernels, which also solves all problems of shared access. There are plenty of ways to implement this kind of functionality instead of developing some new protocol, which is effectively a duplication of what already exists in the ke

Re: [PATCH] AF_VMCHANNEL address family for guest<->host communication.

ernelspace communications. But IMO having special network device or running your protocol over existing virtio network device is a cleaner solution both from technical and convenience points of view. -- Evgeniy Polyakov ___ Virtualizati

Re: [PATCH] AF_VMCHANNEL address family for guest<->host communication.

callbacks do not use bh socket locking, and while it is not something bad, but rt folks want (dream) to replace it with process context, so this at least requires some note in comments. Except that about questions, this patch looks good. -- Evgeniy Polyakov ___

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

ld fail: this would avoid using the thread most of the time. Yep, I decided that too. But it limits its usage to tun only or any other system where only single thread picks up results, so no generic userspace ring buffers? -- Evgeniy Polyakov

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

struct vring_used_elem used; > + u16 used_idx; > + > + BUG_ON(id <= 0 || id > vr->ring.num); > + > + used.id = id - 1; > + used.len = len; > + if (get_user(used_idx, &vr->ring.used->idx) != 0) > + return; > + > + if (co