Re: [PATCH] virtio_net: Revert "virtio_net: set the default max ring size by find_vqs()"

Hi, On 2022-08-15 17:39:08 -0400, Michael S. Tsirkin wrote: > On Mon, Aug 15, 2022 at 02:28:39PM -0700, Andres Freund wrote: > > On 2022-08-15 17:04:10 -0400, Michael S. Tsirkin wrote: > > > So virtio has a queue_size register. When read, it will give you > > > origin

Re: [PATCH] virtio_net: Revert "virtio_net: set the default max ring size by find_vqs()"

t is never told about the changed size for legacy devices... Indeed, adding a vp_legacy_set_queue_size() & call to it to setup_vq(), makes 5.19 + restricting queue sizes to 1024 boot again. I'd bet that it also would fix 6.0rc1, but I'm running out o

Re: upstream kernel crashes

Hi, On 2022-08-15 14:04:37 -0700, Andres Freund wrote: > Booting with the equivalent change, atop 5.19, in the legacy setup_vq() > reliably causes boot to hang: I don't know much virtio, so take this with a rock of salt: Legacy setup_vq() doesn't tell the host about the queue

Re: upstream kernel crashes

On 2022-08-15 13:53:31 -0700, Andres Freund wrote: > The reason the debug patch didn't change anything, and that my debug printk > didn't show, is that gcp uses the legacy paths... > > If there were a bug in the legacy path, it'd explain why the problem only >

Re: upstream kernel crashes

Hi, On 2022-08-15 16:21:51 -0400, Michael S. Tsirkin wrote: > On Mon, Aug 15, 2022 at 10:46:17AM -0700, Andres Freund wrote: > > Hi, > > > > On 2022-08-15 12:50:52 -0400, Michael S. Tsirkin wrote: > > > On Mon, Aug 15, 2022 at 09:45:03AM -0700, Andres Freund wrote:

Re: upstream kernel crashes

Hi, On 2022-08-15 12:50:52 -0400, Michael S. Tsirkin wrote: > On Mon, Aug 15, 2022 at 09:45:03AM -0700, Andres Freund wrote: > > Hi, > > > > On 2022-08-15 11:40:59 -0400, Michael S. Tsirkin wrote: > > > OK so this gives us a quick revert as a solution for now. >

Re: upstream kernel crashes

93] R13: R14: R15: 5631606794b0 [ 1.226228] [1.226775] Modules linked in: [1.227414] ---[ end trace ]--- Greetings, Andres Freund ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [GIT PULL] virtio: fatures, fixes

Hi, On 2022-08-14 12:40:31 -0700, Andres Freund wrote: > On 2022-08-14 04:59:48 -0400, Michael S. Tsirkin wrote: > > On Sat, Aug 13, 2022 at 09:39:06PM -0700, Andres Freund wrote: > > > Hi, > > > > > > On 2022-08-13 20:52:39 -0700, Andres Freund wrote: > &g

Re: [GIT PULL] virtio: fatures, fixes

Hi, On 2022-08-14 04:59:48 -0400, Michael S. Tsirkin wrote: > On Sat, Aug 13, 2022 at 09:39:06PM -0700, Andres Freund wrote: > > Hi, > > > > On 2022-08-13 20:52:39 -0700, Andres Freund wrote: > > > Is there specific information you'd like from the VM? I just

Re: [GIT PULL] virtio: fatures, fixes

Hi, On 2022-08-13 20:52:39 -0700, Andres Freund wrote: > Is there specific information you'd like from the VM? I just recreated the > problem and can extract. Actually, after reproducing I seem to now hit a likely different issue. I guess I should have checked exactly the revis

Re: [GIT PULL] virtio: fatures, fixes

lding the kernel it's only accessible via serial console. I can probably also get you the image in some other form that you prefer, although I don't know if the problem will reproduce outside gcp. If helpful I could upload a "broken" gcp image that you could use to > > [1]

Re: [GIT PULL] virtio: fatures, fixes

nning for Raise network interfaces (6s / 5min) Aug 13 22:51:22 debian dhclient[349]: DHCPDISCOVER on enp0s4 to 255.255.255.255 port 67 interval 13 [*** ] A start job is running for Raise network interfaces (19s / 5min) Aug 13 22:51:35 debian dhclient[349]: DHCPDISCOVER on enp0s4 to 255.255.255.2