Re: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group

2024-05-10 Thread Jason Gunthorpe
On Fri, May 10, 2024 at 10:30:10PM +0800, Baolu Lu wrote: > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 35ae9a6f73d3..09b4e671dcee 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -173,6 +173,8 @@ struct iommu_domain_geometry { > > #define __IOMMU_DO

Re: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group

2024-05-10 Thread Baolu Lu
On 2024/5/10 21:38, Jason Gunthorpe wrote: On Fri, May 10, 2024 at 11:14:20AM +0800, Baolu Lu wrote: On 5/8/24 8:04 AM, Jason Gunthorpe wrote: On Tue, Apr 30, 2024 at 10:57:04PM +0800, Lu Baolu wrote: @@ -206,8 +197,11 @@ void iommu_report_device_fault(struct device *dev, struct iopf_fault *e

Re: [PATCH v5 6/9] iommufd: Fault-capable hwpt attach/detach/replace

2024-05-10 Thread Jason Gunthorpe
On Fri, May 10, 2024 at 11:20:01AM +0800, Baolu Lu wrote: > On 5/8/24 8:18 AM, Jason Gunthorpe wrote: > > On Tue, Apr 30, 2024 at 10:57:07PM +0800, Lu Baolu wrote: > > > diff --git a/drivers/iommu/iommufd/fault.c b/drivers/iommu/iommufd/fault.c > > > index 13125c0feecb..6357229bf3b4 100644 > > > --

Re: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group

2024-05-10 Thread Jason Gunthorpe
On Fri, May 10, 2024 at 11:14:20AM +0800, Baolu Lu wrote: > On 5/8/24 8:04 AM, Jason Gunthorpe wrote: > > On Tue, Apr 30, 2024 at 10:57:04PM +0800, Lu Baolu wrote: > > > @@ -206,8 +197,11 @@ void iommu_report_device_fault(struct device *dev, > > > struct iopf_fault *evt) > > > if (group

Re: [PATCH v5 5/9] iommufd: Add iommufd fault object

2024-05-10 Thread Baolu Lu
On 2024/5/8 8:22, Jason Gunthorpe wrote: On Tue, Apr 30, 2024 at 10:57:06PM +0800, Lu Baolu wrote: +static ssize_t iommufd_fault_fops_read(struct file *filep, char __user *buf, + size_t count, loff_t *ppos) +{ + size_t fault_size = sizeof(struct iommu_h