Re: [virtio-comment] Re: virtio-sound linux driver conformance to spec

2023-09-18 Thread Paolo Bonzini
On 9/19/23 02:35, Anton Yakovlev wrote: If the Linux virtio sound driver violates a specification, then there must be a conformance statement that the driver does not follow. As far as I know, there is no such thing at the moment. There is one in 2.7.13.3: "The device MAY access the descript

Re: virtio-sound linux driver conformance to spec

2023-09-18 Thread Anton Yakovlev via Virtualization
Hello Matias, On 14.09.2023 00:04, Matias Ezequiel Vara Larsen wrote: Hello, This email is to report a behavior of the Linux virtio-sound driver that looks like it is not conforming to the VirtIO specification. The kernel driver is moving buffers from the used ring to the available ring without

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Stefan Hajnoczi
On Mon, Sep 18, 2023 at 02:50:09PM +0200, Matias Ezequiel Vara Larsen wrote: > On Wed, Sep 13, 2023 at 06:58:30PM +0300, Manos Pitsidianakis wrote: > > Hello Matias, > > > > Please show and refer to code snippets from the kernel tree that you > > think are related to your question. It'd help us ma

Re: [PATCH net-next v9 0/4] vsock/virtio/vhost: MSG_ZEROCOPY preparations

2023-09-18 Thread Michael S. Tsirkin
On Sat, Sep 16, 2023 at 04:09:14PM +0300, Arseniy Krasnov wrote: > Hello, > > this patchset is first of three parts of another big patchset for > MSG_ZEROCOPY flag support: > https://lore.kernel.org/netdev/20230701063947.3422088-1-avkras...@sberdevices.ru/ > > During review of this series, Stefan

Re: [PATCH v2 1/2] iommu/virtio: Make use of ops->iotlb_sync_map

2023-09-18 Thread Robin Murphy
On 2023-09-18 12:51, Niklas Schnelle wrote: Pull out the sync operation from viommu_map_pages() by implementing ops->iotlb_sync_map. This allows the common IOMMU code to map multiple elements of an sg with a single sync (see iommu_map_sg()). Furthermore, it is also a requirement for IOMMU_CAP_DEF

Re: [PATCH v2 2/2] iommu/virtio: Add ops->flush_iotlb_all and enable deferred flush

2023-09-18 Thread Jean-Philippe Brucker
On Mon, Sep 18, 2023 at 01:51:44PM +0200, Niklas Schnelle wrote: > Add ops->flush_iotlb_all operation to enable virtio-iommu for the > dma-iommu deferred flush scheme. This results in a significant increase > in performance in exchange for a window in which devices can still > access previously IOM

Re: [PATCH v2 1/2] iommu/virtio: Make use of ops->iotlb_sync_map

2023-09-18 Thread Jean-Philippe Brucker
On Mon, Sep 18, 2023 at 01:51:43PM +0200, Niklas Schnelle wrote: > Pull out the sync operation from viommu_map_pages() by implementing > ops->iotlb_sync_map. This allows the common IOMMU code to map multiple > elements of an sg with a single sync (see iommu_map_sg()). Furthermore, > it is also a re

Re: [PATCH net-next v9 4/4] vsock/virtio: MSG_ZEROCOPY flag support

2023-09-18 Thread Stefano Garzarella
On Sat, Sep 16, 2023 at 04:09:18PM +0300, Arseniy Krasnov wrote: This adds handling of MSG_ZEROCOPY flag on transmission path: 1) If this flag is set and zerocopy transmission is possible (enabled in socket options and transport allows zerocopy), then non-linear skb will be created and fille

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Matias Ezequiel Vara Larsen
On Wed, Sep 13, 2023 at 06:58:30PM +0300, Manos Pitsidianakis wrote: > Hello Matias, > > Please show and refer to code snippets from the kernel tree that you > think are related to your question. It'd help us make sure we all talk > about the same thing. > In this discussion, I am referring to t

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Matias Ezequiel Vara Larsen
On Mon, Sep 18, 2023 at 1:13 PM Matias Ezequiel Vara Larsen wrote: > > On Wed, Sep 13, 2023 at 05:50:48PM +0200, Paolo Bonzini wrote: > > On Wed, Sep 13, 2023 at 5:05 PM Matias Ezequiel Vara Larsen > > wrote: > > > > > > Hello, > > > > > > This email is to report a behavior of the Linux virtio-so

Re: [virtio-comment] virtio-sound linux driver conformance to spec

2023-09-18 Thread Matias Ezequiel Vara Larsen
On Wed, Sep 13, 2023 at 05:50:48PM +0200, Paolo Bonzini wrote: > On Wed, Sep 13, 2023 at 5:05 PM Matias Ezequiel Vara Larsen > wrote: > > > > Hello, > > > > This email is to report a behavior of the Linux virtio-sound driver that > > looks like it is not conforming to the VirtIO specification. The

Re: [RFC v2 4/4] vduse: Add new ioctl VDUSE_GET_RECONNECT_INFO

2023-09-18 Thread Jason Wang
On Tue, Sep 12, 2023 at 11:01 AM Cindy Lu wrote: > > In VDUSE_GET_RECONNECT_INFO, the Userspace App can get the map size > and The number of mapping memory pages from the kernel. The userspace > App can use this information to map the pages. > > Signed-off-by: Cindy Lu > --- > drivers/vdpa/vdpa_

Re: [RFC v2 2/4] vduse: Add file operation for mmap

2023-09-18 Thread Jason Wang
On Tue, Sep 12, 2023 at 11:00 AM Cindy Lu wrote: > > Add the operation for mmap, The user space APP will > use this function to map the pages to userspace > > Signed-off-by: Cindy Lu > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 63 ++ > 1 file changed, 63 insertions(+

Re: [RFC v2 1/4] vduse: Add function to get/free the pages for reconnection

2023-09-18 Thread Jason Wang
On Tue, Sep 12, 2023 at 11:00 AM Cindy Lu wrote: > > Add the function vduse_alloc_reconnnect_info_mem > and vduse_alloc_reconnnect_info_mem > In this 2 function, vduse will get/free (vq_num + 1)*page > Page 0 will be used to save the reconnection information, The > Userspace App will maintain this