Re: [PATCH RFC v3 2/4] vdpa/mlx5: implement .reset_map driver op

2023-09-11 Thread Jason Wang
On Tue, Sep 12, 2023 at 8:02 AM Si-Wei Liu wrote: > > > > On 9/10/2023 8:48 PM, Jason Wang wrote: > > On Sat, Sep 9, 2023 at 9:46 PM Si-Wei Liu wrote: > >> Today, mlx5_vdpa gets started by preallocate 1:1 DMA mapping at > >> device creation time, while this 1:1 mapping will be implicitly > >> des

Re: [PATCH RFC v2 1/4] vdpa: introduce .reset_map operation callback

2023-09-11 Thread Jason Wang
On Tue, Sep 12, 2023 at 7:31 AM Si-Wei Liu wrote: > > Hi Jason, > > On 9/10/2023 8:42 PM, Jason Wang wrote: > > Hi Si-Wei: > > > > On Sat, Sep 9, 2023 at 9:34 PM Si-Wei Liu wrote: > >> On-chip IOMMU parent driver could use it to restore memory mapping > >> to the initial state. > > As discussed b

Re: [PATCH RFC v2 0/3] vdpa: dedicated descriptor table group

2023-09-11 Thread Jason Wang
On Mon, Sep 11, 2023 at 3:06 PM Dragos Tatulea wrote: > > Hi Jason, > > On Mon, 2023-09-11 at 14:43 +0800, Jason Wang wrote: > > On Sat, Sep 9, 2023 at 4:45 PM Si-Wei Liu wrote: > > > > > > Following patchset introduces dedicated group for descriptor table to > > > reduce live migration downtime

Re: [PATCH net-next] virtio: kdoc for struct virtio_pci_modern_device

2023-09-11 Thread Jason Wang
On Tue, Sep 12, 2023 at 5:31 AM Shannon Nelson wrote: > > Finally following up to Simon's suggestion for some kdoc attention > on struct virtio_pci_modern_device. > > Link: https://lore.kernel.org/netdev/ze%2fqs0lnuvxfa...@corigine.com/ > Cc: Simon Horman > Signed-off-by: Shannon Nelson > Acked-

Re: [PATCH iproute2] vdpa: consume device_features parameter

2023-09-11 Thread Jason Wang
On Tue, Sep 12, 2023 at 2:08 AM Shannon Nelson wrote: > > From: Allen Hubbe > > Consume the parameter to device_features when parsing command line > options. Otherwise the parameter may be used again as an option name. > > # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55 > U

Re: [PATCH] vdpa: consume device_features parameter

2023-09-11 Thread Si-Wei Liu
Thanks David, for clarifications. Now I see the patch just got posted by Shannon (thanks!) with the correct iproute2 label in the subject line. We may expect to see this land on iproute2 repo soon? Thanks! -Siwei On 9/9/2023 1:36 PM, David Ahern wrote: On 9/8/23 12:37 PM, Si-Wei Liu wrote: J

Re: [PATCH RFC v3 4/4] vhost-vdpa: introduce IOTLB_PERSIST backend feature bit

2023-09-11 Thread Si-Wei Liu
On 9/10/2023 8:52 PM, Jason Wang wrote: On Sat, Sep 9, 2023 at 9:46 PM Si-Wei Liu wrote: Userspace needs this feature flag to distinguish if vhost-vdpa iotlb in the kernel supports persistent IOTLB mapping across device reset. As discussed, the IOTLB persists for devices with platform IOMMU

Re: [PATCH RFC v3 2/4] vdpa/mlx5: implement .reset_map driver op

2023-09-11 Thread Si-Wei Liu
On 9/10/2023 8:48 PM, Jason Wang wrote: On Sat, Sep 9, 2023 at 9:46 PM Si-Wei Liu wrote: Today, mlx5_vdpa gets started by preallocate 1:1 DMA mapping at device creation time, while this 1:1 mapping will be implicitly destroyed when the first .set_map call is invoked. Everytime when the .reset

Re: [PATCH RFC v2 1/4] vdpa: introduce .reset_map operation callback

2023-09-11 Thread Si-Wei Liu
Hi Jason, On 9/10/2023 8:42 PM, Jason Wang wrote: Hi Si-Wei: On Sat, Sep 9, 2023 at 9:34 PM Si-Wei Liu wrote: On-chip IOMMU parent driver could use it to restore memory mapping to the initial state. As discussed before. On-chip IOMMU is the hardware details that need to be hidden by the vDPA

[PATCH net-next] virtio: kdoc for struct virtio_pci_modern_device

2023-09-11 Thread Shannon Nelson via Virtualization
Finally following up to Simon's suggestion for some kdoc attention on struct virtio_pci_modern_device. Link: https://lore.kernel.org/netdev/ze%2fqs0lnuvxfa...@corigine.com/ Cc: Simon Horman Signed-off-by: Shannon Nelson Acked-by: Eugenio Pérez --- include/linux/virtio_pci_modern.h | 34 +++

[PATCH iproute2] vdpa: consume device_features parameter

2023-09-11 Thread Shannon Nelson via Virtualization
From: Allen Hubbe Consume the parameter to device_features when parsing command line options. Otherwise the parameter may be used again as an option name. # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55 Unknown option "0xdeadbeef" Fixes: a4442ce58ebb ("vdpa: allow provisi

Re: [PATCH V11 07/17] riscv: qspinlock: Introduce qspinlock param for command line

2023-09-11 Thread Waiman Long
On 9/10/23 04:29, guo...@kernel.org wrote: From: Guo Ren Allow cmdline to force the kernel to use queued_spinlock when CONFIG_RISCV_COMBO_SPINLOCKS=y. Signed-off-by: Guo Ren Signed-off-by: Guo Ren --- Documentation/admin-guide/kernel-parameters.txt | 2 ++ arch/riscv/kernel/setup.c

Re: [PATCH V11 07/17] riscv: qspinlock: Introduce qspinlock param for command line

2023-09-11 Thread Waiman Long
On 9/10/23 04:29, guo...@kernel.org wrote: From: Guo Ren Allow cmdline to force the kernel to use queued_spinlock when CONFIG_RISCV_COMBO_SPINLOCKS=y. Signed-off-by: Guo Ren Signed-off-by: Guo Ren --- Documentation/admin-guide/kernel-parameters.txt | 2 ++ arch/riscv/kernel/setup.c

Re: [PATCH V11 04/17] locking/qspinlock: Improve xchg_tail for number of cpus >= 16k

2023-09-11 Thread Waiman Long
On 9/10/23 23:09, Guo Ren wrote: On Mon, Sep 11, 2023 at 10:35 AM Waiman Long wrote: On 9/10/23 04:28, guo...@kernel.org wrote: From: Guo Ren The target of xchg_tail is to write the tail to the lock value, so adding prefetchw could help the next cmpxchg step, which may decrease the cmpxchg

Re: [PATCH RFC v2 0/3] vdpa: dedicated descriptor table group

2023-09-11 Thread Dragos Tatulea via Virtualization
Hi Jason, On Mon, 2023-09-11 at 14:43 +0800, Jason Wang wrote: > On Sat, Sep 9, 2023 at 4:45 PM Si-Wei Liu wrote: > > > > Following patchset introduces dedicated group for descriptor table to > > reduce live migration downtime when passthrough VQ is being switched > > to shadow VQ. This RFC v2 i