Re: [PATCH V10 18/19] locking/qspinlock: Move pv_ops into x86 directory

2023-08-11 Thread Waiman Long
On 8/11/23 20:24, Guo Ren wrote: On Sat, Aug 12, 2023 at 4:42 AM Waiman Long wrote: On 8/2/23 12:47, guo...@kernel.org wrote: From: Guo Ren The pv_ops belongs to x86 custom infrastructure and cleans up the cna_configure_spin_lock_slowpath() with standard code. This is preparation for riscv

Re: [PATCH v11 8/8] vhost: use vhost_tasks for worker threads

2023-08-11 Thread Mike Christie
On 8/10/23 1:57 PM, Michael S. Tsirkin wrote: > On Sat, Jul 22, 2023 at 11:03:29PM -0500, michael.chris...@oracle.com wrote: >> On 7/20/23 8:06 AM, Michael S. Tsirkin wrote: >>> On Thu, Feb 02, 2023 at 05:25:17PM -0600, Mike Christie wrote: For vhost workers we use the kthread API which inheri

Re: [PATCH V10 18/19] locking/qspinlock: Move pv_ops into x86 directory

2023-08-11 Thread Waiman Long
On 8/2/23 12:47, guo...@kernel.org wrote: From: Guo Ren The pv_ops belongs to x86 custom infrastructure and cleans up the cna_configure_spin_lock_slowpath() with standard code. This is preparation for riscv support CNA qspoinlock. CNA qspinlock has not been merged into mainline yet. I will su

Re: [PATCH V10 05/19] riscv: qspinlock: Introduce combo spinlock

2023-08-11 Thread Waiman Long
On 8/2/23 12:46, guo...@kernel.org wrote: From: Guo Ren Combo spinlock could support queued and ticket in one Linux Image and select them during boot time via errata mechanism. Here is the func size (Bytes) comparison table below: TYPE: COMBO | TICKET | QUEUED arch_spin_loc

Re: [PATCH V10 04/19] riscv: qspinlock: Add basic queued_spinlock support

2023-08-11 Thread Waiman Long
On 8/2/23 12:46, guo...@kernel.org wrote: \ diff --git a/arch/riscv/include/asm/spinlock.h b/arch/riscv/include/asm/spinlock.h new file mode 100644 index ..c644a92d4548 --- /dev/null +++ b/arch/riscv/include/asm/spinlock.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2

Re: [PATCH net-next 7/8] virtio-net: support tx netdim

2023-08-11 Thread kernel test robot
Hi Heng, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio-net-initially-change-the-value-of-tx-frames/20230811-150529 base: net-next/main patch link: https

Re: [PATCH net-next 6/8] virtio-net: support rx netdim

2023-08-11 Thread kernel test robot
Hi Heng, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio-net-initially-change-the-value-of-tx-frames/20230811-150529 base: net-next/main patch link: https

[PATCH -next] drm/virtio: Remove unused function declarations

2023-08-11 Thread Yue Haibing via Virtualization
Commit dc5698e80cf7 ("Add virtio gpu driver.") declared but never implemented virtio_gpu_attach_status_page()/virtio_gpu_detach_status_page() Also commit 62fb7a5e1096 ("virtio-gpu: add 3d/virgl support") declared but never implemented virtio_gpu_fence_ack() and virtio_gpu_dequeue_fence_func(). Comm

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2023 at 05:54:15PM +0800, Jason Wang wrote: > On Fri, Aug 11, 2023 at 5:51 PM Michael S. Tsirkin wrote: > > > > On Fri, Aug 11, 2023 at 05:43:25PM +0800, Jason Wang wrote: > > > On Fri, Aug 11, 2023 at 5:21 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Aug 11, 2023 a

Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Jason Wang
On Fri, Aug 11, 2023 at 5:48 PM Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2023 at 05:41:44PM +0800, Jason Wang wrote: > > On Fri, Aug 11, 2023 at 5:25 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > > > > We try to build affinity mask via

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-08-11 Thread Jason Wang
On Fri, Aug 11, 2023 at 5:51 PM Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2023 at 05:43:25PM +0800, Jason Wang wrote: > > On Fri, Aug 11, 2023 at 5:21 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Aug 11, 2023 at 05:18:51PM +0800, Jason Wang wrote: > > > > On Fri, Aug 11, 2023 at 1:42 PM M

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2023 at 05:43:25PM +0800, Jason Wang wrote: > On Fri, Aug 11, 2023 at 5:21 PM Michael S. Tsirkin wrote: > > > > On Fri, Aug 11, 2023 at 05:18:51PM +0800, Jason Wang wrote: > > > On Fri, Aug 11, 2023 at 1:42 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Aug 11, 2023 a

Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2023 at 05:41:44PM +0800, Jason Wang wrote: > On Fri, Aug 11, 2023 at 5:25 PM Michael S. Tsirkin wrote: > > > > On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > > > We try to build affinity mask via create_affinity_masks() > > > unconditionally which may lead several i

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-08-11 Thread Jason Wang
On Fri, Aug 11, 2023 at 5:21 PM Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2023 at 05:18:51PM +0800, Jason Wang wrote: > > On Fri, Aug 11, 2023 at 1:42 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Aug 11, 2023 at 10:23:15AM +0800, Jason Wang wrote: > > > > On Fri, Aug 11, 2023 at 3:41 AM M

Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Jason Wang
On Fri, Aug 11, 2023 at 5:25 PM Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > > We try to build affinity mask via create_affinity_masks() > > unconditionally which may lead several issues: > > > > - the affinity mask is not used for parent without affi

Re: [PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2023 at 05:15:39AM -0400, Jason Wang wrote: > We try to build affinity mask via create_affinity_masks() > unconditionally which may lead several issues: > > - the affinity mask is not used for parent without affinity support > (only VDUSE support the affinity now) > - the logic o

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-08-11 Thread Michael S. Tsirkin
On Fri, Aug 11, 2023 at 05:18:51PM +0800, Jason Wang wrote: > On Fri, Aug 11, 2023 at 1:42 PM Michael S. Tsirkin wrote: > > > > On Fri, Aug 11, 2023 at 10:23:15AM +0800, Jason Wang wrote: > > > On Fri, Aug 11, 2023 at 3:41 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Aug 08, 2023 a

Re: [PATCH net-next v4 2/2] virtio-net: add cond_resched() to the command waiting loop

2023-08-11 Thread Jason Wang
On Fri, Aug 11, 2023 at 1:42 PM Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2023 at 10:23:15AM +0800, Jason Wang wrote: > > On Fri, Aug 11, 2023 at 3:41 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Aug 08, 2023 at 10:30:56AM +0800, Jason Wang wrote: > > > > On Mon, Jul 31, 2023 at 2:30 PM J

[PATCH] virtio_vdpa: build affinity masks conditionally

2023-08-11 Thread Jason Wang
We try to build affinity mask via create_affinity_masks() unconditionally which may lead several issues: - the affinity mask is not used for parent without affinity support (only VDUSE support the affinity now) - the logic of create_affinity_masks() might not work for devices other than block.