Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Xuan Zhuo
On Thu, 10 Aug 2023 02:39:47 -0400, "Michael S. Tsirkin" wrote: > On Thu, Aug 10, 2023 at 09:56:54AM +0800, Xuan Zhuo wrote: > > > > Ping!! > > > > Could we push this to the next linux version? > > > > Thanks. > > You sent v12, so not this one for sure. > v12 triggered kbuild warnings, you need t

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Michael S. Tsirkin
On Thu, Aug 10, 2023 at 02:37:20PM +0800, Jason Wang wrote: > On Thu, Aug 10, 2023 at 9:59 AM Xuan Zhuo wrote: > > > > > > Ping!! > > > > Could we push this to the next linux version? > > How about implementing the wrappers along with virtqueue_dma_dev() to > see if Christoph is happy? > > Thank

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Michael S. Tsirkin
On Thu, Aug 10, 2023 at 09:56:54AM +0800, Xuan Zhuo wrote: > > Ping!! > > Could we push this to the next linux version? > > Thanks. You sent v12, so not this one for sure. v12 triggered kbuild warnings, you need to fix them and repost. Note that I'm on vacation from monday, so if you want this

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Jason Wang
On Thu, Aug 10, 2023 at 9:59 AM Xuan Zhuo wrote: > > > Ping!! > > Could we push this to the next linux version? How about implementing the wrappers along with virtqueue_dma_dev() to see if Christoph is happy? Thanks > > Thanks. > ___ Virtualization m

Re: [PATCH] virtio-net: Zero max_tx_vq field for VIRTIO_NET_CTRL_MQ_HASH_CONFIG case

2023-08-09 Thread Jason Wang
On Thu, Aug 10, 2023 at 11:16 AM Hawkins Jiawei wrote: > > Kernel uses `struct virtio_net_ctrl_rss` to save command-specific-data > for both the VIRTIO_NET_CTRL_MQ_HASH_CONFIG and > VIRTIO_NET_CTRL_MQ_RSS_CONFIG commands. This is tricky. > > According to the VirtIO standard, "Field reserved MUST

Re: [PATCH RFC 0/3] vdpa: dedicated descriptor table group

2023-08-09 Thread Jason Wang
On Wed, Aug 9, 2023 at 8:56 PM Si-Wei Liu wrote: > > Following patchset introduces dedicated group for descriptor table to > reduce live migration downtime when passthrough VQ is being switched > to shadow VQ. As this RFC set is to seek early feedback on the uAPI > and driver API part, for now the

Re: [PATCH RFC 2/3] vhost-vdpa: introduce descriptor group backend feature

2023-08-09 Thread Jason Wang
On Wed, Aug 9, 2023 at 8:56 PM Si-Wei Liu wrote: > > Userspace knows if the device has dedicated descriptor group or not > by checking this feature bit. > > It's only exposed if the vdpa driver backend implements the > .get_vq_desc_group() operation callback. Userspace trying to negotiate > this f

[PATCH net V2] virtio-net: set queues after driver_ok

2023-08-09 Thread Jason Wang
Commit 25266128fe16 ("virtio-net: fix race between set queues and probe") tries to fix the race between set queues and probe by calling _virtnet_set_queues() before DRIVER_OK is set. This violates virtio spec. Fixing this by setting queues after virtio_device_ready(). Note that rtnl needs to be he

Re: [PATCH net] virtio-net: set queues after driver_ok

2023-08-09 Thread Jason Wang
On Wed, Aug 9, 2023 at 2:51 PM Michael S. Tsirkin wrote: > > On Wed, Aug 09, 2023 at 02:45:17PM +0800, Jason Wang wrote: > > On Wed, Aug 9, 2023 at 2:23 PM Dragos Tatulea wrote: > > > > > > On Tue, 2023-08-08 at 23:13 -0400, Jason Wang wrote: > > > > Commit 25266128fe16 ("virtio-net: fix race bet

Re: [PATCH 1/2] vdpa/mlx5: Fix mr->initialized semantics

2023-08-09 Thread Jason Wang
On Thu, Aug 10, 2023 at 8:40 AM Si-Wei Liu wrote: > > > > On 8/8/2023 11:52 PM, Jason Wang wrote: > > On Wed, Aug 9, 2023 at 6:58 AM Si-Wei Liu wrote: > >> > >> > >> On 8/7/2023 8:00 PM, Jason Wang wrote: > >>> On Fri, Aug 4, 2023 at 1:58 AM Si-Wei Liu wrote: > > On 8/3/2023 1:03 AM, J

Re: Unbinding virtio_pci_modern does not release BAR4 in Linux 6.5.0-rc4

2023-08-09 Thread Jason Wang
On Thu, Aug 3, 2023 at 10:37 PM Stefan Hajnoczi wrote: > > Hi, > After running "driverctl --nosave set-override :01:00.0 vfio-pci" on > a virtio-blk-pci device, /proc/iomem shows that BAR4 is still owned by > virtio_pci_modern even though the vfio-pci driver is now bound to the > PCI device. >

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-08-09 Thread Xuan Zhuo
Ping!! Could we push this to the next linux version? Thanks. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 1/2] vdpa/mlx5: Fix mr->initialized semantics

2023-08-09 Thread Si-Wei Liu
On 8/8/2023 11:52 PM, Jason Wang wrote: On Wed, Aug 9, 2023 at 6:58 AM Si-Wei Liu wrote: On 8/7/2023 8:00 PM, Jason Wang wrote: On Fri, Aug 4, 2023 at 1:58 AM Si-Wei Liu wrote: On 8/3/2023 1:03 AM, Jason Wang wrote: On Thu, Aug 3, 2023 at 1:13 AM Dragos Tatulea wrote: The mr->initial

Re: [PATCH -next 1/7] drm/amdkfd: Remove unnecessary NULL values

2023-08-09 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 9, 2023 at 2:15 AM Christian König wrote: > > Am 09.08.23 um 05:44 schrieb Ruan Jinjie: > > The NULL initialization of the pointers assigned by kzalloc() first is > > not necessary, because if the kzalloc() failed, the pointers will be > > assigned NULL, otherwise it

[PATCH RFC 2/3] vhost-vdpa: introduce descriptor group backend feature

2023-08-09 Thread Si-Wei Liu
Userspace knows if the device has dedicated descriptor group or not by checking this feature bit. It's only exposed if the vdpa driver backend implements the .get_vq_desc_group() operation callback. Userspace trying to negotiate this feature when it or the dependent _F_IOTLB_ASID feature hasn't be

[PATCH RFC 0/3] vdpa: dedicated descriptor table group

2023-08-09 Thread Si-Wei Liu
Following patchset introduces dedicated group for descriptor table to reduce live migration downtime when passthrough VQ is being switched to shadow VQ. As this RFC set is to seek early feedback on the uAPI and driver API part, for now there's no associated driver patch consuming the API. As soon a

[PATCH RFC 1/3] vdpa: introduce dedicated descriptor group for virtqueue

2023-08-09 Thread Si-Wei Liu
In some cases, the access to the virtqueue's descriptor table (including the associated available and used ring for split layout) has to be isolated from guest memory access where the buffer address contained in vring descriptor points to. Introduce dedicated descriptor group with driver op .get_vq

[PATCH RFC 3/3] vhost-vdpa: uAPI to get dedicated descriptor group id

2023-08-09 Thread Si-Wei Liu
With _F_DESC_ASID backend feature, the device can now support the VHOST_VDPA_GET_VRING_DESC_GROUP ioctl, and it may expose the descriptor table (including avail and used ring) in a different group than the buffers it contains. This new uAPI will fetch the group ID of the descriptor table. Signed-o