Re: [PATCH] x86/paravirt: Fix tlb_remove_table function callback prototype warning

2023-08-03 Thread Kees Cook
On Wed, 26 Jul 2023 16:11:43 -0700, Kees Cook wrote: > Under W=1, this warning is visible in Clang 16 and newer: > > arch/x86/kernel/paravirt.c:337:4: warning: cast from 'void (*)(struct > mmu_gather *, struct page *)' to 'void (*)(struct mmu_gather *, void *)' > converts to incompatible functio

Re: [PATCH 1/2] vdpa/mlx5: Fix mr->initialized semantics

2023-08-03 Thread Si-Wei Liu
On 8/3/2023 1:03 AM, Jason Wang wrote: On Thu, Aug 3, 2023 at 1:13 AM Dragos Tatulea wrote: The mr->initialized flag is shared between the control vq and data vq part of the mr init/uninit. But if the control vq and data vq get placed in different ASIDs, it can happen that initializing the co

[PATCH v2] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-08-03 Thread Dragos Tatulea via Virtualization
The ndev was accessed on shutdown without a check if it actually exists. This triggered the crash pasted below. Instead of doing the ndev check, delete the shutdown handler altogether. The irqs will be released at the parent VF level (mlx5_core). BUG: kernel NULL pointer dereference, address: 00

Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-08-03 Thread Michael S. Tsirkin
On Thu, Aug 03, 2023 at 03:02:59PM +, Dragos Tatulea wrote: > On Wed, 2023-08-02 at 09:56 +0200, Dragos Tatulea wrote: > > On Wed, 2023-08-02 at 10:51 +0800, Jason Wang wrote: > > > On Tue, Aug 1, 2023 at 4:17 PM Dragos Tatulea wrote: > > > > > > > > On Tue, 2023-08-01 at 11:59 +0800, Jason W

Re: [PATCH] vdpa/mlx5: Fix crash on shutdown for when no ndev exists

2023-08-03 Thread Dragos Tatulea via Virtualization
On Wed, 2023-08-02 at 09:56 +0200, Dragos Tatulea wrote: > On Wed, 2023-08-02 at 10:51 +0800, Jason Wang wrote: > > On Tue, Aug 1, 2023 at 4:17 PM Dragos Tatulea wrote: > > > > > > On Tue, 2023-08-01 at 11:59 +0800, Jason Wang wrote: > > > > On Mon, Jul 31, 2023 at 5:08 PM Michael S. Tsirkin > >

Unbinding virtio_pci_modern does not release BAR4 in Linux 6.5.0-rc4

2023-08-03 Thread Stefan Hajnoczi
Hi, After running "driverctl --nosave set-override :01:00.0 vfio-pci" on a virtio-blk-pci device, /proc/iomem shows that BAR4 is still owned by virtio_pci_modern even though the vfio-pci driver is now bound to the PCI device. This regression was introduced after 6.4.7 but I don't see the culpr

[PATCH -next] vdpa/mlx5: Remove unused function declarations

2023-08-03 Thread Yue Haibing via Virtualization
Commit 29064bfdabd5 ("vdpa/mlx5: Add support library for mlx5 VDPA implementation") declared but never implemented these. Signed-off-by: Yue Haibing --- drivers/vdpa/mlx5/core/mlx5_vdpa.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/vdpa/mlx5/core/mlx5_vdpa.h b/drivers/vdpa/ml

[PATCH -next] af_vsock: Remove unused declaration vsock_release_pending()/vsock_init_tap()

2023-08-03 Thread Yue Haibing via Virtualization
Commit d021c344051a ("VSOCK: Introduce VM Sockets") declared but never implemented vsock_release_pending(). Also vsock_init_tap() never implemented since introduction in commit 531b374834c8 ("VSOCK: Add vsockmon tap functions"). Signed-off-by: Yue Haibing --- include/net/af_vsock.h | 2 -- 1 f

Re: [PATCH RFC net-next v5 03/14] af_vsock: support multi-transport datagrams

2023-08-03 Thread Stefano Garzarella
On Thu, Aug 03, 2023 at 12:53:22AM +, Bobby Eshleman wrote: On Wed, Aug 02, 2023 at 10:24:44PM +, Bobby Eshleman wrote: On Sun, Jul 23, 2023 at 12:53:15AM +0300, Arseniy Krasnov wrote: > > > On 19.07.2023 03:50, Bobby Eshleman wrote: > > This patch adds support for multi-transport datagr

Re: [PATCH 1/2] vdpa/mlx5: Fix mr->initialized semantics

2023-08-03 Thread Dragos Tatulea via Virtualization
On Thu, 2023-08-03 at 16:03 +0800, Jason Wang wrote: > On Thu, Aug 3, 2023 at 1:13 AM Dragos Tatulea wrote: > > > > The mr->initialized flag is shared between the control vq and data vq > > part of the mr init/uninit. But if the control vq and data vq get placed > > in different ASIDs, it can hap

[PATCH net] test/vsock: remove vsock_perf executable on `make clean`

2023-08-03 Thread Stefano Garzarella
We forgot to add vsock_perf to the rm command in the `clean` target, so now we have a left over after `make clean` in tools/testing/vsock. Fixes: 8abbffd27ced ("test/vsock: vsock_perf utility") Cc: avkras...@sberdevices.ru Signed-off-by: Stefano Garzarella --- tools/testing/vsock/Makefile | 2 +-

Re: [PATCH 1/2] vdpa/mlx5: Fix mr->initialized semantics

2023-08-03 Thread Jason Wang
On Thu, Aug 3, 2023 at 1:13 AM Dragos Tatulea wrote: > > The mr->initialized flag is shared between the control vq and data vq > part of the mr init/uninit. But if the control vq and data vq get placed > in different ASIDs, it can happen that initializing the control vq will > prevent the data vq