Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-13 Thread Jason Wang
On Fri, Jul 14, 2023 at 12:37 PM Xuan Zhuo wrote: > > On Fri, 14 Jul 2023 11:57:05 +0800, Jason Wang wrote: > > On Thu, Jul 13, 2023 at 3:02 PM Xuan Zhuo > > wrote: > > > > > > On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang > > > wrote: > > > > On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo > >

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-13 Thread Xuan Zhuo
On Fri, 14 Jul 2023 11:57:05 +0800, Jason Wang wrote: > On Thu, Jul 13, 2023 at 3:02 PM Xuan Zhuo wrote: > > > > On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang wrote: > > > On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo > > > wrote: > > > > > > > > > > I'd suggest to tweak the title like: > > > >

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-13 Thread Jason Wang
On Thu, Jul 13, 2023 at 3:02 PM Xuan Zhuo wrote: > > On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang wrote: > > On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo > > wrote: > > > > > > > I'd suggest to tweak the title like: > > > > "merge dma operations when refilling mergeable buffers" > > > > > Curre

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-13 Thread Jason Wang
On Thu, Jul 13, 2023 at 2:54 PM Xuan Zhuo wrote: > > On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang wrote: > > On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo > > wrote: > > > > > > > I'd suggest to tweak the title like: > > > > "merge dma operations when refilling mergeable buffers" > > > > > Curre

Re: [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support

2023-07-13 Thread Xuan Zhuo
On Thu, 13 Jul 2023 07:40:12 -0400, "Michael S. Tsirkin" wrote: > On Mon, Jul 10, 2023 at 12:20:01PM +0300, Gavin Li wrote: > > Currently, coalescing parameters are grouped for all transmit and receive > > virtqueues. This patch series add support to set or get the parameters for > > a specified

Re: [PATCH 0/2] eventfd: simplify signal helpers

2023-07-13 Thread Alex Williamson
On Thu, 13 Jul 2023 12:05:36 +0200 Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > by removing the count argument which is effectively unused. We have a patch under review which does in fact make use of the signaling value:

[CfP] Confidential Computing Microconference @ LPC 2023

2023-07-13 Thread Jörg Rödel
Hi, We are pleased to announce the call for presentations for this years Confidential Computing MC at the Linux Plumbers Conference. In this microconference we want to discuss ongoing developments around Linux support for memory encryption and support for confidential computing in general. Topic

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Sean Paul
On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König wrote: > > hello Sean, > > On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: > > I'd really prefer this patch (series or single) is not accepted. This > > will cause problems for everyone cherry-picking patches to a > > downstream kernel (L

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 16:41 schrieb Sean Paul: On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König wrote: hello Sean, On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: I'd really prefer this patch (series or single) is not accepted. This will cause problems for everyone cherry-picking pat

Re: [PATCH v1 0/4] virtio-mem: memory unplug/offlining related cleanups

2023-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2023 at 04:55:47PM +0200, David Hildenbrand wrote: > Some cleanups+optimizations primarily around offline_and_remove_memory(). > > Patch #1 drops the "unsafe unplug" feature where we might get stuck in > offline_and_remove_memory() forever. > > Patch #2 handles unexpected errors f

[PATCH v1 4/4] virtio-mem: check if the config changed before fake offlining memory

2023-07-13 Thread David Hildenbrand
If we repeatedly fail to fake offline memory to unplug it, we won't be sending any unplug requests to the device. However, we only check if the config changed when sending such (un)plug requests. We could end up trying for a long time to unplug memory, even though the config changed already and we

[PATCH v1 2/4] virtio-mem: convert most offline_and_remove_memory() errors to -EBUSY

2023-07-13 Thread David Hildenbrand
Just like we do with alloc_contig_range(), let's convert all unknown errors to -EBUSY, but WARN so we can look into the issue. For example, offline_pages() could fail with -EINTR, which would be unexpected in our case. Signed-off-by: David Hildenbrand --- drivers/virtio/virtio_mem.c | 12 +++

[PATCH v1 3/4] virtio-mem: keep retrying on offline_and_remove_memory() errors in Sub Block Mode (SBM)

2023-07-13 Thread David Hildenbrand
In case offline_and_remove_memory() fails in SBM, we leave a completely unplugged Linux memory block stick around until we try plugging memory again. We won't try removing that memory block again. offline_and_remove_memory() may, for example, fail if we're racing with another alloc_contig_range()

[PATCH v1 0/4] virtio-mem: memory unplug/offlining related cleanups

2023-07-13 Thread David Hildenbrand
Some cleanups+optimizations primarily around offline_and_remove_memory(). Patch #1 drops the "unsafe unplug" feature where we might get stuck in offline_and_remove_memory() forever. Patch #2 handles unexpected errors from offline_and_remove_memory() a bit nicer. Patch #3 handles the case where o

[PATCH v1 1/4] virtio-mem: remove unsafe unplug in Big Block Mode (BBM)

2023-07-13 Thread David Hildenbrand
When "unsafe unplug" is enabled, we don't fake-offline all memory ahead of actual memory offlining using alloc_contig_range(). Instead, we rely on offline_pages() to also perform actual page migration, which might fail or take a very long time. In that case, it's possible to easily run into endles

Re: [PATCH vhost v11 03/10] virtio_ring: introduce virtqueue_set_premapped()

2023-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2023 at 04:14:45AM -0700, Christoph Hellwig wrote: > On Mon, Jul 10, 2023 at 11:42:30AM +0800, Xuan Zhuo wrote: > > This helper allows the driver change the dma mode to premapped mode. > > Under the premapped mode, the virtio core do not do dma mapping > > internally. > > > > This

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2023 at 04:15:16AM -0700, Christoph Hellwig wrote: > On Mon, Jul 10, 2023 at 11:42:32AM +0800, Xuan Zhuo wrote: > > Added virtqueue_dma_dev() to get DMA device for virtio. Then the > > caller can do dma operation in advance. The purpose is to keep memory > > mapped across multiple a

Re: [PATCH vhost v11 03/10] virtio_ring: introduce virtqueue_set_premapped()

2023-07-13 Thread Michael S. Tsirkin
On Thu, Jul 13, 2023 at 04:14:45AM -0700, Christoph Hellwig wrote: > On Mon, Jul 10, 2023 at 11:42:30AM +0800, Xuan Zhuo wrote: > > This helper allows the driver change the dma mode to premapped mode. > > Under the premapped mode, the virtio core do not do dma mapping > > internally. > > > > This

Re: [PATCH v2 0/2] vhost-scsi: Fix IO hangs when using windows

2023-07-13 Thread Stefan Hajnoczi
On Thu, Jul 13, 2023 at 03:55:45PM +1000, Vadim Rozenfeld wrote: > Currently we use 4-byte alignmed (FILE_LONG_ALIGNMENT) in both Windows > virtio blk and scsi miniport drivers. > It shouldn't be a problem to change it to 512 by setting AlignmentMask > field of PORT_CONFIGURATION_INFORMATION struc

Re: [PATCH v2 0/2] vhost-scsi: Fix IO hangs when using windows

2023-07-13 Thread Stefan Hajnoczi
On Wed, Jul 12, 2023 at 11:05:11AM -0500, Mike Christie wrote: > On 7/12/23 9:26 AM, Stefan Hajnoczi wrote: > > On Tue, Jul 11, 2023 at 04:01:22PM -0500, Mike Christie wrote: > >> On 7/11/23 1:34 PM, Stefan Hajnoczi wrote: > >>> On Sun, Jul 09, 2023 at 03:28:57PM -0500, Mike Christie wrote: >

Re: [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support

2023-07-13 Thread Michael S. Tsirkin
On Mon, Jul 10, 2023 at 12:20:01PM +0300, Gavin Li wrote: > Currently, coalescing parameters are grouped for all transmit and receive > virtqueues. This patch series add support to set or get the parameters for > a specified virtqueue. > > When the traffic between virtqueues is unbalanced, for exa

Re: [PATCH vhost v11 05/10] virtio_ring: introduce virtqueue_dma_dev()

2023-07-13 Thread Christoph Hellwig
On Mon, Jul 10, 2023 at 11:42:32AM +0800, Xuan Zhuo wrote: > Added virtqueue_dma_dev() to get DMA device for virtio. Then the > caller can do dma operation in advance. The purpose is to keep memory > mapped across multiple add/get buf operations. This is just poking holes into the abstraction.. _

Re: [PATCH vhost v11 03/10] virtio_ring: introduce virtqueue_set_premapped()

2023-07-13 Thread Christoph Hellwig
On Mon, Jul 10, 2023 at 11:42:30AM +0800, Xuan Zhuo wrote: > This helper allows the driver change the dma mode to premapped mode. > Under the premapped mode, the virtio core do not do dma mapping > internally. > > This just work when the use_dma_api is true. If the use_dma_api is false, > the dma

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Geert Uytterhoeven
Hi Jani, On Thu, Jul 13, 2023 at 11:03 AM Jani Nikula wrote: > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > >> On Wed, 12 Jul 2023, Uwe Kleine-König > >> wrote: > >> > while I debugged an issue in the imx-lcdc driver I was cons

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Thomas Zimmermann
Hi Am 12.07.23 um 11:46 schrieb Uwe Kleine-König: Hello, while I debugged an issue in the imx-lcdc driver I was constantly irritated about struct drm_device pointer variables being named "dev" because with that name I usually expect a struct device pointer. Rather than renaming dev in all the

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Thomas Zimmermann
Hi Am 12.07.23 um 20:31 schrieb Sean Paul: On Wed, Jul 12, 2023 at 10:52 AM Jani Nikula wrote: On Wed, 12 Jul 2023, Uwe Kleine-König wrote: Hello, while I debugged an issue in the imx-lcdc driver I was constantly irritated about struct drm_device pointer variables being named "dev" because

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Thomas Zimmermann
Hi Am 12.07.23 um 18:10 schrieb Uwe Kleine-König: Hello Jani, On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: On Wed, 12 Jul 2023, Uwe Kleine-König wrote: Hello, while I debugged an issue in the imx-lcdc driver I was constantly irritated about struct drm_device pointer variable

Re: [PATCH vhost v11 10/10] virtio_net: merge dma operation for one page

2023-07-13 Thread Xuan Zhuo
On Thu, 13 Jul 2023 12:20:01 +0800, Jason Wang wrote: > On Mon, Jul 10, 2023 at 11:43 AM Xuan Zhuo wrote: > > > > I'd suggest to tweak the title like: > > "merge dma operations when refilling mergeable buffers" > > > Currently, the virtio core will perform a dma operation for each > > operation.