Re: [PATCH v2] vdpa/vp_vdpa: Check queue number of vdpa device from add_config

2023-06-25 Thread Jason Wang
On Mon, Jun 26, 2023 at 11:02 AM Angus Chen wrote: > > > > > -Original Message- > > From: Jason Wang > > Sent: Monday, June 26, 2023 10:51 AM > > To: Angus Chen > > Cc: m...@redhat.com; virtualization@lists.linux-foundation.org; > > linux-ker...@vger.kernel.org > > Subject: Re: [PATCH v2

Re: [PATCH V2 1/3] vDPA/ifcvf: dynamic allocate vq data stores

2023-06-25 Thread Zhu, Lingshan
On 6/26/2023 10:49 AM, Jason Wang wrote: On Mon, Jun 26, 2023 at 10:38 AM Zhu, Lingshan wrote: On 6/26/2023 10:32 AM, Jason Wang wrote: On Mon, Jun 12, 2023 at 3:14 PM Zhu Lingshan wrote: This commit dynamically allocates the data stores for the virtqueues based on virtio_pci_common_cfg.

Re: [PATCH v2] vdpa/vp_vdpa: Check queue number of vdpa device from add_config

2023-06-25 Thread Jason Wang
On Mon, Jun 26, 2023 at 10:42 AM Angus Chen wrote: > > > Hi,jason. > > -Original Message- > > From: Jason Wang > > Sent: Monday, June 26, 2023 10:30 AM > > To: Angus Chen > > Cc: m...@redhat.com; virtualization@lists.linux-foundation.org; > > linux-ker...@vger.kernel.org > > Subject: Re:

Re: [PATCH V2 1/3] vDPA/ifcvf: dynamic allocate vq data stores

2023-06-25 Thread Jason Wang
On Mon, Jun 26, 2023 at 10:38 AM Zhu, Lingshan wrote: > > > > On 6/26/2023 10:32 AM, Jason Wang wrote: > > On Mon, Jun 12, 2023 at 3:14 PM Zhu Lingshan wrote: > >> This commit dynamically allocates the data > >> stores for the virtqueues based on > >> virtio_pci_common_cfg.num_queues. > > While a

Re: [PATCH V2 3/3] vDPA/ifcvf: implement new accessors for vq_state

2023-06-25 Thread Jason Wang
On Mon, Jun 12, 2023 at 3:14 PM Zhu Lingshan wrote: > > This commit implements a better layout of the > live migration bar, therefore the accessors for virtqueue > state have been refactored. I guess the reason for F2000X is that it can report a #vq which is greater than IFCVF_MAX_QUEUES. If yes,

Re: [PATCH V2 1/3] vDPA/ifcvf: dynamic allocate vq data stores

2023-06-25 Thread Zhu, Lingshan
On 6/26/2023 10:32 AM, Jason Wang wrote: On Mon, Jun 12, 2023 at 3:14 PM Zhu Lingshan wrote: This commit dynamically allocates the data stores for the virtqueues based on virtio_pci_common_cfg.num_queues. While at it, it's better to allocate vring_lm_cfg as well and drop IFCVF_MAX_QUEUES. Y

Re: [PATCH V2 2/3] vDPA/ifcvf: detect and report max allowed vq size

2023-06-25 Thread Jason Wang
On Mon, Jun 12, 2023 at 3:14 PM Zhu Lingshan wrote: > > Rather than a hardcode, this commit detects > and reports the max value of allowed size > of the virtqueues > > Signed-off-by: Zhu Lingshan Acked-by: Jason Wang Thanks > --- > drivers/vdpa/ifcvf/ifcvf_base.c | 31 +++

Re: [PATCH V2 1/3] vDPA/ifcvf: dynamic allocate vq data stores

2023-06-25 Thread Jason Wang
On Mon, Jun 12, 2023 at 3:14 PM Zhu Lingshan wrote: > > This commit dynamically allocates the data > stores for the virtqueues based on > virtio_pci_common_cfg.num_queues. While at it, it's better to allocate vring_lm_cfg as well and drop IFCVF_MAX_QUEUES. Thanks > > Signed-off-by: Zhu Lingshan

Re: [PATCH v2] vdpa/vp_vdpa: Check queue number of vdpa device from add_config

2023-06-25 Thread Jason Wang
On Thu, Jun 8, 2023 at 5:02 PM Angus Chen wrote: > > When add virtio_pci vdpa device,check the vqs number of device cap > and max_vq_pairs from add_config. > Simply starting from failing if the provisioned #qp is not > equal to the one that hardware has. > > Signed-off-by: Angus Chen > --- > v1:

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

2023-06-25 Thread Geert Uytterhoeven
Hi Dmitry, On Sun, Jun 25, 2023 at 2:41 PM Dmitry Osipenko wrote: > On 6/25/23 11:47, Geert Uytterhoeven wrote: > > On Sun, Apr 16, 2023 at 1:55 PM Dmitry Osipenko > > wrote: > >> Add sync object DRM UAPI support to VirtIO-GPU driver. Sync objects > >> support is needed by native context VirtIO-

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

2023-06-25 Thread Geert Uytterhoeven
Hi Dmitry, On Sun, Apr 16, 2023 at 1:55 PM Dmitry Osipenko wrote: > Add sync object DRM UAPI support to VirtIO-GPU driver. Sync objects > support is needed by native context VirtIO-GPU Mesa drivers, it also will > be used by Venus and Virgl contexts. > > Reviewed-by; Emil Velikov > Signed-off-by

Re: [PATCH vhost v10 00/10] virtio core prepares for AF_XDP

2023-06-25 Thread Jason Wang
On Wed, Jun 21, 2023 at 2:43 PM Xuan Zhuo wrote: > > Hi Jason, > > Do you have plan to review this? Just came back from vacation, will do this next week. Thanks > > Thanks. > ___ Virtualization mailing list Virtualization@lists.linux-foundation.org h

Re: [PATCH v2] vduse: fix NULL pointer dereference

2023-06-25 Thread Jason Wang
On Fri, Jun 23, 2023 at 4:49 AM Maxime Coquelin wrote: > > vduse_vdpa_set_vq_affinity callback can be called > with NULL value as cpu_mask when deleting the vduse > device. > > This patch resets virtqueue's IRQ affinity mask value > to set all CPUs instead of dereferencing NULL cpu_mask. > > [ 476