Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-08 Thread Liang Chen
On Thu, Jun 8, 2023 at 8:38 AM Jason Wang wrote: > > On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > > On Tue, May 30, 2023 at 9:19 AM Liang Chen > > > wrote: > > > > > > > > On Mon, May 29, 2023 at 5:55 PM Michael

Re: [PATCH net-next 2/5] virtio_net: Add page_pool support to improve performance

2023-06-08 Thread Liang Chen
On Thu, Jun 8, 2023 at 4:17 AM Michael S. Tsirkin wrote: > > On Wed, Jun 07, 2023 at 05:08:59PM +0800, Liang Chen wrote: > > On Tue, May 30, 2023 at 9:19 AM Liang Chen > > wrote: > > > > > > On Mon, May 29, 2023 at 5:55 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, May 29, 2023 at

Re: [PATCH] vdpa/mlx5: Support interrupt bypassing

2023-06-08 Thread Jason Wang
On Thu, Jun 8, 2023 at 3:01 AM Dragos Tatulea wrote: > > From: Eli Cohen > > Add support for generation of interrupts from the device directly to the > VM to the VCPU thus avoiding the overhead on the host CPU. > > When supported, the driver will attempt to allocate vectors for each > data virtqu

Re: [PATCH v2] vdpa/vp_vdpa: Check queue number of vdpa device from add_config

2023-06-08 Thread Jason Wang
On Fri, Jun 9, 2023 at 3:45 AM Michael S. Tsirkin wrote: > > On Thu, Jun 08, 2023 at 05:01:24PM +0800, Angus Chen wrote: > > When add virtio_pci vdpa device,check the vqs number of device cap > > and max_vq_pairs from add_config. > > Simply starting from failing if the provisioned #qp is not > > e

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Jason Wang
On Thu, Jun 8, 2023 at 10:23 PM Michael S. Tsirkin wrote: > > On Thu, Jun 08, 2023 at 05:29:58PM +0800, Jason Wang wrote: > > On Thu, Jun 8, 2023 at 5:21 PM Stefano Garzarella > > wrote: > > > > > > On Thu, Jun 08, 2023 at 05:00:00PM +0800, Jason Wang wrote: > > > >On Thu, Jun 8, 2023 at 4:00 PM

Re: [PATCH] Revert "virtio-blk: support completion batching for the IRQ path"

2023-06-08 Thread kernel test robot
Hi Michael, kernel test robot noticed the following build errors: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on linus/master v6.4-rc5 next-20230608] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] Revert "virtio-blk: support completion batching for the IRQ path"

2023-06-08 Thread kernel test robot
Hi Michael, kernel test robot noticed the following build errors: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on linus/master v6.4-rc5 next-20230608] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] Revert "virtio-blk: support completion batching for the IRQ path"

2023-06-08 Thread Michael S. Tsirkin
This reverts commit 07b679f70d73483930e8d3c293942416d9cd5c13. This change appears to have broken things... We now see applications hanging during disk accesses. e.g. multi-port virtio-blk device running in h/w (FPGA) Host running a simple 'fio' test. [global] thread=1 direct=1 ioengine=libaio nora

Re: [PATCH v2] vdpa/vp_vdpa: Check queue number of vdpa device from add_config

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 05:01:24PM +0800, Angus Chen wrote: > When add virtio_pci vdpa device,check the vqs number of device cap > and max_vq_pairs from add_config. > Simply starting from failing if the provisioned #qp is not > equal to the one that hardware has. > > Signed-off-by: Angus Chen I

Re: [PATCH] vdpa/mlx5: Support interrupt bypassing

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 04:25:55PM +, Dragos Tatulea wrote: > On Wed, 2023-06-07 at 22:00 +0300, Dragos Tatulea via Virtualization wrote: > > From: Eli Cohen > > > > Add support for generation of interrupts from the device directly to the > > VM to the VCPU thus avoiding the overhead on the h

Re: virtio-blk: support completion batching for the IRQ path - failure

2023-06-08 Thread Michael S. Tsirkin
On Fri, Jun 09, 2023 at 12:12:16AM +0900, Suwan Kim wrote: > On Thu, Jun 8, 2023 at 11:46 PM Michael S. Tsirkin wrote: > > > > On Thu, Jun 08, 2023 at 11:07:21PM +0900, Suwan Kim wrote: > > > On Thu, Jun 8, 2023 at 7:16 PM Roberts, Martin > > > wrote: > > > > > > > > The rq_affinity change does

Re: [PATCH] vdpa/mlx5: Support interrupt bypassing

2023-06-08 Thread Dragos Tatulea via Virtualization
On Wed, 2023-06-07 at 22:00 +0300, Dragos Tatulea via Virtualization wrote: > From: Eli Cohen > > Add support for generation of interrupts from the device directly to the > VM to the VCPU thus avoiding the overhead on the host CPU. > > When supported, the driver will attempt to allocate vectors

Re: virtio-blk: support completion batching for the IRQ path - failure

2023-06-08 Thread Michael S. Tsirkin
On Fri, Jun 09, 2023 at 12:12:16AM +0900, Suwan Kim wrote: > On Thu, Jun 8, 2023 at 11:46 PM Michael S. Tsirkin wrote: > > > > On Thu, Jun 08, 2023 at 11:07:21PM +0900, Suwan Kim wrote: > > > On Thu, Jun 8, 2023 at 7:16 PM Roberts, Martin > > > wrote: > > > > > > > > The rq_affinity change does

Re: [PATCH 1/2] vhost: Fix crash during early vhost_transport_send_pkt calls

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 10:39:41AM +0200, Stefano Garzarella wrote: > On Wed, Jun 07, 2023 at 02:23:37PM -0500, Mike Christie wrote: > > If userspace does VHOST_VSOCK_SET_GUEST_CID before VHOST_SET_OWNER we > > can race where: > > 1. thread0 calls vhost_transport_send_pkt -> vhost_work_queue > > 2.

Re: virtio-blk: support completion batching for the IRQ path - failure

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 11:07:21PM +0900, Suwan Kim wrote: > On Thu, Jun 8, 2023 at 7:16 PM Roberts, Martin > wrote: > > > > The rq_affinity change does not resolve the issue; just reduces its > > occurrence rate; I am still seeing hangs with it set to 2. > > > > Martin > > > > > > > > From: Rob

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 05:29:58PM +0800, Jason Wang wrote: > On Thu, Jun 8, 2023 at 5:21 PM Stefano Garzarella wrote: > > > > On Thu, Jun 08, 2023 at 05:00:00PM +0800, Jason Wang wrote: > > >On Thu, Jun 8, 2023 at 4:00 PM Stefano Garzarella > > >wrote: > > >> > > >> On Thu, Jun 08, 2023 at 03:4

[RFC PATCH 3/3] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2

2023-06-08 Thread Juergen Gross via Virtualization
Instead of stacking alternative and paravirt patching, use the new ALT_FLAG_CALL flag to switch those mixed calls to pure alternative handling. This eliminates the need to be careful regarding the sequence of alternative and paravirt patching. For call depth tracking callthunks_setup() needs to b

[RFC PATCH 1/3] x86/paravirt: move some functions and defines to alternative

2023-06-08 Thread Juergen Gross via Virtualization
As a preparation for replacing paravirt patching completely by alternative patching, move some backend functions and #defines to alternative code and header. Signed-off-by: Juergen Gross --- arch/x86/include/asm/alternative.h| 16 arch/x86/include/asm/paravirt.h |

[RFC PATCH 0/3] x86/paravirt: Get rid of paravirt patching

2023-06-08 Thread Juergen Gross via Virtualization
This is a small series getting rid of paravirt patching by switching completely to alternative patching for the same functionality. The basic idea is to add the capability to switch from indirect to direct calls via a special alternative patching option. This removes _some_ of the paravirt macro

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 05:00:00PM +0800, Jason Wang wrote: > On Thu, Jun 8, 2023 at 4:00 PM Stefano Garzarella wrote: > > > > On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang wrote: > > > > [...] > > > > >> > > > > I have a question though, what if down the road there > > >> > > > > is a new

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang wrote: > On Thu, Jun 8, 2023 at 2:03 PM Michael S. Tsirkin wrote: > > > > On Thu, Jun 08, 2023 at 08:42:15AM +0800, Jason Wang wrote: > > > On Wed, Jun 7, 2023 at 5:43 PM Michael S. Tsirkin wrote: > > > > > > > > On Wed, Jun 07, 2023 at 10:39:1

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Stefano Garzarella
On Thu, Jun 08, 2023 at 05:29:58PM +0800, Jason Wang wrote: On Thu, Jun 8, 2023 at 5:21 PM Stefano Garzarella wrote: On Thu, Jun 08, 2023 at 05:00:00PM +0800, Jason Wang wrote: >On Thu, Jun 8, 2023 at 4:00 PM Stefano Garzarella wrote: >> >> On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Jason Wang
On Thu, Jun 8, 2023 at 5:21 PM Stefano Garzarella wrote: > > On Thu, Jun 08, 2023 at 05:00:00PM +0800, Jason Wang wrote: > >On Thu, Jun 8, 2023 at 4:00 PM Stefano Garzarella > >wrote: > >> > >> On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang wrote: > >> > >> [...] > >> > >> >> > > > > I hav

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Stefano Garzarella
On Thu, Jun 08, 2023 at 05:00:00PM +0800, Jason Wang wrote: On Thu, Jun 8, 2023 at 4:00 PM Stefano Garzarella wrote: On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang wrote: [...] >> > > > > I have a question though, what if down the road there >> > > > > is a new feature that needs more

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Jason Wang
On Thu, Jun 8, 2023 at 4:00 PM Stefano Garzarella wrote: > > On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang wrote: > > [...] > > >> > > > > I have a question though, what if down the road there > >> > > > > is a new feature that needs more changes? It will be > >> > > > > broken too just lik

Re: [PATCH 1/2] vhost: Fix crash during early vhost_transport_send_pkt calls

2023-06-08 Thread Stefano Garzarella
On Wed, Jun 07, 2023 at 02:23:37PM -0500, Mike Christie wrote: If userspace does VHOST_VSOCK_SET_GUEST_CID before VHOST_SET_OWNER we can race where: 1. thread0 calls vhost_transport_send_pkt -> vhost_work_queue 2. thread1 does VHOST_SET_OWNER which calls vhost_worker_create. 3. vhost_worker_creat

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Stefano Garzarella
On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang wrote: [...] > > > > I have a question though, what if down the road there > > > > is a new feature that needs more changes? It will be > > > > broken too just like PACKED no? > > > > Shouldn't vdpa have an allowlist of features it knows how

Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature

2023-06-08 Thread Jason Wang
On Thu, Jun 8, 2023 at 2:03 PM Michael S. Tsirkin wrote: > > On Thu, Jun 08, 2023 at 08:42:15AM +0800, Jason Wang wrote: > > On Wed, Jun 7, 2023 at 5:43 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jun 07, 2023 at 10:39:15AM +0200, Stefano Garzarella wrote: > > > > On Tue, Jun 6, 2023 at 2:58