Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-05-02 Thread Gerd Hoffmann
On Mon, May 01, 2023 at 06:38:45PM +0300, Dmitry Osipenko wrote: > On 4/16/23 14:52, Dmitry Osipenko wrote: > > We have multiple Vulkan context types that are awaiting for the addition > > of the sync object DRM UAPI support to the VirtIO-GPU kernel driver: > > > > 1. Venus context > > 2. Native

RE: [PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-02 Thread Parav Pandit via Virtualization
> From: Feng Liu > Sent: Tuesday, May 2, 2023 8:35 PM > Issue: 3383038 Remove this internal garbage. > Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") > Signed-off-by: Feng Liu > Reviewed-by: William Tu > Reviewed-by: Parav Pandit > Reviewed-by: Simon Horman > Acked-by: Michael S. T

[PATCH net v3] virtio_net: Fix error unwinding of XDP initialization

2023-05-02 Thread Feng Liu via Virtualization
When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs have already initialized XDP and enabled NAPI, which is not the expected behavior. Need to roll back the previous rq initialization to avoid leaks in error unwi

Re: [Patch net] vsock: improve tap delivery accuracy

2023-05-02 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 10:44:04AM -0700, Cong Wang wrote: > From: Cong Wang > > When virtqueue_add_sgs() fails, the skb is put back to send queue, > we should not deliver the copy to tap device in this case. So we > need to move virtio_transport_deliver_tap_pkt() down after all > possible failur

Re: [PATCH net v2] virtio_net: Fix error unwinding of XDP initialization

2023-05-02 Thread Feng Liu via Virtualization
On 2023-05-02 p.m.2:32, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Tue, May 02, 2023 at 01:41:34PM -0400, Feng Liu wrote: When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However,

Re: [PATCH net v2] virtio_net: Fix error unwinding of XDP initialization

2023-05-02 Thread Michael S. Tsirkin
On Tue, May 02, 2023 at 01:41:34PM -0400, Feng Liu wrote: > When initializing XDP in virtnet_open(), some rq xdp initialization > may hit an error causing net device open failed. However, previous > rqs have already initialized XDP and enabled NAPI, which is not the > expected behavior. Need to rol

[Patch net] vsock: improve tap delivery accuracy

2023-05-02 Thread Cong Wang
From: Cong Wang When virtqueue_add_sgs() fails, the skb is put back to send queue, we should not deliver the copy to tap device in this case. So we need to move virtio_transport_deliver_tap_pkt() down after all possible failures. Fixes: 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks") Cc:

[PATCH net v2] virtio_net: Fix error unwinding of XDP initialization

2023-05-02 Thread Feng Liu via Virtualization
When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs have already initialized XDP and enabled NAPI, which is not the expected behavior. Need to roll back the previous rq initialization to avoid leaks in error unwi

[PATCH] vdpa/snet: implement the resume vDPA callback

2023-05-02 Thread Alvaro Karsz
The callback sends a resume command to the DPU through the control mechanism. Signed-off-by: Alvaro Karsz --- drivers/vdpa/solidrun/snet_ctrl.c | 6 ++ drivers/vdpa/solidrun/snet_main.c | 15 +++ drivers/vdpa/solidrun/snet_vdpa.h | 1 + 3 files changed, 22 insertions(+) diff -

Re: [PATCH v3] virtio_net: suppress cpu stall when free_unused_bufs

2023-05-02 Thread Paolo Abeni
On Sat, 2023-04-29 at 23:47 +0800, Wenliang Wang wrote: > For multi-queue and large ring-size use case, the following error > occurred when free_unused_bufs: > rcu: INFO: rcu_sched self-detected stall on CPU. > > Signed-off-by: Wenliang Wang Net next is currently closed, but this patch could arg