Re: [PATCH net] virtio-net: unify notifications coalescing structs

2023-03-05 Thread Alvaro Karsz
> Is this too late to be changed? > > Thanks You're right. What do you suggest, dropping the patch or adding the unified struct without deleting the existing ones? ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.

Re: [PATCH v1] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-05 Thread Gerd Hoffmann
> +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c > @@ -45,9 +45,11 @@ static void virtio_gpu_config_changed_work_func(struct > work_struct *work) > if (events_read & VIRTIO_GPU_EVENT_DISPLAY) { > if (vgdev->has_edid) > virtio_gpu_cmd_get_edids(vgdev); > -

[PATCH net 1/2] virtio_net: separate the logic of checking whether sq is full

2023-03-05 Thread Xuan Zhuo
Separate the logic of checking whether sq is full. The subsequent patch will reuse this func. Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 59 1 file changed, 35 insertions(+), 24 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/ne

[PATCH net 0/2] add checking sq is full inside xdp xmit

2023-03-05 Thread Xuan Zhuo
If the queue of xdp xmit is not an independent queue, then when the xdp xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter the following error. net ens4: Unexpected TXQ (0) queue failure: -28 This patch adds a check whether sq is full in XDP Xmit. Thanks. Xuan Zhuo (2):

[PATCH net 2/2] virtio_net: add checking sq is full inside xdp xmit

2023-03-05 Thread Xuan Zhuo
If the queue of xdp xmit is not an independent queue, then when the xdp xmit used all the desc, the xmit from the __dev_queue_xmit() may encounter the following error. net ens4: Unexpected TXQ (0) queue failure: -28 This patch adds a check whether sq is full in XDP Xmit. Reported-by: Yichun Zhan

Re: [PATCH v4 01/15] vdpa net: move iova tree creation from init to start

2023-03-05 Thread Jason Wang
On Fri, Mar 3, 2023 at 4:01 PM Eugenio Perez Martin wrote: > > On Fri, Mar 3, 2023 at 4:32 AM Jason Wang wrote: > > > > > > 在 2023/3/1 15:01, Eugenio Perez Martin 写道: > > > On Mon, Feb 27, 2023 at 8:04 AM Jason Wang wrote: > > >> > > >> 在 2023/2/24 23:54, Eugenio Pérez 写道: > > >>> Only create io

Re: [PATCH v4 12/15] vdpa: block migration if device has unsupported features

2023-03-05 Thread Jason Wang
On Fri, Mar 3, 2023 at 4:58 PM Eugenio Perez Martin wrote: > > On Fri, Mar 3, 2023 at 4:48 AM Jason Wang wrote: > > > > > > 在 2023/3/2 03:32, Eugenio Perez Martin 写道: > > > On Mon, Feb 27, 2023 at 9:20 AM Jason Wang wrote: > > >> On Mon, Feb 27, 2023 at 4:15 PM Jason Wang wrote: > > >>> > > >>>

Re: [PATCH net] virtio-net: unify notifications coalescing structs

2023-03-05 Thread Jason Wang
On Sun, Mar 5, 2023 at 11:49 PM Alvaro Karsz wrote: > > Unify virtio_net_ctrl_coal_tx and virtio_net_ctrl_coal_rx structs into a > single struct, virtio_net_ctrl_coal, as they are identical. > > This patch follows the VirtIO spec patch: > https://lists.oasis-open.org/archives/virtio-comment/202302

[PATCH net] virtio-net: unify notifications coalescing structs

2023-03-05 Thread Alvaro Karsz
Unify virtio_net_ctrl_coal_tx and virtio_net_ctrl_coal_rx structs into a single struct, virtio_net_ctrl_coal, as they are identical. This patch follows the VirtIO spec patch: https://lists.oasis-open.org/archives/virtio-comment/202302/msg00431.html Signed-off-by: Alvaro Karsz --- drivers/net/vi

[PATCH AUTOSEL 6.1 05/15] s390/virtio: sort out physical vs virtual pointers usage

2023-03-05 Thread Sasha Levin
From: Alexander Gordeev [ Upstream commit 5fc5b94a273655128159186c87662105db8afeb5 ] This does not fix a real bug, since virtual addresses are currently indentical to physical ones. Reviewed-by: Nico Boehr Signed-off-by: Alexander Gordeev Signed-off-by: Janosch Frank Signed-off-by: Sasha Lev

[PATCH AUTOSEL 6.2 05/16] s390/virtio: sort out physical vs virtual pointers usage

2023-03-05 Thread Sasha Levin
From: Alexander Gordeev [ Upstream commit 5fc5b94a273655128159186c87662105db8afeb5 ] This does not fix a real bug, since virtual addresses are currently indentical to physical ones. Reviewed-by: Nico Boehr Signed-off-by: Alexander Gordeev Signed-off-by: Janosch Frank Signed-off-by: Sasha Lev

Re: [PATCH v2 6/8] vdpa_sim: use kthread worker

2023-03-05 Thread kernel test robot
el/git/mst/vhost.git linux-next patch link: https://lore.kernel.org/r/20230302113421.174582-7-sgarzare%40redhat.com patch subject: [PATCH v2 6/8] vdpa_sim: use kthread worker config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230305/202303051841.bpaizjry-...@intel.com/config) compi

Re: [PATCH v3] virtio-net: Fix probe of virtio-net on kvmtool

2023-03-05 Thread Michael S. Tsirkin
On Fri, Mar 03, 2023 at 04:46:03PM -0800, Jakub Kicinski wrote: > On Thu, 2 Mar 2023 04:48:38 -0500 Michael S. Tsirkin wrote: > > > Looks not the core can try to enable and disable features according to > > > the diff between features and hw_features > > > > > > static inline netdev_features_t net