Re: [PATCH v2 01/11] genirq/affinity:: Export irq_create_affinity_masks()

2022-12-06 Thread Jason Wang
On Tue, Dec 6, 2022 at 5:28 PM Yongji Xie wrote: > > On Tue, Dec 6, 2022 at 4:47 PM Christoph Hellwig wrote: > > > > On Tue, Dec 06, 2022 at 04:40:37PM +0800, Yongji Xie wrote: > > > With the vDPA framework, some drivers (vduse, vdpa-sim) can create > > > software-defined virtio devices and attac

Re: [PATCH V2] vdpa: allow provisioning device features

2022-12-06 Thread Si-Wei Liu
On 12/5/2022 7:14 PM, Jason Wang wrote: On Tue, Dec 6, 2022 at 9:43 AM Si-Wei Liu wrote: On 12/4/2022 10:46 PM, Jason Wang wrote: On Thu, Dec 1, 2022 at 8:53 AM Si-Wei Liu wrote: Sorry for getting back late due to the snag of the holidays. No worries :) On 11/23/2022 11:13 PM, Jason

Re: [PATCH v5] virtio/vsock: replace virtio_vsock_pkt with sk_buff

2022-12-06 Thread Michael S. Tsirkin
On Fri, Dec 02, 2022 at 09:35:18AM -0800, Bobby Eshleman wrote: > This commit changes virtio/vsock to use sk_buff instead of > virtio_vsock_pkt. Beyond better conforming to other net code, using > sk_buff allows vsock to use sk_buff-dependent features in the future > (such as sockmap) and improves

Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-06 Thread Alvaro Karsz
Hi Bart, > Why does the above data structure only refer to SLC and MLC but not to > TLC or QLC? This has been discussed before. The data structure follows the virtio spec (https://docs.oasis-open.org/virtio/virtio/v1.2/csd01/virtio-v1.2-csd01.html) > How will this data structure be extended with

Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-06 Thread Bart Van Assche
On 12/5/22 08:20, Alvaro Karsz wrote: +/* Get lifetime information struct for each request */ +struct virtio_blk_lifetime { + /* +* specifies the percentage of reserved blocks that are consumed. +* optional values following virtio spec: +* 0 - undefined +* 1

Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-06 Thread Alvaro Karsz
Thanks, I will fix it in the next version. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-06 Thread Michael S. Tsirkin
On Tue, Dec 06, 2022 at 11:31:44AM -0500, Stefan Hajnoczi wrote: > On Mon, Dec 05, 2022 at 06:20:34PM +0200, Alvaro Karsz wrote: > > I don't like that the ioctl lifetime struct is passed through > little-endian from the device to userspace. The point of this new ioctl > is not to be a passthrough

Re: [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-06 Thread Stefan Hajnoczi
On Mon, Dec 05, 2022 at 06:20:34PM +0200, Alvaro Karsz wrote: I don't like that the ioctl lifetime struct is passed through little-endian from the device to userspace. The point of this new ioctl is not to be a passthrough interface. The kernel should define a proper UABI struct for the ioctl and

[PATCH v3] virtio: vdpa: new SolidNET DPU driver.

2022-12-06 Thread Alvaro Karsz
This commit includes: 1) The driver to manage the controlplane over vDPA bus. 2) A HW monitor device to read health values from the DPU. Signed-off-by: Alvaro Karsz -- v2: - Auto detect the BAR used for communication. - When waiting for the DPU to write a config, wait for 5secs

Re: [PATCH v2] vp_vdpa: harden the logic of set status

2022-12-06 Thread Stefano Garzarella
On Tue, Dec 06, 2022 at 10:13:21AM +0800, Longpeng(Mike) wrote: From: Longpeng 1. We should not set status to 0 when invoking vp_vdpa_set_status(), trigger a warning in that case. 2. The driver MUST wait for a read of device_status to return 0 before reinitializing the device. But we also

Re: [PATCH v5] virtio/vsock: replace virtio_vsock_pkt with sk_buff

2022-12-06 Thread Paolo Abeni
Hello, On Fri, 2022-12-02 at 09:35 -0800, Bobby Eshleman wrote: [...] > diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h > index 35d7eedb5e8e..6c0b2d4da3fe 100644 > --- a/include/linux/virtio_vsock.h > +++ b/include/linux/virtio_vsock.h > @@ -3,10 +3,129 @@ > #define _LINU

Re: [PATCH v2 01/11] genirq/affinity:: Export irq_create_affinity_masks()

2022-12-06 Thread Christoph Hellwig
On Tue, Dec 06, 2022 at 04:40:37PM +0800, Yongji Xie wrote: > With the vDPA framework, some drivers (vduse, vdpa-sim) can create > software-defined virtio devices and attach them to the virtio bus. > This kind of virtio device is not a pci device or a platform device. > So it would be needed to exp

Re: [PATCH V2 00/12] ifcvf/vDPA implement features provisioning

2022-12-06 Thread Jason Wang
On Fri, Nov 25, 2022 at 11:06 PM Zhu Lingshan wrote: > > This series implements features provisioning for ifcvf. > By applying this series, we allow userspace to create > a vDPA device with selected (management device supported) > feature bits and mask out others. > > Examples: > a)The management

Re: [PATCH v2 01/11] genirq/affinity:: Export irq_create_affinity_masks()

2022-12-06 Thread Christoph Hellwig
On Mon, Dec 05, 2022 at 04:41:17PM +0800, Xie Yongji wrote: > Export irq_create_affinity_masks() so that some modules > can make use of it to implement interrupt affinity > spreading mechanism. I don't think driver should be building low-level affinity masks. __