Re: [PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes

Hi Zack, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip v5.18 next-20220602] [cannot apply to airlied/drm-next tegra-drm/drm/tegra/for-next] [If your patch

Re: [PATCH 3/6] drm/qxl: Create mouse hotspot properties on cursor planes

Hi Zack, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip v5.18 next-20220602] [cannot apply to airlied/drm-next tegra-drm/drm/tegra/for-next] [If your patch

[GIT PULL] vhost,virtio,vdpa: features, fixes, cleanups

The following changes since commit 8ab2afa23bd197df47819a87f0265c0ac95c5b6a: Merge tag 'for-5.19/fbdev-1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev (2022-05-30 12:46:49 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/

Re: [PATCH v4] x86/vmware: use BIT() macro for shifting

On 6/1/22 3:18 AM, Shreenidhi Shedi wrote: > From: Shreenidhi Shedi > > Using BIT() macro improves readability & it uses unsigned long for > shifting which is an added advantage. > > Kernel builds with -fno-strict-overflow CFLAG hence shifting a signed > integer by 31 bits is not an issue in thi

Re: [PATCH v2] vringh: Fix loop descriptors check in the indirect cases

On Thu, Jun 02, 2022 at 12:55:50PM +0800, Yongji Xie wrote: > Ping. Thanks for the reminder! Will queue for rc2, rc1 has too much stuff already. > On Tue, May 10, 2022 at 3:56 PM Jason Wang wrote: > > > > On Tue, May 10, 2022 at 3:54 PM Yongji Xie wrote: > > > > > > On Tue, May 10, 2022 at 3:4

Re: [PATCH v2] vduse: Fix NULL pointer dereference on sysfs access

On Thu, Jun 02, 2022 at 12:55:02PM +0800, Yongji Xie wrote: > Ping. Thanks for the reminder! Will queue for rc2, rc1 has too much stuff already. > On Tue, Apr 26, 2022 at 3:36 PM Xie Yongji wrote: > > > > The control device has no drvdata. So we will get a > > NULL pointer dereference when acces

Re: [PATCH 0/3] recover hardware corrupted page by virtio balloon

On 02.06.22 11:28, zhenwei pi wrote: > On 6/1/22 15:59, David Hildenbrand wrote: >> On 01.06.22 04:17, zhenwei pi wrote: >>> On 5/31/22 12:08, Jue Wang wrote: On Mon, May 30, 2022 at 8:49 AM Peter Xu wrote: > > On Mon, May 30, 2022 at 07:33:35PM +0800, zhenwei pi wrote: >> A VM us

Re: Re: [PATCH 0/3] recover hardware corrupted page by virtio balloon

On 6/1/22 15:59, David Hildenbrand wrote: On 01.06.22 04:17, zhenwei pi wrote: On 5/31/22 12:08, Jue Wang wrote: On Mon, May 30, 2022 at 8:49 AM Peter Xu wrote: On Mon, May 30, 2022 at 07:33:35PM +0800, zhenwei pi wrote: A VM uses RAM of 2M huge page. Once a MCE(@HVAy in [HVAx,HVAz)) occurs

Re: [PATCH 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa_dev_net_config_fill()

On Thu, Jun 2, 2022 at 10:48 AM Zhu Lingshan wrote: > > This commit fixes spars warnings: cast to restricted __le16 > in function vdpa_dev_net_config_fill() > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/vdpa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dr

Re: [PATCH 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0

On Thu, Jun 2, 2022 at 10:48 AM Zhu Lingshan wrote: > > If VIRTIO_NET_F_MQ == 0, the virtio device should have one queue pair, > so when userspace querying queue pair numbers, it should return mq=1 > than zero Spec said: "max_virtqueue_pairs only exists if VIRTIO_NET_F_MQ is set" So we are prob

Re: [PATCH 4/6] vDPA: !FEATURES_OK should not block querying device config space

On Thu, Jun 2, 2022 at 10:48 AM Zhu Lingshan wrote: > > Users may want to query the config space of a vDPA device, > to choose a appropriate one for a certain guest. This means the > users need to read the config space before FEATURES_OK, and > the existence of config space contents does not depen

Re: [PATCH 3/6] vDPA/ifcvf: support userspace to query device feature bits

On Thu, Jun 2, 2022 at 10:48 AM Zhu Lingshan wrote: > > This commit supports userspace to query device feature bits > by filling the relevant netlink attribute. > > There are two types of netlink attributes: > VDPA_ATTR_DEV_ work for virtio devices config space, and > VDPA_ATTR_MGMTDEV_ wo

Re: [PATCH 2/6] vDPA/ifcvf: support userspace to query features and MQ of a management device

On Thu, Jun 2, 2022 at 10:48 AM Zhu Lingshan wrote: > > Adapting to current netlink interfaces, this commit allows userspace > to query feature bits and MQ capability of a management device. > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_base.c | 12 > drivers/vdpa

Re: [PATCH 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation

On Thu, Jun 2, 2022 at 10:48 AM Zhu Lingshan wrote: > > ifcvf_get_config_size() should return a virtio device type specific value, > however the ret_value should not be greater than the onboard size of > the device implementation. E.g., for virtio_net, config_size should be > the minimum value of