Re: [PATCH 0/3] fixes for mlx5_vdpa multiqueue support

2022-01-12 Thread Michael S. Tsirkin
On Thu, Jan 13, 2022 at 12:10:48AM -0500, Si-Wei Liu wrote: > This patchset contains the fixes for a few issues uncovered during the > review for the "Allow for configuring max number of virtqueue pairs" > series. > > It is based on Eli's fixes: > 2e4cda633a22 ("vdpa/mlx5: Fix tracking of current

Re: [PATCH 3/3] vdpa/mlx5: validate the queue pair value from driver

2022-01-12 Thread Michael S. Tsirkin
On Thu, Jan 13, 2022 at 12:10:51AM -0500, Si-Wei Liu wrote: > Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support") > Signed-off-by: Si-Wei Liu Add motivation for change in the commit log. > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 ++ > 1 file changed, 10 insertions(+) > > dif

Re: [PATCH 2/3] vdpa/mlx5: set_features should nack MQ if no CTRL_VQ

2022-01-12 Thread Michael S. Tsirkin
On Thu, Jan 13, 2022 at 12:10:50AM -0500, Si-Wei Liu wrote: > Made corresponding change per spec: > The device MUST NOT offer a feature which requires another feature > which was not offered. Says nothing about the driver though, and you seem to be doing things to driver features? pls explain t

Re: [PATCH 1/3] vdpa: factor out vdpa_set_features_unlocked for vdpa internal use

2022-01-12 Thread Michael S. Tsirkin
On Thu, Jan 13, 2022 at 12:10:49AM -0500, Si-Wei Liu wrote: > No functional change introduced. vdpa bus driver such as virtio_vdpa > or vhost_vdpa is not supposed to take care of the locking for core > by its own. The locked API vdpa_set_features should suffice the > bus driver's need. > > Signed-

[PATCH 1/3] vdpa: factor out vdpa_set_features_unlocked for vdpa internal use

2022-01-12 Thread Si-Wei Liu
No functional change introduced. vdpa bus driver such as virtio_vdpa or vhost_vdpa is not supposed to take care of the locking for core by its own. The locked API vdpa_set_features should suffice the bus driver's need. Signed-off-by: Si-Wei Liu --- drivers/vdpa/vdpa.c | 2 +- drivers/vh

[PATCH 2/3] vdpa/mlx5: set_features should nack MQ if no CTRL_VQ

2022-01-12 Thread Si-Wei Liu
Made corresponding change per spec: The device MUST NOT offer a feature which requires another feature which was not offered. Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support") Signed-off-by: Si-Wei Liu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 16 +--- 1 file changed, 13 insert

[PATCH 3/3] vdpa/mlx5: validate the queue pair value from driver

2022-01-12 Thread Si-Wei Liu
Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support") Signed-off-by: Si-Wei Liu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 46d4deb..491127f 100644 --- a/drive

[PATCH 0/3] fixes for mlx5_vdpa multiqueue support

2022-01-12 Thread Si-Wei Liu
This patchset contains the fixes for a few issues uncovered during the review for the "Allow for configuring max number of virtqueue pairs" series. It is based on Eli's fixes: 2e4cda633a22 ("vdpa/mlx5: Fix tracking of current number of VQs") in the vhost tree. Si-Wei Liu (3): vdpa: factor out v

Re: [PATCH] virtio_vdpa: Support surprise removal of virtio vdpa device

2022-01-12 Thread Michael S. Tsirkin
On Wed, Jan 12, 2022 at 04:44:08PM +0800, ζŽδΈœε‡ wrote: > Indeed, there are hidden dangers for storage devices. > So maybe we can break the device before virtio_net unregister_netdev and > before > virtio_blk reset > > Unlike pci device, there is a manufacturer-driven existence between virtio > vd

Re: [PATCH] virtio_vdpa: Support surprise removal of virtio vdpa device

2022-01-12 Thread Michael S. Tsirkin
On Wed, Jan 12, 2022 at 03:52:52PM +0800, Jason Wang wrote: > On Wed, Jan 12, 2022 at 2:30 PM Michael S. Tsirkin wrote: > > > > On Wed, Jan 12, 2022 at 10:23:07AM +0800, Jason Wang wrote: > > > On Tue, Jan 11, 2022 at 7:52 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Jan 11, 2022 a

Re: [RFC PATCH v3 3/8] mm: migrate: allocate the right size of non hugetlb or THP compound pages.

2022-01-12 Thread David Hildenbrand
On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_migration_target() is used by alloc_contig_range() and non-LRU > movable compound pages can be migrated. Current code does not allocate the > right page size for such pages. Check THP precisely using > is_transparent_huge() and add allocat

Re: [RFC PATCH v3 2/8] mm: compaction: handle non-lru compound pages properly in isolate_migratepages_block().

2022-01-12 Thread David Hildenbrand
On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > In isolate_migratepages_block(), a !PageLRU tail page can be encountered > when the page is larger than a pageblock. Use compound head page for the > checks inside and skip the entire compound page when isolation succeeds. > This will currentl

Re: [RFC PATCH v3 1/8] mm: page_alloc: avoid merging non-fallbackable pageblocks with others.

2022-01-12 Thread David Hildenbrand
On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > This is done in addition to MIGRATE_ISOLATE pageblock merge avoidance. > It prepares for the upcoming removal of the MAX_ORDER-1 alignment > requirement for CMA and alloc_contig_range(). > > MIGRARTE_HIGHATOMIC should not merge with other migra