Re: futher decouple DAX from block devices

2021-11-04 Thread Matthew Wilcox
On Thu, Nov 04, 2021 at 11:09:19PM -0400, Theodore Ts'o wrote: > On Thu, Nov 04, 2021 at 12:04:43PM -0700, Darrick J. Wong wrote: > > > Note that I've avoided implementing read/write fops for dax devices > > > partly out of concern for not wanting to figure out shared-mmap vs > > > write coherence

Re: futher decouple DAX from block devices

2021-11-04 Thread Theodore Ts'o
On Thu, Nov 04, 2021 at 12:04:43PM -0700, Darrick J. Wong wrote: > > Note that I've avoided implementing read/write fops for dax devices > > partly out of concern for not wanting to figure out shared-mmap vs > > write coherence issues, but also because of a bet with Dave Hansen > > that device-dax

Re: [PATCH] vdpa: add driver_override support

2021-11-04 Thread Jason Wang
On Fri, Nov 5, 2021 at 12:17 AM Stefano Garzarella wrote: > > `driver_override` allows to control which of the vDPA bus drivers > binds to a vDPA device. > > If `driver_override` is not set, the previous behaviour is followed: > devices use the first vDPA bus driver loaded (unless auto binding > i

Re: [PATCH] vdpa: Avoid duplicate call to vp_vdpa get_status

2021-11-04 Thread Jason Wang
On Fri, Nov 5, 2021 at 3:58 AM Eugenio Pérez wrote: > > It has no sense to call get_status twice, since we already have a > variable for that. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang > --- > drivers/vhost/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --

Re: [PATCH] vdpa: Mark vdpa_config_ops.get_vq_notification as optional

2021-11-04 Thread Jason Wang
On Fri, Nov 5, 2021 at 3:53 AM Eugenio Pérez wrote: > > Since vhost_vdpa_mmap checks for its existence before calling it. > > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang > --- > include/linux/vdpa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/v

Re: Which tree for paravirt related patches?

2021-11-04 Thread Srivatsa S. Bhat
Hi Thomas, On 11/4/21 1:11 PM, Thomas Gleixner wrote: > Srivatsa, > > On Thu, Nov 04 2021 at 12:09, Srivatsa S. Bhat wrote: >> On a related note, I'll be stepping in soon to assist (in place of >> Deep) as a co-maintainer of the PARAVIRT_OPS interface. I had the same >> query about which tree wou

Re: Which tree for paravirt related patches?

2021-11-04 Thread Thomas Gleixner
Srivatsa, On Thu, Nov 04 2021 at 12:09, Srivatsa S. Bhat wrote: > On a related note, I'll be stepping in soon to assist (in place of > Deep) as a co-maintainer of the PARAVIRT_OPS interface. I had the same > query about which tree would be best for patches to the paravirt-ops > code, so I'm glad t

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-04 Thread Jani Nikula
On Thu, 04 Nov 2021, Javier Martinez Canillas wrote: > +/** > + * drm_drv_enabled - Checks if a DRM driver can be enabled > + * @driver: DRM driver to check > + * > + * Checks whether a DRM driver can be enabled or not. This may be the case > + * if the "nomodeset" kernel command line parameter is

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-04 Thread Jani Nikula
On Thu, 04 Nov 2021, Sam Ravnborg wrote: > Hi Javier, > >> >> >>> >> >>> -if (vgacon_text_force() && i915_modparams.modeset == -1) >> >>> +ret = drm_drv_enabled(&driver); >> >> >> >> You pass the local driver variable here - which looks wrong as this is >> >> not the same as the

Re: Which tree for paravirt related patches?

2021-11-04 Thread Srivatsa S. Bhat
Hi Juergen, Thomas, On 11/4/21 2:18 AM, Thomas Gleixner wrote: > On Thu, Nov 04 2021 at 10:17, Thomas Gleixner wrote: > > CC+ x86, peterz > >> Juergen, >> >> On Thu, Nov 04 2021 at 06:53, Juergen Gross wrote: >> >>> A recent patch modifying the core paravirt-ops functionality is >>> highlighting

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-04 Thread Sam Ravnborg
Hi Javier, > > >>> > >>> - if (vgacon_text_force() && i915_modparams.modeset == -1) > >>> + ret = drm_drv_enabled(&driver); > >> > >> You pass the local driver variable here - which looks wrong as this is > >> not the same as the driver variable declared in another file. > > > > Yes, Jani ment

[PATCH V4 12/12] vhost: allow worker attachment after initial setup

2021-11-04 Thread Mike Christie
This patch allows userspace to change the vq to worker mapping while it's in use so tools can do this setup post device creation if needed. Signed-off-by: Mike Christie --- drivers/vhost/vhost.c | 102 + drivers/vhost/vhost.h | 2 +- include/uapi/

[PATCH V4 11/12] vhost: allow userspace to create workers

2021-11-04 Thread Mike Christie
This patch allows userspace to create workers and bind them to vqs. You can have N workers per dev and also share N workers with M vqs. Signed-off-by: Mike Christie --- drivers/vhost/vhost.c| 149 --- drivers/vhost/vhost.h| 4 +- include/uapi

[PATCH V4 10/12] vhost: remove device wide queu/flushing helpers

2021-11-04 Thread Mike Christie
vhost_work_queue and vhost_work_dev_flush are no longer used, so drop them. Signed-off-by: Mike Christie --- drivers/vhost/vhost.c | 12 drivers/vhost/vhost.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index c84024afefff..04

[PATCH V4 09/12] vhost-scsi: flush IO vqs then send TMF rsp

2021-11-04 Thread Mike Christie
With one worker we will always send the scsi cmd responses then send the TMF rsp, because LIO will always complete the scsi cmds first then call into us to send the TMF response. With multiple workers, one of the IO vq threads could be run after the TMF is queued, so this has us flush the IO vqs t

[PATCH V4 07/12] vhost-scsi: make SCSI cmd completion per vq

2021-11-04 Thread Mike Christie
This patch separates the scsi cmd completion code paths so we can complete cmds based on their vq instead of having all cmds complete on the same worker/CPU. This will be useful with the next patches that allow us to create mulitple worker threads and bind them to different vqs, so we can have comp

[PATCH V4 06/12] vhost-sock: convert to vq helpers

2021-11-04 Thread Mike Christie
Convert from vhost dev based helpers to vq ones. Signed-off-by: Mike Christie --- drivers/vhost/vsock.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 938aefbc75ec..0c9681e120de 100644 --- a/drivers/vhost/vsock.c ++

[PATCH V4 04/12] vhost: take worker or vq instead of dev for flushing

2021-11-04 Thread Mike Christie
This patch has the core work flush function take a worker for when we support multiple workers. It also adds a helper that takes a vq during flushing so modules can control which vq/worker to flush. This temp leaves vhost_work_dev_flush. It will be removed when the drivers are converted in the nex

[PATCH V4 08/12] vhost-scsi: convert to vq helpers

2021-11-04 Thread Mike Christie
Convert from vhost dev based helpers to vq ones. Signed-off-by: Mike Christie --- drivers/vhost/scsi.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 0d85ddb68420..08beba73ada4 100644 --- a/drive

[PATCH V4 05/12] vhost: convert poll work to be vq based

2021-11-04 Thread Mike Christie
This has the drivers pass in their poll to vq mapping and then converts the core poll code to use the vq based helpers. Signed-off-by: Mike Christie --- drivers/vhost/net.c | 6 -- drivers/vhost/vhost.c | 10 ++ drivers/vhost/vhost.h | 4 +++- 3 files changed, 13 insertions(+), 7

[PATCH V4 00/12] vhost: multiple worker support

2021-11-04 Thread Mike Christie
The following patches apply over linus's tree and this patchset https://lore.kernel.org/all/20211007214448.6282-1-michael.chris...@oracle.com/ which allows us to check the vhost owner thread's RLIMITs. The patches allow us to support multiple vhost workers per device. The design is a modified ve

[PATCH V4 02/12] vhost, vhost-net: add helper to check if vq has work

2021-11-04 Thread Mike Christie
This adds a helper to check if a vq has work pending and converts vhost-net to use it. Signed-off-by: Mike Christie --- drivers/vhost/net.c | 2 +- drivers/vhost/vhost.c | 6 +++--- drivers/vhost/vhost.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/net.c

[PATCH V4 01/12] vhost: add vhost_worker pointer to vhost_virtqueue

2021-11-04 Thread Mike Christie
This patchset allows userspace to map vqs to different workers. This patch adds a worker pointer to the vq so we can store that info. Signed-off-by: Mike Christie --- drivers/vhost/vhost.c | 24 +--- drivers/vhost/vhost.h | 1 + 2 files changed, 14 insertions(+), 11 deletion

[PATCH V4 03/12] vhost: take worker or vq instead of dev for queueing

2021-11-04 Thread Mike Christie
This patch has the core work queueing function take a worker for when we support multiple workers. It also adds a helper that takes a vq during queueing so modules can control which vq/worker to queue work on. This temp leaves vhost_work_queue. It will be removed when the drivers are converted in

Re: futher decouple DAX from block devices

2021-11-04 Thread Dan Williams
On Thu, Nov 4, 2021 at 10:36 AM Christoph Hellwig wrote: > > On Thu, Nov 04, 2021 at 10:34:17AM -0700, Darrick J. Wong wrote: > > /me wonders, are block devices going away? Will mkfs.xfs have to learn > > how to talk to certain chardevs? I guess jffs2 and others already do > > that kind of thing

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-04 Thread Jani Nikula
On Thu, 04 Nov 2021, Sam Ravnborg wrote: > Hi Javier, > > On Thu, Nov 04, 2021 at 05:07:06PM +0100, Javier Martinez Canillas wrote: >> Some DRM drivers check the vgacon_text_force() function return value as an >> indication on whether they should be allowed to be enabled or not. >> >> This functi

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-04 Thread Sam Ravnborg
Hi Javier, On Thu, Nov 04, 2021 at 05:07:06PM +0100, Javier Martinez Canillas wrote: > Some DRM drivers check the vgacon_text_force() function return value as an > indication on whether they should be allowed to be enabled or not. > > This function returns true if the nomodeset kernel command lin

Re: futher decouple DAX from block devices

2021-11-04 Thread Christoph Hellwig
On Thu, Nov 04, 2021 at 10:34:17AM -0700, Darrick J. Wong wrote: > /me wonders, are block devices going away? Will mkfs.xfs have to learn > how to talk to certain chardevs? I guess jffs2 and others already do > that kind of thing... but I suppose I can wait for the real draft to > show up to ramb

Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

2021-11-04 Thread Jani Nikula
On Thu, 04 Nov 2021, Javier Martinez Canillas wrote: > Some DRM drivers check the vgacon_text_force() function return value as an > indication on whether they should be allowed to be enabled or not. > > This function returns true if the nomodeset kernel command line parameter > was set. But there

[PATCH] vdpa: add driver_override support

2021-11-04 Thread Stefano Garzarella
`driver_override` allows to control which of the vDPA bus drivers binds to a vDPA device. If `driver_override` is not set, the previous behaviour is followed: devices use the first vDPA bus driver loaded (unless auto binding is disabled). Tested on Fedora 34 with driverctl(8): $ modprobe virtio

Re: [PATCH] drm/virtio: delay pinning the pages till first use

2021-11-04 Thread kernel test robot
Hi Maksym, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on next-20211104] [cannot apply to v5.15] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: Which tree for paravirt related patches?

2021-11-04 Thread Thomas Gleixner
On Thu, Nov 04 2021 at 10:17, Thomas Gleixner wrote: CC+ x86, peterz > Juergen, > > On Thu, Nov 04 2021 at 06:53, Juergen Gross wrote: > >> A recent patch modifying the core paravirt-ops functionality is >> highlighting some missing MAINTAINERS information for PARAVIRT_OPS: >> there is no informa

Re: Which tree for paravirt related patches?

2021-11-04 Thread Thomas Gleixner
Juergen, On Thu, Nov 04 2021 at 06:53, Juergen Gross wrote: > A recent patch modifying the core paravirt-ops functionality is > highlighting some missing MAINTAINERS information for PARAVIRT_OPS: > there is no information which tree is to be used for taking those > patches per default. In the pas

Re: futher decouple DAX from block devices

2021-11-04 Thread Christoph Hellwig
On Wed, Nov 03, 2021 at 12:59:31PM -0500, Eric Sandeen wrote: > Christoph, can I ask what the end game looks like, here? If dax is completely > decoupled from block devices, are there user-visible changes? Yes. > If I want to > run fs-dax on a pmem device - what do I point mkfs at, if not a block