Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver

2021-09-07 Thread Jie Deng
On 2021/9/6 12:43, Viresh Kumar wrote: Let's let the dust settle on them then, then resubmit? It doesn't break anything for now since we don't have much users and we know zero length transfers don't work. I will submit the necessary changes once spec is finalized. Agree. The currently merg

Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter

2021-09-07 Thread Leon Romanovsky
On Sun, Sep 05, 2021 at 11:15:16AM -0400, Michael S. Tsirkin wrote: > On Sun, Sep 05, 2021 at 01:20:24PM +0300, Leon Romanovsky wrote: > > On Sun, Sep 05, 2021 at 01:49:46AM -0700, Chaitanya Kulkarni wrote: > > > > > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > > > +static unsigned int num

Re: [PATCH 2/2] virtiofs: reduce lock contention on fpq->lock

2021-09-07 Thread Vivek Goyal
On Tue, Sep 07, 2021 at 10:57:07AM +0200, Miklos Szeredi wrote: > On Thu, 12 Aug 2021 at 07:46, Jeffle Xu wrote: > > > > From: Liu Bo > > > > Since %req has been removed from fpq->processing_list, no one except > > request_wait_answer() is looking at this %req and request_wait_answer() > > waits

Re: [PATCH] vdpa: potential uninitialized return in vhost_vdpa_va_map()

2021-09-07 Thread Stefano Garzarella
On Tue, Sep 07, 2021 at 10:32:53AM +0300, Dan Carpenter wrote: The concern here is that "ret" can be uninitialized if we hit the "goto next" condition on every iteration through the loop. Fixes: 41ba1b5f9d4b ("vdpa: Support transferring virtual addressing during DMA mapping") Signed-off-by: Dan

Re: [PATCH] vdpa: potential uninitialized return in vhost_vdpa_va_map()

2021-09-07 Thread Jason Wang
On Tue, Sep 7, 2021 at 3:33 PM Dan Carpenter wrote: > > The concern here is that "ret" can be uninitialized if we hit the > "goto next" condition on every iteration through the loop. > > Fixes: 41ba1b5f9d4b ("vdpa: Support transferring virtual addressing during > DMA mapping") > Signed-off-by: Da

Re: [PATCH] vduse: missing error code in vduse_init()

2021-09-07 Thread Jason Wang
On Tue, Sep 7, 2021 at 3:32 PM Dan Carpenter wrote: > > This should return -ENOMEM if alloc_workqueue() fails. Currently it > returns success. > > Fixes: b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace") > Signed-off-by: Dan Carpenter > --- > drivers/vdpa/vdpa_user/vduse_dev.c

[PATCH] vdpa: potential uninitialized return in vhost_vdpa_va_map()

2021-09-07 Thread Dan Carpenter
The concern here is that "ret" can be uninitialized if we hit the "goto next" condition on every iteration through the loop. Fixes: 41ba1b5f9d4b ("vdpa: Support transferring virtual addressing during DMA mapping") Signed-off-by: Dan Carpenter --- drivers/vhost/vdpa.c | 2 +- 1 file changed, 1 i

[PATCH] vduse: missing error code in vduse_init()

2021-09-07 Thread Dan Carpenter
This should return -ENOMEM if alloc_workqueue() fails. Currently it returns success. Fixes: b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace") Signed-off-by: Dan Carpenter --- drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] MAINTAINERS: add VM SOCKETS (AF_VSOCK) entry

2021-09-07 Thread Stefano Garzarella
On Mon, Sep 06, 2021 at 07:10:46PM +, Dexuan Cui wrote: From: Stefano Garzarella Sent: Monday, September 6, 2021 2:12 AM Add a new entry for VM Sockets (AF_VSOCK) that covers vsock core, tests, and headers. Move some general vsock stuff from virtio-vsock entry into this new more general vso

Re: [PATCH] MAINTAINERS: add VM SOCKETS (AF_VSOCK) entry

2021-09-07 Thread Stefano Garzarella
On Mon, Sep 06, 2021 at 02:50:59PM +, Jorgen Hansen wrote: On 6 Sep 2021, at 11:11, Stefano Garzarella wrote: Add a new entry for VM Sockets (AF_VSOCK) that covers vsock core, tests, and headers. Move some general vsock stuff from virtio-vsock entry into this new more general vsock entry

Re: [PATCH] MAINTAINERS: add VM SOCKETS (AF_VSOCK) entry

2021-09-07 Thread Stefano Garzarella
On Mon, Sep 06, 2021 at 02:24:34PM +0100, Stefan Hajnoczi wrote: On Mon, Sep 06, 2021 at 11:11:59AM +0200, Stefano Garzarella wrote: Add a new entry for VM Sockets (AF_VSOCK) that covers vsock core, tests, and headers. Move some general vsock stuff from virtio-vsock entry into this new more gene