RE: [PATCH 4/4] virtio_pci: Support surprise removal of virtio pci device

2021-07-18 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Sunday, July 18, 2021 2:17 AM > > On Sat, Jul 17, 2021 at 10:42:58AM +0300, Parav Pandit wrote: > > When a virtio pci device undergo surprise removal (aka async removaln > > in > > typo Fixing it. Checkpatch.pl and codespell, both didn't catch it. 😊 > > OK

RE: [PATCH 3/4] virtio: Protect vqs list access

2021-07-18 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Sunday, July 18, 2021 2:11 AM > > On Sat, Jul 17, 2021 at 10:42:57AM +0300, Parav Pandit wrote: > > VQs may be accessed to mark the device broken while they are > > created/destroyed. Hence protect the access to the vqs list. > > > > Fixes: e2dcdfe95c0b ("virt

RE: [PATCH 1/4] virtio: Improve vq->broken access to avoid any compiler optimization

2021-07-18 Thread Parav Pandit via Virtualization
> From: Michael S. Tsirkin > Sent: Sunday, July 18, 2021 2:09 AM > > On Sat, Jul 17, 2021 at 10:42:55AM +0300, Parav Pandit wrote: > > Currently vq->broken field is read by virtqueue_is_broken() in busy > > loop in one context by virtnet_send_command(). > > > > vq->broken is set to true in oth

RE: [PATCH 1/2] virtio_ring: fix error - unknown type name 'spinlock_t'

2021-07-18 Thread Cai,Huoqing
Is it a error, try “make virtio” in the path of linux/tools/ with config VHOST_IOTLB=n -Original Message- From: Cai,Huoqing Sent: 2021年7月14日 10:29 To: sgarz...@redhat.com; m...@redhat.com; jasow...@redhat.com Cc: virtualization@lists.linux-foundation.org; linux-ker...@vger.kernel.org;

Re: [Question] virtio-net: About napi_tx

2021-07-18 Thread lma
在 2021-07-13 07:52,Willem de Bruijn 写道: On Tue, Jul 13, 2021 at 3:04 AM lma wrote: Hi Willem and list, The napi_tx of virtio_net is enabled by default by commit 31c03aef. and the commit message mentioned: In the unlikely case of regression, we have landed a credible runtime solutio

Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper

2021-07-18 Thread Jason Wang
在 2021/7/16 下午8:46, tianxianting 写道: Do you interest in this patch? just little improvment:) 在 2021/7/13 下午11:38, Xianting Tian 写道: From: Xianting Tian Use the helper virtio_find_vqs(). Signed-off-by: Xianting Tian ---   drivers/virtio/virtio_balloon.c | 4 ++--   1 file changed, 2 insertio

Re: [PATCH 2/2] vhost: Fix the calculation in vhost_overflow()

2021-07-18 Thread Jason Wang
在 2021/7/16 下午6:22, Xie Yongji 写道: This fixes the incorrect calculation for integer overflow when the last address of iova range is 0x. Fixes: ec33d031a14b ("vhost: detect 32 bit integer wrap around“) Reported-by: Jason Wang Signed-off-by: Xie Yongji --- drivers/vhost/vhost.c | 3 ++

Re: [PATCH 1/2] vhost-vdpa: Fix integer overflow in vhost_vdpa_process_iotlb_update()

2021-07-18 Thread Jason Wang
在 2021/7/16 下午6:22, Xie Yongji 写道: The "msg->iova + msg->size" addition can have an integer overflow if the iotlb message is from a malicious user space application. So let's fix it. Fixes: 1b48dc03e575 ("vhost: vdpa: report iova range") Reported-by: Dan Carpenter Signed-off-by: Xie Yongji

Re: [PATCH] vhost_net: Convert from atomic_t to refcount_t on vhost_net_ubuf_ref->refcount

2021-07-18 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiyu-Yang/vhost_net-Convert-from-atomic_t-to-refcount_t-on-vhost_net_ubuf_ref-refcount/20210718-101502 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-n

Re: [PATCH] vhost_net: Convert from atomic_t to refcount_t on vhost_net_ubuf_ref->refcount

2021-07-18 Thread kernel test robot
e' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiyu-Yang/vhost_net-Convert-from-atomic_t-to-refcount_t-on-vhost_net_ubuf_ref-refcount/20210718-101502 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next co

Re: [PATCH mlx5-next] IB/mlx5: Rename is_apu_thread_cq function to is_apu_cq

2021-07-18 Thread Michael S. Tsirkin
On Sun, Jul 18, 2021 at 02:54:13PM +0300, Leon Romanovsky wrote: > From: Tal Gilboa > > is_apu_thread_cq() used to detect CQs which are attached to APU > threads. This was extended to support other elements as well, > so the function was renamed to is_apu_cq(). > > c_eqn_or_apu_element was exten

[PATCH mlx5-next] IB/mlx5: Rename is_apu_thread_cq function to is_apu_cq

2021-07-18 Thread Leon Romanovsky
From: Tal Gilboa is_apu_thread_cq() used to detect CQs which are attached to APU threads. This was extended to support other elements as well, so the function was renamed to is_apu_cq(). c_eqn_or_apu_element was extended from 8 bits to 32 bits, which wan't reflected when the APU support was firs