Re: virtio-net: kernel panic in virtio_net.c

2021-06-08 Thread Greg KH
On Wed, Jun 09, 2021 at 02:08:17PM +0800, Xuan Zhuo wrote: > On Wed, 9 Jun 2021 06:50:10 +0200, Greg KH wrote: > > On Wed, Jun 09, 2021 at 09:48:33AM +0800, Xuan Zhuo wrote: > > > > > With this patch and the latest net branch I no longer get crashes. > > > > > > > > Did this ever get properly subm

Re: virtio-net: kernel panic in virtio_net.c

2021-06-08 Thread Xuan Zhuo
On Wed, 9 Jun 2021 06:50:10 +0200, Greg KH wrote: > On Wed, Jun 09, 2021 at 09:48:33AM +0800, Xuan Zhuo wrote: > > > > With this patch and the latest net branch I no longer get crashes. > > > > > > Did this ever get properly submitted to the networking tree to get into > > > 5.13-final? > > > > Th

Re: virtio-net: kernel panic in virtio_net.c

2021-06-08 Thread Greg KH
On Wed, Jun 09, 2021 at 09:48:33AM +0800, Xuan Zhuo wrote: > > > With this patch and the latest net branch I no longer get crashes. > > > > Did this ever get properly submitted to the networking tree to get into > > 5.13-final? > > The patch has been submitted. > > [PATCH net] virtio-net: f

Re: Re: [RFC v2] virtio-vsock: add description for datagram type

2021-06-08 Thread Jiang Wang .
On Tue, May 18, 2021 at 9:59 PM Jiang Wang . wrote: > > On Tue, May 18, 2021 at 6:02 AM Stefano Garzarella > wrote: > > > > On Mon, May 17, 2021 at 11:33:06PM -0700, Jiang Wang . wrote: > > >On Mon, May 17, 2021 at 4:02 AM Stefano Garzarella > > >wrote: > > >> > > >> On Fri, May 14, 2021 at 11

Re: [External] Re: [RFC v4] virtio-vsock: add description for datagram type

2021-06-08 Thread Jiang Wang .
On Tue, Jun 8, 2021 at 6:46 AM Stefano Garzarella wrote: > > On Fri, May 28, 2021 at 04:01:18AM +, Jiang Wang wrote: > >From: "jiang.wang" > > > >Add supports for datagram type for virtio-vsock. Datagram > >sockets are connectionless and unreliable. To avoid contention > >with stream and othe

Re: virtio-net: kernel panic in virtio_net.c

2021-06-08 Thread Xuan Zhuo
On Tue, 8 Jun 2021 14:17:58 +0200, Greg KH wrote: > On Thu, Jun 03, 2021 at 10:57:52AM +0200, Corentin Noël wrote: > > Le jeudi 03 juin 2021 à 10:44 +0800, Xuan Zhuo a écrit : > > > On Wed, 02 Jun 2021 19:54:41 +0200, Corentin Noël < > > > corentin.n...@collabora.com> wrote: > > > > Sure, here is

Re: [PATCH] dt-bindings: virtio: Convert virtio-mmio to DT schema

2021-06-08 Thread Rob Herring
On Mon, Jun 7, 2021 at 2:39 PM Rob Herring wrote: > > Convert the virtio-mmio binding to DT schema format. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Jean-Philippe Brucker > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Rob Herring > --- > Jean-Philippe, hopefully you

Re: [PATCH 0/7] Do not read from descriptor ring

2021-06-08 Thread Andy Lutomirski
On 6/3/21 10:53 PM, Jason Wang wrote: > Hi: > > The virtio driver should not trust the device. This beame more urgent > for the case of encrtpyed VM or VDUSE[1]. In both cases, technology > like swiotlb/IOMMU is used to prevent the poking/mangling of memory > from the device. But this is not suffi

[PATCH] drm: qxl: ensure surf.data is ininitialized

2021-06-08 Thread Colin King
From: Colin Ian King The object surf is not fully initialized and the uninitialized field surf.data is being copied by the call to qxl_bo_create via the call to qxl_gem_object_create. Set surf.data to zero to ensure garbage data from the stack is not being copied. Addresses-Coverity: ("Uninitial

Re: [RFC v4] virtio-vsock: add description for datagram type

2021-06-08 Thread Stefano Garzarella
On Fri, May 28, 2021 at 04:01:18AM +, Jiang Wang wrote: From: "jiang.wang" Add supports for datagram type for virtio-vsock. Datagram sockets are connectionless and unreliable. To avoid contention with stream and other sockets, add two more virtqueues and a new feature bit to identify if tho

Re: [PATCH v3 4/7] x86/sev-es: Run #VC handler in plain IRQ state

2021-06-08 Thread Joerg Roedel
Hi Peter, On Tue, Jun 08, 2021 at 01:58:47PM +0200, Peter Zijlstra wrote: > So #VC cannot happen with IRQs disabled? > > raw_spin_lock_irq(&my_lock); > <#VC> > raw_spin_lock_irqsave(&my_lock); // whoopsie > > Every exception that can happen with IRQs disabled must be NM

Re: [PATCH v1 09/12] ACPI: memhotplug: use a single static memory group for a single memory device

2021-06-08 Thread Rafael J. Wysocki
On Mon, Jun 7, 2021 at 9:55 PM David Hildenbrand wrote: > > Let's group all memory we add for a single memory device - we want a > single node for that (which also seems to be the sane thing to do). > > We won't care for now about memory that was already added to the system > (e.g., via e820) -- u

Re: [PATCH v1 08/12] ACPI: memhotplug: memory resources cannot be enabled yet

2021-06-08 Thread Rafael J. Wysocki
On Mon, Jun 7, 2021 at 9:55 PM David Hildenbrand wrote: > > We allocate + initialize everything from scratch. In case enabling the > device fails, we free all memory resourcs. > > Signed-off-by: David Hildenbrand Acked-by: Rafael J. Wysocki > --- > drivers/acpi/acpi_memhotplug.c | 4 > 1

Re: virtio-net: kernel panic in virtio_net.c

2021-06-08 Thread Greg KH
On Thu, Jun 03, 2021 at 10:57:52AM +0200, Corentin Noël wrote: > Le jeudi 03 juin 2021 à 10:44 +0800, Xuan Zhuo a écrit : > > On Wed, 02 Jun 2021 19:54:41 +0200, Corentin Noël < > > corentin.n...@collabora.com> wrote: > > > Sure, here is the decoded trace: > > > > > > [ 44.523231] skbuff: skb_ov

Re: [PATCH v3 4/7] x86/sev-es: Run #VC handler in plain IRQ state

2021-06-08 Thread Peter Zijlstra
On Tue, Jun 08, 2021 at 11:54:36AM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Use irqentry_enter() and irqentry_exit() to track the runtime state of > the #VC handler. The reason it ran in NMI mode was solely to make sure > nothing interrupts the handler while the GHCB is in use. > > Th

Re: [PATCH v1 05/12] mm/memory_hotplug: remove nid parameter from remove_memory() and friends

2021-06-08 Thread David Hildenbrand
On 08.06.21 13:11, Michael Ellerman wrote: David Hildenbrand writes: There is only a single user remaining. We can simply try to offline all online nodes - which is fast, because we usually span pages and can skip such nodes right away. That makes me slightly nervous, because our big powerpc

Re: [PATCH v1 05/12] mm/memory_hotplug: remove nid parameter from remove_memory() and friends

2021-06-08 Thread Michael Ellerman
David Hildenbrand writes: > There is only a single user remaining. We can simply try to offline all > online nodes - which is fast, because we usually span pages and can skip > such nodes right away. That makes me slightly nervous, because our big powerpc boxes tend to trip on these scaling issue

Re: [PATCH v1 04/12] mm/memory_hotplug: remove nid parameter from arch_remove_memory()

2021-06-08 Thread Michael Ellerman
David Hildenbrand writes: > The parameter is unused, let's remove it. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: Yoshinori Sato > Cc: Rich Fe

Re: [PATCH v10 11/18] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-06-08 Thread Stefano Garzarella
On Tue, Jun 08, 2021 at 01:24:58PM +0300, Arseny Krasnov wrote: On 08.06.2021 13:19, Stefano Garzarella wrote: On Tue, Jun 08, 2021 at 12:40:39PM +0300, Arseny Krasnov wrote: On 08.06.2021 11:23, Stefano Garzarella wrote: On Mon, Jun 07, 2021 at 04:18:38PM +0300, Arseny Krasnov wrote: On 07.

Re: [PATCH v10 11/18] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-06-08 Thread Stefano Garzarella
On Tue, Jun 08, 2021 at 12:40:39PM +0300, Arseny Krasnov wrote: On 08.06.2021 11:23, Stefano Garzarella wrote: On Mon, Jun 07, 2021 at 04:18:38PM +0300, Arseny Krasnov wrote: On 07.06.2021 14:04, Stefano Garzarella wrote: On Fri, Jun 04, 2021 at 09:03:26PM +0300, Arseny Krasnov wrote: On 04.

Re: [PATCH v1 00/12] mm/memory_hotplug: "auto-movable" online policy and memory groups

2021-06-08 Thread David Hildenbrand
On 08.06.21 11:42, Oscar Salvador wrote: On Mon, Jun 07, 2021 at 09:54:18PM +0200, David Hildenbrand wrote: Hi, this series aims at improving in-kernel auto-online support. It tackles the fundamental problems that: Hi David, the idea sounds good to me, and I like that this series takes away

[PATCH v3 7/7] x86/sev-es: Propagate #GP if getting linear instruction address failed

2021-06-08 Thread Joerg Roedel
From: Joerg Roedel When an instruction is fetched from user-space, segmentation needs to be taken into account. This means that getting the linear address of an instruction can fail. Hardware would raise a #GP exception in that case, but the #VC exception handler would emulate it as a page-fault.

[PATCH v3 0/7] x86/sev-es: Fixes for SEV-ES Guest Support

2021-06-08 Thread Joerg Roedel
From: Joerg Roedel Hi, here is the next revision of my pending fixes for SEV-ES guest support. Changes to the previous version are: - Removed the patches already merged - Added a new fix to map the EFI MOKVar table encrypted - Disabled IRQs when GHCB is active -

[PATCH v3 6/7] x86/insn: Extend error reporting from insn_fetch_from_user[_inatomic]()

2021-06-08 Thread Joerg Roedel
From: Joerg Roedel The error reporting from the insn_fetch_from_user*() functions is not very verbose. Extend it to include information on whether the linear RIP could not be calculated or whether the memory access faulted. This will be used in the SEV-ES code to propagate the correct exception

[PATCH v3 3/7] x86/sev-es: Disable IRQs while GHCB is active

2021-06-08 Thread Joerg Roedel
From: Joerg Roedel The #VC handler only cares about IRQs being disabled while the GHCB is active, as it must not be interrupted by something which could cause another #VC while it holds the GHCB (NMI is the exception for which the backup GHCB is there). Make sure nothing interrupts the code path

[PATCH v3 2/7] x86/sev-es: Fix error message in runtime #VC handler

2021-06-08 Thread Joerg Roedel
From: Joerg Roedel The runtime #VC handler is not "early" anymore. Fix the copy&paste error and remove that word from the error message. Signed-off-by: Joerg Roedel --- arch/x86/kernel/sev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/sev.c b/arch/x86/ke

[PATCH v3 5/7] x86/insn-eval: Make 0 a valid RIP for insn_get_effective_ip()

2021-06-08 Thread Joerg Roedel
From: Joerg Roedel In theory 0 is a valid value for the instruction pointer, so don't use it as the error return value from insn_get_effective_ip(). Signed-off-by: Joerg Roedel --- arch/x86/lib/insn-eval.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/

[PATCH v3 4/7] x86/sev-es: Run #VC handler in plain IRQ state

2021-06-08 Thread Joerg Roedel
From: Joerg Roedel Use irqentry_enter() and irqentry_exit() to track the runtime state of the #VC handler. The reason it ran in NMI mode was solely to make sure nothing interrupts the handler while the GHCB is in use. This is handled now in sev_es_get/put_ghcb() directly, so there is no reason t

[PATCH v3 1/7] x86/ioremap: Map efi_mem_reserve() memory as encrypted for SEV

2021-06-08 Thread Joerg Roedel
From: Tom Lendacky Some drivers require memory that is marked as EFI boot services data. So that this memory is not re-used by the kernel after ExitBootServices(), efi_mem_reserve() is used to preserve it by inserting a new EFI memory descriptor and marking it with the EFI_MEMORY_RUNTIME attribut

Re: [PATCH net-next] virtio-net: Refactor the code related to page_to_skb()

2021-06-08 Thread Xuan Zhuo
On Mon, 31 May 2021 14:24:00 +0800, Jason Wang wrote: > > 在 2021/5/19 下午5:00, Xuan Zhuo 写道: > > Due to long-term development, the current code structure of > > page_to_skb() and the semantic expression of variables are rather > > chaotic, so it is necessary to reconstruct this piece of logic. > >

Re: [PATCH v1 04/12] mm/memory_hotplug: remove nid parameter from arch_remove_memory()

2021-06-08 Thread Catalin Marinas
On Mon, Jun 07, 2021 at 09:54:22PM +0200, David Hildenbrand wrote: > The parameter is unused, let's remove it. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntrae

Re: [PATCH v10 11/18] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-06-08 Thread Stefano Garzarella
On Mon, Jun 07, 2021 at 04:18:38PM +0300, Arseny Krasnov wrote: On 07.06.2021 14:04, Stefano Garzarella wrote: On Fri, Jun 04, 2021 at 09:03:26PM +0300, Arseny Krasnov wrote: On 04.06.2021 18:03, Stefano Garzarella wrote: On Fri, Jun 04, 2021 at 04:12:23PM +0300, Arseny Krasnov wrote: On 03.

Re: [PATCH] dt-bindings: virtio: Convert virtio-mmio to DT schema

2021-06-08 Thread Jean-Philippe Brucker
On Mon, Jun 07, 2021 at 02:39:28PM -0500, Rob Herring wrote: > Convert the virtio-mmio binding to DT schema format. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Jean-Philippe Brucker > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Rob Herring > --- > Jean-Philippe, hope