[PATCH 29/30] ataflop: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/ataflop.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c in

[PATCH 30/30] z2ram: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/z2ram.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index c1d

[PATCH 28/30] amiflop: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/amiflop.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c in

[PATCH 27/30] scm_blk: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/s390/block/scm_blk.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/s390/block/scm_blk.c b/drivers/s39

[PATCH 26/30] ubi: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/mtd/ubi/block.c | 68 ++--- 1 file changed, 29 insertions(+), 39 deletions(-) diff --git a/drivers/mtd/ubi/block.c b/

[PATCH 25/30] xen-blkfront: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/xen-blkfront.c | 96 +++- 1 file changed, 39 insertions(+), 57 deletions(-) diff --git a/drivers/block/xen-blkfront

[PATCH 24/30] sx8: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/sx8.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c index 2

[PATCH 23/30] rnbd: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/rnbd/rnbd-clt.c | 35 --- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git a/drivers/block/rnbd/rnbd-clt

[PATCH 22/30] rbd: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/rbd.c | 52 - 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/block/rbd.c b/driv

[PATCH 21/30] pd: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pd.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/block/paride/pd.c b/drivers

[PATCH 20/30] nullb: use blk_mq_alloc_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/null_blk/main.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_b

[PATCH 19/30] nbd: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/nbd.c | 53 ++--- 1 file changed, 21 insertions(+), 32 deletions(-) diff --git a/drivers/block/nbd.c b/driv

[PATCH 18/30] loop: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 95

[PATCH 17/30] floppy: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/floppy.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c i

[PATCH 16/30] aoe: use blk_mq_alloc_disk and blk_cleanup_disk

Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/aoe/aoeblk.c | 33 - drivers/block/aoe/aoedev.c | 3 +-- 2 files changed, 13 insertions(+), 23 deletions(-) diff -

[PATCH 15/30] blk-mq: remove blk_mq_init_sq_queue

All users are gone now. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 22 -- include/linux/blk-mq.h | 4 2 files changed, 26 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 1e6036e6fd66..25e25177c2b1 100644 --- a/block/blk-mq.c +++ b/blo

[PATCH 14/30] gdrom: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/cdrom/gdrom.c | 45 --- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/g

[PATCH 13/30] sunvdc: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/sunvdc.c | 47 -- 1 file changed, 13 insertions(+), 34 deletions(-) diff --git a/drivers/block/sunvdc.c b/drivers/block/

[PATCH 12/30] swim: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/swim.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c index

[PATCH 11/30] swim3: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/swim3.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c ind

[PATCH 10/30] ps3disk: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/ps3disk.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3d

[PATCH 09/30] mtd_blkdevs: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/mtd/mtd_blkdevs.c | 48 ++- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd

[PATCH 08/30] mspro: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/memstick/core/mspro_block.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/dri

[PATCH 07/30] ms_block: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/memstick/core/ms_block.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/memstick/core/ms_block.c b/drivers/mem

[PATCH 06/30] pf: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pf.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c index b

[PATCH 04/30] virtio-blk: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/virtio_blk.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_bl

[PATCH 05/30] pcd: use blk_mq_alloc_disk

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue allocation. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pcd.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c ind

[PATCH 03/30] blk-mq: add the blk_mq_alloc_disk APIs

Add a new API to allocate a gendisk including the request_queue for use with blk-mq based drivers. This is to avoid boilerplate code in drivers. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 19 +++ include/linux/blk-mq.h | 12 2 files changed, 31 in

simplify gendisk and request_queue allocation for blk-mq based drivers

Hi all, this series is the scond part of cleaning up lifetimes and allocation of the gendisk and request_queue structure. It adds a new interface to allocate the disk and queue together for blk based drivers, and uses that in all drivers that do not have any caveats in their gendisk and request_q

[PATCH 02/30] blk-mq: improve the blk_mq_init_allocated_queue interface

Don't return the passed in request_queue but a normal error code, and drop the elevator_init argument in favor of just calling elevator_init_mq directly from dm-rq. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 36 ++-- block/blk.h |

[PATCH 01/30] blk-mq: factor out a blk_mq_alloc_sq_tag_set helper

Factour out a helper to initialize a simple single hw queue tag_set from blk_mq_init_sq_queue. This will allow to phase out blk_mq_init_sq_queue in favor of a more symmetric and general API. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 32 ++-- inclu

Re: [PATCH] virtio_net: Remove BUG() to aviod machine dead

On Tue, May 25, 2021 at 02:19:03PM +0800, Jason Wang wrote: > > 在 2021/5/19 下午10:18, Xianting Tian 写道: > > thanks, I submit the patch as commented by Andrew > > https://lkml.org/lkml/2021/5/18/256 > > > > Actually, if xmit_skb() returns error, below code will give a warning > > with error code. >

Re: [PATCH] virtio-net: fix the kzalloc/kfree mismatch problem

On Mon, May 24, 2021 at 10:37:14AM +0800, Jason Wang wrote: > > 在 2021/5/24 上午10:06, Xuan Zhuo 写道: > > On Mon, 24 May 2021 01:48:53 +, Guodeqing (A) > > wrote: > > > > > > > -Original Message- > > > > From: Max Gurtovoy [mailto:mgurto...@nvidia.com] > > > > Sent: Sunday, May 23, 202

[PATCH V2 RESEND 4/4] virtio/vdpa: clear the virtqueue state during probe

From: Eli Cohen Clear the available index as part of the initialization process to clear and values that might be left from previous usage of the device. For example, if the device was previously used by vhost_vdpa and now probed by vhost_vdpa, you want to start with indices. Fixes: c043b4a8cf3b

[PATCH V2 RESEND 3/4] vp_vdpa: allow set vq state to initial state after reset

We used to fail the set_vq_state() since it was not supported yet by the virtio spec. But if the bus tries to set the state which is equal to the device initial state after reset, we can let it go. This is a must for virtio_vdpa() to set vq state during probe which is required for some vDPA parent

[PATCH V2 RESEND 2/4] virtio-pci library: introduce vp_modern_get_driver_features()

This patch introduce a helper to get driver/guest features from the device. Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_modern_dev.c | 21 + include/linux/virtio_pci_modern.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/virtio/virtio_pci_mo

[PATCH V2 RESEND 1/4] vdpa: support packed virtqueue for set/get_vq_state()

This patch extends the vdpa_vq_state to support packed virtqueue state which is basically the device/driver ring wrap counters and the avail and used index. This will be used for the virito-vdpa support for the packed virtqueue and the future vhost/vhost-vdpa support for the packed virtqueue. Sign

[PATCH V2 RESEND 0/4] Packed virtqueue state support for vDPA

Hi: This series implements the packed virtqueue state support for vDPA. This is done via extending the vdpa_vq_state to support packed virtqueue. For virtio-vDPA, an initial state required by the virtio spec is set. For vhost-vDPA, the packed virtqueue support still needs to be done at both vhos

Re: [PATCH V2 0/4]

在 2021/6/2 上午10:10, Jason Wang 写道: *** BLURB HERE *** Missing blurb... Will resend a new version. Thanks Eli Cohen (1): virtio/vdpa: clear the virtqueue state during probe Jason Wang (3): vdpa: support packed virtqueue for set/get_vq_state() virtio-pci library: introduce vp_mo

Re: [PATCH 1/4] vdpa: support packed virtqueue for set/get_vq_state()

在 2021/6/1 下午6:47, Eli Cohen 写道: On Tue, Jun 01, 2021 at 04:45:00PM +0800, Jason Wang wrote: This patch extends the vdpa_vq_state to support packed virtqueue state which is basically the device/driver ring wrap counters and the avail and used index. This will be used for the virito-vdpa support

[PATCH V2 4/4] virtio/vdpa: clear the virtqueue state during probe

From: Eli Cohen Clear the available index as part of the initialization process to clear and values that might be left from previous usage of the device. For example, if the device was previously used by vhost_vdpa and now probed by vhost_vdpa, you want to start with indices. Fixes: c043b4a8cf3b

[PATCH V2 3/4] vp_vdpa: allow set vq state to initial state after reset

We used to fail the set_vq_state() since it was not supported yet by the virtio spec. But if the bus tries to set the state which is equal to the device initial state after reset, we can let it go. This is a must for virtio_vdpa() to set vq state during probe which is required for some vDPA parent

[PATCH V2 2/4] virtio-pci library: introduce vp_modern_get_driver_features()

This patch introduce a helper to get driver/guest features from the device. Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_modern_dev.c | 21 + include/linux/virtio_pci_modern.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/virtio/virtio_pci_mo

[PATCH V2 1/4] vdpa: support packed virtqueue for set/get_vq_state()

This patch extends the vdpa_vq_state to support packed virtqueue state which is basically the device/driver ring wrap counters and the avail and used index. This will be used for the virito-vdpa support for the packed virtqueue and the future vhost/vhost-vdpa support for the packed virtqueue. Sign

[PATCH V2 0/4]

*** BLURB HERE *** Eli Cohen (1): virtio/vdpa: clear the virtqueue state during probe Jason Wang (3): vdpa: support packed virtqueue for set/get_vq_state() virtio-pci library: introduce vp_modern_get_driver_features() vp_vdpa: allow set vq state to initial state after reset drivers/vdpa

Re: virtio-net: kernel panic in virtio_net.c

On Tue, 1 Jun 2021 19:47:44 +0200, Eric Dumazet wrote: > On Tue, Jun 1, 2021 at 7:09 PM Corentin Noël > wrote: > > > > Le mardi 01 juin 2021 à 19:07 +0200, Greg KH a écrit : > > > On Tue, Jun 01, 2021 at 06:06:50PM +0200, Corentin Noël wrote: > > > > I've been experiencing crashes with 5.13 that

Re: [PATCH 1/4] vdpa: support packed virtqueue for set/get_vq_state()

Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linus/master v5.13-rc4 next-20210601] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: virtio-net: kernel panic in virtio_net.c

On Tue, Jun 01, 2021 at 06:06:50PM +0200, Corentin Noël wrote: > I've been experiencing crashes with 5.13 that do not occur with 5.12, > here is the crash trace: > > [ 47.713713] skbuff: skb_over_panic: text:b73a8354 len:3762 > put:3762 head:9e1e1e48e000 data:9e1e1e48e010 tail:0x

Re: [PATCH net v2 0/2] virtio-net: fix for build_skb()

On Tue, Jun 01, 2021 at 02:39:58PM +0800, Xuan Zhuo wrote: > #1 Fixed a serious error. > #2 Fixed a logical error, but this error did not cause any serious > consequences. > > The logic of this piece is really messy. Fortunately, my refactored patch can > be > completed with a small amount of te

Re: [PATCH V3 2/2] vDPA/ifcvf: implement doorbell mapping for ifcvf

在 2021/6/1 下午4:56, Zhu, Lingshan 写道: On 6/1/2021 4:50 PM, Jason Wang wrote: 在 2021/6/1 下午2:28, Zhu Lingshan 写道: This commit implements doorbell mapping feature for ifcvf. This feature maps the notify page to userspace, to eliminate vmexit when kick a vq. Signed-off-by: Zhu Lingshan ---  

Re: [PATCH net v2 2/2] virtio_net: get build_skb() buf by data ptr

在 2021/6/1 下午2:40, Xuan Zhuo 写道: In the case of merge, the page passed into page_to_skb() may be a head page, not the page where the current data is located. So when trying to get the buf where the data is located, we should get buf based on headroom instead of offset. This patch solves this pr

Re: [PATCH net v2 1/2] virtio-net: fix for unable to handle page fault for address

在 2021/6/1 下午2:39, Xuan Zhuo 写道: In merge mode, when xdp is enabled, if the headroom of buf is smaller than virtnet_get_headroom(), xdp_linearize_page() will be called but the variable of "headroom" is still 0, which leads to wrong logic after entering page_to_skb(). [ 16.600944] BUG: unable

Re: [PATCH V3 1/2] vDPA/ifcvf: record virtio notify base

在 2021/6/1 下午2:28, Zhu Lingshan 写道: This commit records virtio notify base physical addr and calculate doorbell physical address for vqs. Signed-off-by: Zhu Lingshan Acked-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_base.c | 4 drivers/vdpa/ifcvf/ifcvf_base.h | 2 ++ 2 files ch

Re: [PATCH V3 2/2] vDPA/ifcvf: implement doorbell mapping for ifcvf

在 2021/6/1 下午2:28, Zhu Lingshan 写道: This commit implements doorbell mapping feature for ifcvf. This feature maps the notify page to userspace, to eliminate vmexit when kick a vq. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 21 + 1 file changed, 21 i

[PATCH 4/4] virtio/vdpa: clear the virtqueue state during probe

From: Eli Cohen Clear the available index as part of the initialization process to clear and values that might be left from previous usage of the device. For example, if the device was previously used by vhost_vdpa and now probed by vhost_vdpa, you want to start with indices. Fixes: c043b4a8cf3b

[PATCH 3/4] vp_vdpa: allow set vq state to initial state after reset

We used to fail the set_vq_state() since it was not supported yet by the virtio spec. But if the bus tries to set the state which is equal to the device initial state after reset, we can let it go. This is a must for virtio_vdpa() to set vq state during probe which is required for some vDPA parent

[PATCH 2/4] virtio-pci library: introduce vp_modern_get_driver_features()

This patch introduce a helper to get driver/guest features from the device. Signed-off-by: Jason Wang --- drivers/virtio/virtio_pci_modern_dev.c | 21 + include/linux/virtio_pci_modern.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/virtio/virtio_pci_mo

[PATCH 1/4] vdpa: support packed virtqueue for set/get_vq_state()

This patch extends the vdpa_vq_state to support packed virtqueue state which is basically the device/driver ring wrap counters and the avail and used index. This will be used for the virito-vdpa support for the packed virtqueue and the future vhost/vhost-vdpa support for the packed virtqueue. Sign

[PATCH 0/4] Packed virtqueue state support for vDPA

Hi: This series implements the packed virtqueue state support for vDPA. This is done via extending the vdpa_vq_state to support packed virtqueue. For virtio-vDPA, an initial state required by the virtio spec is set. For vhost-vDPA, the packed virtqueue support still needs to be done at both vhos