Re: [PATCH 0/2] vdpasim: allow to set MAC address

2020-10-29 Thread Jason Wang
On 2020/10/29 下午8:20, Laurent Vivier wrote: This series starts by fixing a bug: vdpa_sim generates a MAC address that is never show to upper layer, and thus virtio-net generates another random MAC address, that changes each time virtio-net is loaded (even if vdpa_sim is not unloaded). Then it a

Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread kernel test robot
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.10-rc1 next-20201029] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-29 Thread si-wei liu
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote: On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote: On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote: On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote: On 2020/10/14 上午7:42, si-wei liu wrote: So what I suggest is to fix the pi

Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-29 Thread Michael S. Tsirkin
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote: > > On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote: > > On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote: > > > On 2020/10/14 上午7:42, si-wei liu wrote: > > > > > > > > > > So what I suggest is to fix the pinning leakage first

Re: [PATCH 00/17 V3] vhost: fix scsi cmd handling and cgroup support

2020-10-29 Thread Michael S. Tsirkin
On Wed, Oct 21, 2020 at 07:34:46PM -0500, Mike Christie wrote: > In-Reply-To: > > The following patches were made over Michael's vhost branch here: > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/log/?h=vhost > > They fix a couple issues with vhost-scsi when we hit the 256 cmd

Re: [PATCH] vhost: Use mutex to protect vq_irq setup

2020-10-29 Thread Michael S. Tsirkin
On Thu, Oct 29, 2020 at 09:37:17AM +0200, Eli Cohen wrote: > On Thu, Oct 29, 2020 at 03:03:24PM +0800, Jason Wang wrote: > > > > On 2020/10/28 下午10:20, Eli Cohen wrote: > > > Both irq_bypass_register_producer() and irq_bypass_unregister_producer() > > > require process context to run. Change the c

[PATCH] vhost/vsock: add IOTLB API support

2020-10-29 Thread Stefano Garzarella
This patch enables the IOTLB API support for vhost-vsock devices, allowing the userspace to emulate an IOMMU for the guest. These changes were made following vhost-net, in details this patch: - exposes VIRTIO_F_ACCESS_PLATFORM feature and inits the iotlb device if the feature is acked - implemen

Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Disable-accelerated-scrolling/20201029-181618 base: git://anongit.freedeskt

[PATCH] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread Daniel Vetter
These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code"). v2: Somehow these structs provided the struct qxl_device pre-decl, reorder the header to not anger compilers. Acked-by: Gerd Hoffmann Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: vir

[PATCH 1/2] vdpasim: fix MAC address configuration

2020-10-29 Thread Laurent Vivier
vdpa_sim generates a ramdom MAC address but it is never used by upper layers because the VIRTIO_NET_F_MAC bit is not set in the features list. Because of that, virtio-net always regenerates a random MAC address each time it is loaded whereas the address should only change on vdpa_sim load/unload.

[PATCH 2/2] vdpasim: allow to assign a MAC address

2020-10-29 Thread Laurent Vivier
Add macaddr parameter to the module to set the MAC address to use Signed-off-by: Laurent Vivier --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index 7f8ebc

[PATCH 0/2] vdpasim: allow to set MAC address

2020-10-29 Thread Laurent Vivier
This series starts by fixing a bug: vdpa_sim generates a MAC address that is never show to upper layer, and thus virtio-net generates another random MAC address, that changes each time virtio-net is loaded (even if vdpa_sim is not unloaded). Then it adds a parameter to vpa_sim module to allow the

Re: [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread Gerd Hoffmann
On Thu, Oct 29, 2020 at 11:14:28AM +0100, Daniel Vetter wrote: > These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev > emulation code"). Acked-by: Gerd Hoffmann ___ Virtualization mailing list Virtualization@lists.linux-foundation.or

[PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers

2020-10-29 Thread Daniel Vetter
These are leftovers from 13aff184ed9f ("drm/qxl: remove dead qxl fbdev emulation code"). Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org Cc: spice-de...@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_drv.h | 14 -- 1 f

Re: [PATCH] vhost: Use mutex to protect vq_irq setup

2020-10-29 Thread Jason Wang
On 2020/10/29 下午3:50, Eli Cohen wrote: On Thu, Oct 29, 2020 at 03:39:24PM +0800, Jason Wang wrote: On 2020/10/29 下午3:37, Eli Cohen wrote: On Thu, Oct 29, 2020 at 03:03:24PM +0800, Jason Wang wrote: On 2020/10/28 下午10:20, Eli Cohen wrote: Both irq_bypass_register_producer() and irq_bypass_unr

Re: [PATCH] vhost: Use mutex to protect vq_irq setup

2020-10-29 Thread Jason Wang
On 2020/10/29 下午3:37, Eli Cohen wrote: On Thu, Oct 29, 2020 at 03:03:24PM +0800, Jason Wang wrote: On 2020/10/28 下午10:20, Eli Cohen wrote: Both irq_bypass_register_producer() and irq_bypass_unregister_producer() require process context to run. Change the call context lock from spinlock to mute

Re: [PATCH] vhost: Use mutex to protect vq_irq setup

2020-10-29 Thread Jason Wang
On 2020/10/28 下午10:20, Eli Cohen wrote: Both irq_bypass_register_producer() and irq_bypass_unregister_producer() require process context to run. Change the call context lock from spinlock to mutex to protect the setup process to avoid deadlocks. Fixes: 265a0ad8731d ("vhost: introduce vhost_vrin