Re: [virtio-dev] [PATCH 2/2] drm/virtio: add iommu support.

2018-09-19 Thread Gerd Hoffmann
Hi, > void virtio_gpu_cmd_transfer_to_host_2d(struct virtio_gpu_device *vgdev, > uint32_t resource_id, uint64_t offset, > ... > struct virtio_gpu_fbdev *vgfbdev = vgdev->vgfbdev; > struct virtio_gpu_framebuffer *fb = &vgfbdev->vgfb; > struct

[PATCH] drm/virtio: pass virtio_gpu_object to virtio_gpu_cmd_transfer_to_host_{2d, 3d}

2018-09-19 Thread Gerd Hoffmann
Pass virtio_gpu_object down to virtio_gpu_cmd_transfer_to_host_2d and virtio_gpu_cmd_transfer_to_host_3d functions, instead of passing just the virtio resource handle. This is needed to lookup the scatter list of the object, for dma sync. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/

Re: [RFC PATCH 2/2] virtio/s390: fix race in ccw_io_helper()

2018-09-19 Thread Cornelia Huck
On Wed, 19 Sep 2018 15:17:28 +0200 Halil Pasic wrote: > On 09/18/2018 08:45 PM, Cornelia Huck wrote: > > We basically have two options: > > - Have a way to queue I/O operations and then handle them in sequence. > > Creates complexity, and is likely overkill. (We already have a kind > > of se

Re: [patch 09/11] x86/vdso: Simplify the invalid vclock case

2018-09-19 Thread Thomas Gleixner
On Wed, 19 Sep 2018, Rasmus Villemoes wrote: > On 2018-09-19 00:46, Thomas Gleixner wrote: > > On Tue, 18 Sep 2018, Andy Lutomirski wrote: > >>> > >> > >> Do we do better if we use signed arithmetic for the whole calculation? > >> Then a small backwards movement would result in a small backwards re

Re: [virtio-dev] [PATCH 2/2] drm/virtio: add iommu support.

2018-09-19 Thread Gerd Hoffmann
> >> Once display manger is kicked off for example (sudo systemctl start > >> lightdm.service) and > >> resource id 3 gets created from user space down, it still gives a blank > >> black screen. > > > > Hmm. I'd suspect there is simply a code path missing. Can you send the > > patch you have?

Re: [PATCH] drm/virtio: add dma sync for dma mapped virtio gpu framebuffer pages

2018-09-19 Thread kra...@redhat.com
On Wed, Sep 19, 2018 at 07:09:53AM +, An, Jiandi wrote: > With virtio gpu ttm-pages being dma mapped, dma sync is needed when > swiotlb is used as bounce buffers, before TRANSFER_TO_HOST_2D/3D > commands are sent. Pushed to drm-misc-next. thanks, Gerd __

Re: [RFC PATCH 1/2] virtio/s390: avoid race on vcdev->config

2018-09-19 Thread Cornelia Huck
On Wed, 19 Sep 2018 00:52:14 +0200 Halil Pasic wrote: > On 09/18/2018 08:29 PM, Cornelia Huck wrote: > > On Wed, 12 Sep 2018 16:02:01 +0200 > > Halil Pasic wrote: > > > >> Currently we have a race on vcdev->config in virtio_ccw_get_config() and > >> in virtio_ccw_set_config(). > >> > >> This

[PATCH v3 3/5] drm/bochs: fix DRM_FORMAT_* handling for big endian machines.

2018-09-19 Thread Gerd Hoffmann
Use DRM_FORMAT_HOST_XRGB, so we are using the correct format code on bigendian machines. Also set the quirk_addfb_prefer_host_byte_order mode_config bit so drm_mode_addfb() asks for the correct format code. Create our own plane and use drm_crtc_init_with_planes() instead of depending on the d

[PATCH v3 5/5] drm/virtio: fix DRM_FORMAT_* handling

2018-09-19 Thread Gerd Hoffmann
Use DRM_FORMAT_HOST_XRGB, so we are using the correct format code on bigendian machines. Also set the quirk_addfb_prefer_host_byte_order mode_config bit so drm_mode_addfb() asks for the correct format code. Both DRM_FORMAT_* and VIRTIO_GPU_FORMAT_* are defined to be little endian, so using a

[PATCH v3 4/5] drm/bochs: support changing byteorder at mode set time

2018-09-19 Thread Gerd Hoffmann
Add bochs_hw_set_*_endian() helper functions, to set the framebuffer byteorder at mode set time. Support both DRM_FORMAT_XRGB and DRM_FORMAT_BGRX framebuffer formats, no matter what the native machine byte order is. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs.h |

Re: [PATCH] x86/paravirt: fix some warning messages

2018-09-19 Thread Juergen Gross
On 19/09/18 12:35, Dan Carpenter wrote: > The first argument to WARN_ONCE() is a condition. > > Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt > guests") > Signed-off-by: Dan Carpenter Reviewed-by: Juergen Gross Juergen ___

[PATCH] x86/paravirt: fix some warning messages

2018-09-19 Thread Dan Carpenter
The first argument to WARN_ONCE() is a condition. Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests") Signed-off-by: Dan Carpenter diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index bbf006fe78d7..e4d4df37922a 100644 --- a/arch/x86/kernel/