Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Samudrala, Sridhar
On 6/26/2018 11:21 PM, Siwei Liu wrote: On Tue, Jun 26, 2018 at 5:29 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 04:38:26PM -0700, Siwei Liu wrote: On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirkin wrote: On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: Might

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Siwei Liu
On Tue, Jun 26, 2018 at 5:29 PM, Michael S. Tsirkin wrote: > On Tue, Jun 26, 2018 at 04:38:26PM -0700, Siwei Liu wrote: >> On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirkin wrote: >> > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: >> >> > > > > Might not neccessarily be so

Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/27/2018 11:58 AM, Michael S. Tsirkin wrote: On Wed, Jun 27, 2018 at 11:00:05AM +0800, Wei Wang wrote: On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 08:

Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 11:00:05AM +0800, Wei Wang wrote: > On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: > > On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: > > > On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: > > > > On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: > > >

Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 11:

Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: > On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: > > On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: > > > On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: > > > > On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: > > >

Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: + if (!arrays) + return NULL; + + for (i = 0; i < m

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 04:38:26PM -0700, Siwei Liu wrote: > On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirkin wrote: > > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > >> > > > > Might not neccessarily be something wrong, but it's very limited to > >> > > > > prohibit the

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Siwei Liu
On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirkin wrote: > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: >> > > > > Might not neccessarily be something wrong, but it's very limited to >> > > > > prohibit the MAC of VF from changing when enslaved by failover. >> > > > You me

Re: [PATCH v2 0/5] Add virtio-iommu driver

2018-06-26 Thread Michael S. Tsirkin
On Thu, Jun 21, 2018 at 08:06:50PM +0100, Jean-Philippe Brucker wrote: > Implement the base virtio-iommu driver, following version 0.7 of the > specification [1]. > > Changes since last version [2]: > * Address comments, thanks again for the review. > * As suggested, add a DT binding description i

Re: [virtio-dev] [PATCH v2 3/5] iommu/virtio: Add probe request

2018-06-26 Thread Jean-Philippe Brucker
On 21/06/18 20:06, Jean-Philippe Brucker wrote: > +static int viommu_add_resv_mem(struct viommu_endpoint *vdev, > +struct virtio_iommu_probe_resv_mem *mem, > +size_t len) > +{ > + struct iommu_resv_region *region = NULL; > + unsigned l

Re: [PATCH v2 1/5] dt-bindings: virtio: Specify #iommu-cells value for a virtio-iommu

2018-06-26 Thread Jean-Philippe Brucker
On 25/06/18 20:27, Rob Herring wrote: > On Thu, Jun 21, 2018 at 08:06:51PM +0100, Jean-Philippe Brucker wrote: >> A virtio-mmio node may represent a virtio-iommu device. This is discovered >> by the virtio driver at probe time, but the DMA topology isn't >> discoverable and must be described by fir

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 05:08:13PM +0200, Cornelia Huck wrote: > On Fri, 22 Jun 2018 17:05:04 -0700 > Siwei Liu wrote: > > > On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirkin wrote: > > > I suspect the diveregence will be lost on most users though > > > simply because they don't even care abou

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 06:03:16PM +0200, Cornelia Huck wrote: > Ok, that makes me conclude that we definitely need to involve the > libvirt folks before we proceed further with defining QEMU interfaces. That's always a wise thing to do. -- MST ___ Vir

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 18:38:51 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 05:17:32PM +0200, Cornelia Huck wrote: > > On Tue, 26 Jun 2018 04:50:25 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > > > > > > >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 05:17:32PM +0200, Cornelia Huck wrote: > On Tue, 26 Jun 2018 04:50:25 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > > > > > > > Might not neccessarily be something wrong, but it's very limited > > > > > > >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 04:50:25 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > > > > > > Might not neccessarily be something wrong, but it's very limited to > > > > > > prohibit the MAC of VF from changing when enslaved by failover. > > >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Fri, 22 Jun 2018 17:05:04 -0700 Siwei Liu wrote: > On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirkin wrote: > > I suspect the diveregence will be lost on most users though > > simply because they don't even care about vfio. They just > > want things to go fast. > > Like Jason said, VF is

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 01:55:09PM +0200, Cornelia Huck wrote: > On Tue, 26 Jun 2018 04:46:03 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jun 25, 2018 at 11:55:12AM +0200, Cornelia Huck wrote: > > > On Fri, 22 Jun 2018 22:05:50 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Fr

Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: > On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: > > On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: > > > > > > > > > > > > > > > + if (!arrays) > > > > > + return NULL; > > > > > + > > > > > + for (i =

Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: + if (!arrays) + return NULL; + + for (i = 0; i < max_array_num; i++) { So we are getting a ton of memory here just to free it up a bit later. Why doesn't

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 04:46:03 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 25, 2018 at 11:55:12AM +0200, Cornelia Huck wrote: > > On Fri, 22 Jun 2018 22:05:50 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > > > On Thu, 21

Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

2018-06-26 Thread Ingo Molnar
* Nick Desaulniers wrote: > On Thu, Jun 21, 2018 at 7:24 PM Ingo Molnar wrote: > > * Nick Desaulniers wrote: > > > > > native_save_fl() is marked static inline, but by using it as > > > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > > > > > --- a/arch/x86/include/asm