Re: [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops

2018-06-19 Thread kbuild test robot
Hi Nadav, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc1 next-20180619] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 12:54:53PM +0200, Cornelia Huck wrote: > Sorry about dragging mainframes into this, but this will only work for > homogenous device coupling, not for heterogenous. Consider my vfio-pci > + virtio-net-ccw example again: The guest cannot find out that the two > belong together

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Siwei Liu
On Tue, Jun 19, 2018 at 3:54 AM, Cornelia Huck wrote: > On Fri, 15 Jun 2018 10:06:07 -0700 > Siwei Liu wrote: > >> On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: >> > On Thu, 14 Jun 2018 18:57:11 -0700 >> > Siwei Liu wrote: >> > >> >> Thank you for sharing your thoughts, Cornelia. With q

Re: Design Decision for KVM based anti rootkit

2018-06-19 Thread Ahmed Soliman
On 19 June 2018 at 19:37, David Vrabel wrote: > It's not clear how this increases security. What threats is this > protecting again? It won't completely protect prevent rootkits, because still rootkits can edit dynamic kernel data structures, but it will limit what rootkits damage to only dynamic

Re: [PATCH v4 6/9] x86: prevent inline distortion by paravirt ops

2018-06-19 Thread Juergen Gross
On 12/06/18 13:50, Nadav Amit wrote: > GCC considers the number of statements in inlined assembly blocks, > according to new-lines and semicolons, as an indication to the cost of > the block in time and space. This data is distorted by the kernel code, > which puts information in alternative sectio

Re: [PATCH v5 0/3] extern inline native_save_fl for paravirt

2018-06-19 Thread Juergen Gross
On 13/06/18 23:05, Nick Desaulniers wrote: > paravirt depends on a custom calling convention (callee saved), but > expects this from a static inline function that it then forces to be > outlined. This is problematic because different compilers or flags can > then add a stack guard that violates the

Re: [virtio-dev] Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 08:13:37PM +0800, Wei Wang wrote: > On 06/19/2018 11:05 AM, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 01:06:48AM +, Wang, Wei W wrote: > > > On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: > > > > On Sat, Jun 16, 2018 at 01:09:44AM +, Wang, W

Re: [virtio-dev] Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-19 Thread Wei Wang
On 06/19/2018 11:05 AM, Michael S. Tsirkin wrote: On Tue, Jun 19, 2018 at 01:06:48AM +, Wang, Wei W wrote: On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: On Sat, Jun 16, 2018 at 01:09:44AM +, Wang, Wei W wrote: Not necessarily, I think. We have min(4m_page_blocks / 512, 1

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Cornelia Huck
On Fri, 15 Jun 2018 10:06:07 -0700 Siwei Liu wrote: > On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > > On Thu, 14 Jun 2018 18:57:11 -0700 > > Siwei Liu wrote: > > > >> Thank you for sharing your thoughts, Cornelia. With questions below, I > >> think you raised really good points, som