Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2013 at 11:14:47AM -0500, Anthony Liguori wrote: > > Well specifically if_ether.h says GPLv2+ so it's OK for QEMU. > > Do you mean for some other non GPL app? > > Ignore QEMU for the moment. > > The headers say they are BSD licensed... but they include a GPLv2+ > header. Above is

Re: [PATCH rusty/virtio-pci-new-layout] virtio: new layout minor header fixups

2013-05-27 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Fix issues observed with the new layout code, seen > when implementing device in qemu: > - use of uXX in uapi header > - incorrect readonly tag on one field > - unconditional warning breaks builds with -Werr > > Signed-off-by: Michael S. Tsirkin H

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Anthony Liguori
Rusty Russell writes: > Anthony Liguori writes: >> Paolo Bonzini writes: >> >>> Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: > My fault. I should have looked at linux/types.h (actually asm-generic/). Not really, __uX appear in the headers that were posted. >> >> Which is

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Rusty Russell
Anthony Liguori writes: > Paolo Bonzini writes: > >> Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: >>> > My fault. I should have looked at linux/types.h (actually asm-generic/). >>> >>> Not really, __uX appear in the headers that were posted. > > Which is a problem because this is a reser

Re: [PATCH] virtio-balloon spec: rework VIRTIO_BALLOON_F_MUST_TELL_HOST feature, support silent deflation

2013-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2013 at 06:09:54PM +0200, Paolo Bonzini wrote: > Il 27/05/2013 18:04, Michael S. Tsirkin ha scritto: > > I don't think we need a new feature. Hosts do not in practice > > treat the feature as "negative" (that is, required), whatever the spec > > says. Further, windows guests don't

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Sun, May 26, 2013 at 07:55:25PM -0500, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Sun, May 26, 2013 at 03:49:53PM -0500, Anthony Liguori wrote: >> >> Paolo Bonzini writes: >> >> >> >> > Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto

Re: [PATCH] virtio-balloon spec: rework VIRTIO_BALLOON_F_MUST_TELL_HOST feature, support silent deflation

2013-05-27 Thread Paolo Bonzini
Il 27/05/2013 18:04, Michael S. Tsirkin ha scritto: > I don't think we need a new feature. Hosts do not in practice > treat the feature as "negative" (that is, required), whatever the spec > says. Further, windows guests don't treat it is such either. Windows guests not treating as such is what m

Re: [PATCH] virtio-balloon spec: rework VIRTIO_BALLOON_F_MUST_TELL_HOST feature, support silent deflation

2013-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2013 at 05:55:05PM +0200, Paolo Bonzini wrote: > Il 08/05/2013 12:10, Paolo Bonzini ha scritto: > > The idea of the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is to let drivers > > skip usage of the deflate queue when leaking the balloon ("silent > > deflation"). Guests may benefit fr

[PATCH rusty/virtio-pci-new-layout] virtio: new layout minor header fixups

2013-05-27 Thread Michael S. Tsirkin
Fix issues observed with the new layout code, seen when implementing device in qemu: - use of uXX in uapi header - incorrect readonly tag on one field - unconditional warning breaks builds with -Werr Signed-off-by: Michael S. Tsirkin --- This patch is on top of rusty/virt

Re: [PATCH] virtio-balloon spec: rework VIRTIO_BALLOON_F_MUST_TELL_HOST feature, support silent deflation

2013-05-27 Thread Paolo Bonzini
Il 08/05/2013 12:10, Paolo Bonzini ha scritto: > The idea of the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is to let drivers > skip usage of the deflate queue when leaking the balloon ("silent > deflation"). Guests may benefit from silent deflate by aggressively > inflating the balloon; they know th

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Michael S. Tsirkin
On Sun, May 26, 2013 at 07:55:25PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Sun, May 26, 2013 at 03:49:53PM -0500, Anthony Liguori wrote: > >> Paolo Bonzini writes: > >> > >> > Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: > >> >> > My fault. I should have lo