Re: Bug in SeaBIOS virtio-ring handling bug with vhost-scsi-pci

2013-04-08 Thread Nicholas A. Bellinger
On Tue, 2013-04-09 at 12:24 +0800, Asias He wrote: > On Mon, Apr 08, 2013 at 09:09:54PM -0700, Nicholas A. Bellinger wrote: > > Ping. > > > > Any ideas on this one..? It seems like this bug would be effecting > > non vhost-scsi-pci code as well.. > > Nicholas, where is the latest v3 code. Can yo

Re: Bug in SeaBIOS virtio-ring handling bug with vhost-scsi-pci

2013-04-08 Thread Asias He
On Mon, Apr 08, 2013 at 09:09:54PM -0700, Nicholas A. Bellinger wrote: > Ping. > > Any ideas on this one..? It seems like this bug would be effecting > non vhost-scsi-pci code as well.. Nicholas, where is the latest v3 code. Can you push it to your tree. > --nab > > On Thu, 2013-04-04 at 19:5

Re: Bug in SeaBIOS virtio-ring handling bug with vhost-scsi-pci

2013-04-08 Thread Nicholas A. Bellinger
Ping. Any ideas on this one..? It seems like this bug would be effecting non vhost-scsi-pci code as well.. --nab On Thu, 2013-04-04 at 19:59 -0700, Nicholas A. Bellinger wrote: > Hi Paolo & Co, > > So I've been running into another bug with SeaBIOS w/ virtio-scsi + > vhost-scsi-pci code.. > >

Re: [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon

2013-04-08 Thread Nicholas A. Bellinger
On Mon, 2013-04-08 at 16:59 -0500, Anthony Liguori wrote: > "Nicholas A. Bellinger" writes: > > > From: Paolo Bonzini > > > > This patch refactors existing virtio-scsi code into VirtIOSCSICommon > > in order to allow virtio_scsi_init_common() to be used by both internal > > virtio_scsi_init() an

Re: [PATCH V4 0/2] tcm_vhost hotplug

2013-04-08 Thread Asias He
On Mon, Apr 08, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: > On Fri, 2013-03-22 at 13:39 +0800, Asias He wrote: > > Asias He (2): > > tcm_vhost: Introduce tcm_vhost_check_feature() > > tcm_vhost: Add hotplug/hotunplug support > > > > drivers/vhost/tcm_vhost.c | 224 > > ++

Re: [PATCH] x86: make IDT read-only

2013-04-08 Thread Maciej W. Rozycki
On Mon, 8 Apr 2013, Kees Cook wrote: > > FWIW the change looks reasonable to me, however given that that it makes > > the arrangement unconditional and there is no longer a workaround to > > enable I think it would make sense to remove the conditional block quoted > > above altogether, along with

Re: [PATCH] x86: make IDT read-only

2013-04-08 Thread Kees Cook
On Mon, Apr 8, 2013 at 3:56 PM, Maciej W. Rozycki wrote: > On Mon, 8 Apr 2013, Kees Cook wrote: > >> This makes the IDT unconditionally read-only. This primarily removes >> the IDT from being a target for arbitrary memory write attacks. It has >> an added benefit of also not leaking (via the "sidt

Re: [PATCH] x86: make IDT read-only

2013-04-08 Thread Maciej W. Rozycki
On Mon, 8 Apr 2013, Kees Cook wrote: > This makes the IDT unconditionally read-only. This primarily removes > the IDT from being a target for arbitrary memory write attacks. It has > an added benefit of also not leaking (via the "sidt" instruction) the > kernel base offset, if it has been relocate

Re: [PATCH] x86: make IDT read-only

2013-04-08 Thread Kees Cook
On Mon, Apr 8, 2013 at 3:56 PM, Maciej W. Rozycki wrote: > On Mon, 8 Apr 2013, Kees Cook wrote: > >> This makes the IDT unconditionally read-only. This primarily removes >> the IDT from being a target for arbitrary memory write attacks. It has >> an added benefit of also not leaking (via the "sidt

Re: [PATCH] x86: make IDT read-only

2013-04-08 Thread Kees Cook
On Mon, Apr 8, 2013 at 3:47 PM, H. Peter Anvin wrote: > On 04/08/2013 03:43 PM, Kees Cook wrote: >> This makes the IDT unconditionally read-only. This primarily removes >> the IDT from being a target for arbitrary memory write attacks. It has >> an added benefit of also not leaking (via the "sidt"

Re: [PATCH] x86: make IDT read-only

2013-04-08 Thread H. Peter Anvin
On 04/08/2013 03:43 PM, Kees Cook wrote: > This makes the IDT unconditionally read-only. This primarily removes > the IDT from being a target for arbitrary memory write attacks. It has > an added benefit of also not leaking (via the "sidt" instruction) the > kernel base offset, if it has been reloc

Re: [PATCH] x86: make IDT read-only

2013-04-08 Thread H. Peter Anvin
On 04/08/2013 03:43 PM, Kees Cook wrote: > This makes the IDT unconditionally read-only. This primarily removes > the IDT from being a target for arbitrary memory write attacks. It has > an added benefit of also not leaking (via the "sidt" instruction) the > kernel base offset, if it has been reloc

[PATCH] x86: make IDT read-only

2013-04-08 Thread Kees Cook
This makes the IDT unconditionally read-only. This primarily removes the IDT from being a target for arbitrary memory write attacks. It has an added benefit of also not leaking (via the "sidt" instruction) the kernel base offset, if it has been relocated. Signed-off-by: Kees Cook Cc: Eric Northup

Re: [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon

2013-04-08 Thread Anthony Liguori
"Nicholas A. Bellinger" writes: > From: Paolo Bonzini > > This patch refactors existing virtio-scsi code into VirtIOSCSICommon > in order to allow virtio_scsi_init_common() to be used by both internal > virtio_scsi_init() and external vhost-scsi-pci code. > > Changes in Patch-v2: >- Move ->g

Re: [PATCH V4 0/2] tcm_vhost hotplug

2013-04-08 Thread Michael S. Tsirkin
On Mon, Apr 08, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: > On Fri, 2013-03-22 at 13:39 +0800, Asias He wrote: > > Asias He (2): > > tcm_vhost: Introduce tcm_vhost_check_feature() > > tcm_vhost: Add hotplug/hotunplug support > > > > drivers/vhost/tcm_vhost.c | 224 > > ++

Re: [PATCH V4 0/2] tcm_vhost hotplug

2013-04-08 Thread Nicholas A. Bellinger
(Re-send, as target-devel CC' managed to get dropped) On Fri, 2013-03-22 at 13:39 +0800, Asias He wrote: > Asias He (2): > tcm_vhost: Introduce tcm_vhost_check_feature() > tcm_vhost: Add hotplug/hotunplug support > > drivers/vhost/tcm_vhost.c | 224 >

Re: [PATCH V2 0/3] tcm_vhost pending requests flush

2013-04-08 Thread Nicholas A. Bellinger
On Fri, 2013-03-22 at 14:55 +0800, Asias He wrote: > Changes in v2: > - Increase/Decrease inflight requests in > vhost_scsi_{allocate,free}_cmd and tcm_vhost_{allocate,free}_evt > > Asias He (3): > tcm_vhost: Wait for pending requests in vhost_scsi_flush() > tcm_vhost: Wait for pending reque

Re: [PATCH V4 0/2] tcm_vhost hotplug

2013-04-08 Thread Nicholas A. Bellinger
On Fri, 2013-03-22 at 13:39 +0800, Asias He wrote: > Asias He (2): > tcm_vhost: Introduce tcm_vhost_check_feature() > tcm_vhost: Add hotplug/hotunplug support > > drivers/vhost/tcm_vhost.c | 224 > -- > drivers/vhost/tcm_vhost.h | 10 +++ > 2 file

Re: [PATCH V3 2/2] tcm_vhost: Initialize vq->last_used_idx when set endpoint

2013-04-08 Thread Nicholas A. Bellinger
On Mon, 2013-04-08 at 10:10 +0300, Michael S. Tsirkin wrote: > On Wed, Apr 03, 2013 at 02:17:38PM +0800, Asias He wrote: > > This patch fixes guest hang when booting seabios and guest. > > > > [0.576238] scsi0 : Virtio SCSI HBA > > [0.616754] virtio_scsi virtio1: request:id 0 is not a

Re: [PATCH V3 1/2] tcm_vhost: Use vq->private_data to indicate if the endpoint is setup

2013-04-08 Thread Nicholas A. Bellinger
On Mon, 2013-04-08 at 10:10 +0300, Michael S. Tsirkin wrote: > On Wed, Apr 03, 2013 at 02:17:37PM +0800, Asias He wrote: > > Currently, vs->vs_endpoint is used indicate if the endpoint is setup or > > not. It is set or cleared in vhost_scsi_set_endpoint() or > > vhost_scsi_clear_endpoint() under th

Re: [PATCH -next] virtio_console: make local symbols static

2013-04-08 Thread Rusty Russell
Amit Shah writes: > On (Sat) 06 Apr 2013 [11:52:07], Wei Yongjun wrote: >> From: Wei Yongjun >> >> Those symbols only used within this file, and should be static. >> >> Signed-off-by: Wei Yongjun > > Acked-by: Amit Shah > > Amit Thanks, applied. Cheers, Rusty. ___

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-08 Thread Rusty Russell
Asias He writes: > On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote: >> Well, I haven't had time to look at anything other than the patch I >> commented on. I'm happy with your fix, so you can add my acked by to >> that one. Since it's going through the virtio tree, don't wait for

Re: [PATCH V3 2/2] tcm_vhost: Initialize vq->last_used_idx when set endpoint

2013-04-08 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 02:17:38PM +0800, Asias He wrote: > This patch fixes guest hang when booting seabios and guest. > > [0.576238] scsi0 : Virtio SCSI HBA > [0.616754] virtio_scsi virtio1: request:id 0 is not a head! > > vq->last_used_idx is initialized only when /dev/vhost-scsi i

Re: [PATCH V3 1/2] tcm_vhost: Use vq->private_data to indicate if the endpoint is setup

2013-04-08 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 02:17:37PM +0800, Asias He wrote: > Currently, vs->vs_endpoint is used indicate if the endpoint is setup or > not. It is set or cleared in vhost_scsi_set_endpoint() or > vhost_scsi_clear_endpoint() under the vs->dev.mutex lock. However, when > we check it in vhost_scsi_handl

Re: [PATCH V3 0/2] tcm_vhost endpoint

2013-04-08 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 02:17:36PM +0800, Asias He wrote: > Hello mst, > > How about this one? > > Asias He (2): > tcm_vhost: Use vq->private_data to indicate if the endpoint is setup > tcm_vhost: Initialize vq->last_used_idx when set endpoint > > drivers/vhost/tcm_vhost.c | 145 >

Re: [PATCH 0/2] virtio-serial: set up vqs on demand

2013-04-08 Thread Amit Shah
On (Thu) 12 Jan 2012 [09:20:05], zanghongy...@huawei.com wrote: > From: Hongyong Zang > > Virtio-serial set up (max_ports+1)*2 vqs when device probes, but may not all > io_ports are used. > These patches create vqs of port0 and control port when probing the device, > then > create io-vqs when

Re: [Qemu-devel] [RFC qemu PATCH] only writing out the last byte of MAC makes it have effect

2013-04-08 Thread Amos Kong
On Mon, Mar 25, 2013 at 08:58:49AM +0200, Michael S. Tsirkin wrote: > On Mon, Mar 25, 2013 at 10:23:57AM +0800, Amos Kong wrote: > > On Fri, Mar 22, 2013 at 10:45:09AM +1030, Rusty Russell wrote: > > > "Michael S. Tsirkin" writes: > > > > On Thu, Mar 21, 2013 at 02:44:50PM +0800, Amos Kong wrote: