Re: [rfc net-next v6 2/3] virtio_net: multiqueue support

2012-11-18 Thread Jason Wang
On 11/05/2012 09:08 AM, Rusty Russell wrote: Jason Wang writes: +struct virtnet_info { + u16 num_queue_pairs;/* # of RX/TX vq pairs */ + u16 total_queue_pairs; + + struct send_queue *sq; + struct receive_queue *rq; + struct virtqueue *cvq; + + str

Re: [rfc net-next v6 3/3] virtio-net: change the number of queues through ethtool

2012-11-18 Thread Jason Wang
On 11/05/2012 07:46 AM, Rusty Russell wrote: Jason Wang writes: This patch implement the {set|get}_channels method of ethool to allow user to change the number of queues dymaically when the device is running. This would let the user to tune the device for specific applications. ... + /*

Re: [rfc net-next v6 2/3] virtio_net: multiqueue support

2012-11-18 Thread Jason Wang
On 11/05/2012 07:16 AM, Rusty Russell wrote: Jason Wang writes: This addes multiqueue support to virtio_net driver. There's two mode supported: single queue pair mode and multiple queue pairs mode. An obvious difference compared with a physical mq card is that virtio-net reserve first two virtq

Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

2012-11-18 Thread Tushar Behera
On 11/16/2012 10:23 PM, Jeremy Fitzhardinge wrote: > To be honest I'd nack this kind of patch. The test is only redundant in the > most trivial sense that the compiler can easily optimise away. The point of > the test is to make sure that the range is OK even if the type subsequently > becomes s

Re: virtio_blk BUG on detach-disk/attach-disk of mounted vd

2012-11-18 Thread Asias He
Hello Brian, On Fri, Nov 16, 2012 at 4:40 AM, Brian Foster wrote: > Hi, > > I know this isn't a valid use case or generally sane thing to do, but we > have a bug (link, with details, below) filed for a panic against a > detach-disk/attach-disk sequence of an ext4 mounted vd device on a rhel > ker

Re: [rfc net-next v6 2/3] virtio_net: multiqueue support

2012-11-18 Thread Michael S. Tsirkin
On Sat, Nov 17, 2012 at 12:35:29AM +, Ben Hutchings wrote: > On Tue, 2012-11-13 at 08:40 +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 05, 2012 at 11:38:39AM +1030, Rusty Russell wrote: > > > > @@ -924,11 +1032,10 @@ static void virtnet_get_ringparam(struct > > > > net_device *dev, > > > >