Re: [[PATCH v9 3/3] 1/1] virtio_console: Remove buffers from out_vq at port removal

2012-11-15 Thread Rusty Russell
Amit Shah writes: > From: Sjur Brændeland > > Remove buffers from the out-queue when a port is removed. Rproc_serial > communicates with remote processors that may crash and leave buffers in > the out-queue. The virtio serial ports may have buffers in the out-queue > as well, e.g. for non-blockin

Re: [PATCH 11/12] VMCI: host side driver implementation.

2012-11-15 Thread Greg KH
On Wed, Nov 07, 2012 at 10:42:53AM -0800, George Zhang wrote: > +/* > + * Sets up a given context for notify to work. Calls drv_map_bool_ptr() > + * which maps the notify boolean in user VA in kernel space. > + */ > +static int vmci_host_setup_notify(struct vmci_ctx *context, > +

Re: [PATCH 12/12] VMCI: Some header and config files.

2012-11-15 Thread Greg KH
On Wed, Nov 07, 2012 at 10:43:03AM -0800, George Zhang wrote: > +#ifndef _VMCI_COMMONINT_H_ > +#define _VMCI_COMMONINT_H_ > + > +#include Why printk from a .h file? > + > +#define ASSERT(cond) BUG_ON(!(cond)) No, please no. > + > +#define PCI_VENDOR_ID_VMWARE 0x15AD > +#define PCI_DEVICE_ID_VM

Re: [PATCH 07/12] VMCI: queue pairs implementation.

2012-11-15 Thread Greg KH
On Wed, Nov 07, 2012 at 10:42:15AM -0800, George Zhang wrote: > VMCI queue pairs allow for bi-directional ordered communication between host > and guests. You obviously didn't run checkpatch on this file :( Please send me a follow-on patch to resolve the issues it found, before someone else does

Re: [PATCH 02/12] VMCI: datagram implementation.

2012-11-15 Thread Greg KH
On Wed, Nov 07, 2012 at 10:41:26AM -0800, George Zhang wrote: > +/* > + * Create a datagram entry given a handle pointer. > + */ > +static int dg_create_handle(u32 resource_id, > + u32 flags, > + u32 priv_flags, > + vmci_datagr

Re: [Pv-drivers] [PATCH 0/6] VSOCK for Linux upstreaming

2012-11-15 Thread Anthony Liguori
On 11/07/2012 12:58 AM, Gerd Hoffmann wrote: On 11/05/12 19:19, Andy King wrote: Hi David, The big and only question is whether anyone can actually use any of this stuff without your proprietary bits? Do you mean the VMCI calls? The VMCI driver is in the process of being upstreamed into the

virtio_blk BUG on detach-disk/attach-disk of mounted vd

2012-11-15 Thread Brian Foster
Hi, I know this isn't a valid use case or generally sane thing to do, but we have a bug (link, with details, below) filed for a panic against a detach-disk/attach-disk sequence of an ext4 mounted vd device on a rhel kernel. The same sequence leads to the following BUG on an upstream kernel (3.7.0