Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Paolo Bonzini
Il 18/07/2012 21:12, Anthony Liguori ha scritto: > Is that true for all OSes? Linux may handle things gracefully if UNMAP > starts throwing errors but that doesn't mean that Windows will. There is so much USB crap (not just removable, think of ATA-to-USB enclosures) that they have to deal with pr

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 22:00:48 -0300 Rafael Aquini wrote: > > So the function needs a better name - one which communicates that it is > > a balloon page *for the purposes of processing by the compaction code*. > > Making the function private to compaction.c would help with that, if > > feasible. >

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Rafael Aquini
On Wed, Jul 18, 2012 at 04:12:39PM -0700, Andrew Morton wrote: > On Wed, 18 Jul 2012 20:07:07 -0300 > Rafael Aquini wrote: > > > > > > > > +} > > > > +#else > > > > +static inline bool is_balloon_page(struct page *page) { return > > > > false; } > > > > +static inline bool isolate_balloon

Re: [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages

2012-07-18 Thread Rafael Aquini
Howdy Andrew, Thanks for taking the time to go through this work and provide me with such good feedback. On Wed, Jul 18, 2012 at 03:49:08PM -0700, Andrew Morton wrote: > On Tue, 17 Jul 2012 13:50:42 -0300 > Rafael Aquini wrote: > > > Besides making balloon pages movable at allocation time and i

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Wed, 18 Jul 2012 20:07:07 -0300 Rafael Aquini wrote: > > > > > +} > > > +#else > > > +static inline bool is_balloon_page(struct page *page) { return > > > false; } > > > +static inline bool isolate_balloon_page(struct page *page) { return > > > false; } > > > +static inline bool putb

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Rafael Aquini
Howdy Andrew, Thanks for taking the time to go through this work and provide me with such good feedback. On Wed, Jul 18, 2012 at 03:46:05PM -0700, Andrew Morton wrote: > On Tue, 17 Jul 2012 13:50:41 -0300 > Rafael Aquini wrote: > > > This patch introduces the helper functions as well as the nec

Re: [PATCH v4 2/3] virtio_balloon: introduce migration primitives to balloon pages

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:50:42 -0300 Rafael Aquini wrote: > Besides making balloon pages movable at allocation time and introducing > the necessary primitives to perform balloon page migration/compaction, > this patch also introduces the following locking scheme to provide the > proper synchronizat

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Andrew Morton
On Tue, 17 Jul 2012 13:50:41 -0300 Rafael Aquini wrote: > This patch introduces the helper functions as well as the necessary changes > to teach compaction and migration bits how to cope with pages which are > part of a guest memory balloon, in order to make them movable by memory > compaction pr

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 08:42 -0500, Anthony Liguori wrote: > On 07/17/2012 04:50 PM, Nicholas A. Bellinger wrote: > > On Tue, 2012-07-17 at 13:55 -0500, Anthony Liguori wrote: > >> On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: > >>> On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger

Re: [RFC-v3 3/4] vhost: Add vhost_scsi specific defines

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 02:17:05PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-18 at 16:05 +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 18, 2012 at 12:59:31AM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > This patch adds the initial vhost_scsi_ioctl(

Re: [RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 19:09 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 12:59:32AM +, Nicholas A. Bellinger wrote: > > > > Changelog v2 -> v3: > > > > Unlock on error in tcm_vhost_drop_nexus() (DanC) > > Fix strlen() doesn't count the terminator (DanC) > > Call kfree()

Re: [RFC-v3 3/4] vhost: Add vhost_scsi specific defines

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 16:05 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 12:59:31AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds the initial vhost_scsi_ioctl() callers for > > VHOST_SCSI_SET_ENDPOINT > > and VHOST_SCSI_CLEAR_ENDPOINT resp

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Rustad, Mark D
On Jul 18, 2012, at 10:17 AM, Michael S. Tsirkin wrote: >> You do have to pay very close attention to some things however. Don't change >> the device identity in any way - even version information, otherwise a >> Windows initiator will blue-screen. I made that mistake myself, so I >> remember

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Anthony Liguori
On 07/18/2012 11:47 AM, James Bottomley wrote: On Wed, 2012-07-18 at 11:00 -0500, Anthony Liguori wrote: Of course: Think about the consequences: you want to upgrade one array on your SAN. You definitely don't want to shut down your entire data centre to achieve it. In place upgrades on runnin

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 04:42:33PM +, Rustad, Mark D wrote: > On Jul 18, 2012, at 9:00 AM, Michael S. Tsirkin wrote: > > > On Wed, Jul 18, 2012 at 11:53:38AM -0400, Christoph Hellwig wrote: > >> On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > >>> > >>> If you add support fo

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Rustad, Mark D
On Jul 18, 2012, at 9:00 AM, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 11:53:38AM -0400, Christoph Hellwig wrote: >> On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: >>> >>> If you add support for a new command, you need to provide userspace >>> a way to disable this com

Re: [PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-18 Thread Jeff Moyer
Asias He writes: > On 07/18/2012 03:10 AM, Jeff Moyer wrote: >> Asias He writes: >> >>> vhost-blk is a in kernel virito-blk device accelerator. >>> >>> This patch is based on Liu Yuan's implementation with various >>> improvements and bug fixes. Notably, this patch makes guest notify and >>> hos

Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages

2012-07-18 Thread Minchan Kim
Hi Rafael, On Tue, Jul 17, 2012 at 01:50:41PM -0300, Rafael Aquini wrote: > This patch introduces the helper functions as well as the necessary changes > to teach compaction and migration bits how to cope with pages which are > part of a guest memory balloon, in order to make them movable by memor

Re: [PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-18 Thread Jeff Moyer
Asias He writes: > vhost-blk is a in kernel virito-blk device accelerator. > > This patch is based on Liu Yuan's implementation with various > improvements and bug fixes. Notably, this patch makes guest notify and > host completion processing in parallel which gives about 60% performance > improv

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Anthony Liguori
On 07/18/2012 10:53 AM, Christoph Hellwig wrote: On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: If you add support for a new command, you need to provide userspace a way to disable this command. If you change what gets reported for VPD, you need to provide userspace a way to

Re: [RFC-v3 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 12:59:28AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > The following is the RFC-v3 series of tcm_vhost target fabric driver code > currently in-flight for-3.6 mainline code. So I sent some comments. I think it's in an OK state for a s

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 11:53:38AM -0400, Christoph Hellwig wrote: > On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > > > > If you add support for a new command, you need to provide userspace > > a way to disable this command. If you change what gets reported for > > VPD, you ne

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Christoph Hellwig
On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > > If you add support for a new command, you need to provide userspace > a way to disable this command. If you change what gets reported for > VPD, you need to provide userspace a way to make VPD look like what > it did in a previo

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > On 07/17/2012 04:50 PM, Nicholas A. Bellinger wrote: > >On Tue, 2012-07-17 at 13:55 -0500, Anthony Liguori wrote: > >>On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: > >>>On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Belli

Re: [PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-18 Thread Asias He
On 07/18/2012 10:31 PM, Jeff Moyer wrote: Asias He writes: On 07/18/2012 03:10 AM, Jeff Moyer wrote: Asias He writes: vhost-blk is a in kernel virito-blk device accelerator. This patch is based on Liu Yuan's implementation with various improvements and bug fixes. Notably, this patch makes

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Paolo Bonzini
Il 18/07/2012 15:42, Anthony Liguori ha scritto: > If you add support for a new command, you need to provide userspace a > way to disable this command. If you change what gets reported for VPD, > you need to provide userspace a way to make VPD look like what it did in > a previous version. The QE

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Anthony Liguori
On 07/17/2012 04:50 PM, Nicholas A. Bellinger wrote: On Tue, 2012-07-17 at 13:55 -0500, Anthony Liguori wrote: On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: It still seems not 100% clear whether this driver will ha

Re: [RFC-v3 3/4] vhost: Add vhost_scsi specific defines

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 12:59:31AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds the initial vhost_scsi_ioctl() callers for > VHOST_SCSI_SET_ENDPOINT > and VHOST_SCSI_CLEAR_ENDPOINT respectively, and also adds struct > vhost_vring_target > that is used by tc

Re: [RFC-v3 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 12:59:28AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > The following is the RFC-v3 series of tcm_vhost target fabric driver code > currently in-flight for-3.6 mainline code. > > With the merge window opening soon, the tcm_vhost code h

Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-18 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 4:09 PM, Michael S. Tsirkin wrote: > On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: >> >> Hi folks, >> >> [I am resending to fix the broken thread in the previous one.] >> >> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk >> device acce

Re: [PATCH 0/5] Add vhost-blk support

2012-07-18 Thread Ronen Hod
On 07/17/2012 12:21 PM, Asias He wrote: On 07/17/2012 04:52 PM, Paolo Bonzini wrote: Il 17/07/2012 10:29, Asias He ha scritto: So, vhost-blk at least saves ~6 syscalls for us in each request. Are they really 6? If I/O is coalesced by a factor of 3, for example (i.e. each exit processes 3 req

Re: [PATCH 0/5] Add vhost-blk support

2012-07-18 Thread Asias He
On 07/17/2012 09:02 PM, Paolo Bonzini wrote: Il 17/07/2012 14:48, Michael S. Tsirkin ha scritto: On Tue, Jul 17, 2012 at 01:03:39PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 17, 2012 at 12:54 PM, Michael S. Tsirkin wrote: Knowing the answer to that is important before anyone can say whether t

Re: [PATCH 0/5] Add vhost-blk support

2012-07-18 Thread Stefan Hajnoczi
On Wed, Jul 18, 2012 at 9:12 AM, Asias He wrote: > On 07/17/2012 07:11 PM, Stefan Hajnoczi wrote: >> >> On Tue, Jul 17, 2012 at 10:21 AM, Asias He wrote: >>> >>> On 07/17/2012 04:52 PM, Paolo Bonzini wrote: Il 17/07/2012 10:29, Asias He ha scritto: > > > So, vhost-blk a

Re: [PATCH 0/5] Add vhost-blk support

2012-07-18 Thread Asias He
On 07/17/2012 07:11 PM, Stefan Hajnoczi wrote: On Tue, Jul 17, 2012 at 10:21 AM, Asias He wrote: On 07/17/2012 04:52 PM, Paolo Bonzini wrote: Il 17/07/2012 10:29, Asias He ha scritto: So, vhost-blk at least saves ~6 syscalls for us in each request. Are they really 6? If I/O is coalesced