Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Ian Molton
On 28/10/10 21:14, Anthony Liguori wrote: >> If this code was invasive to qemus core, I'd say 'no way' but its just >> not. and as the GL device is versioned, we can keep using it even if >> the passthrough is replaced by a virtual GPU. > > The virtio-gl implementation is basically duplicating vir

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Anthony Liguori
On 10/28/2010 02:50 PM, Ian Molton wrote: > On 28/10/10 15:43, Anthony Liguori wrote: >> On 10/28/2010 09:24 AM, Avi Kivity wrote: >>> On 10/28/2010 01:54 PM, Ian Molton wrote: >> True, but then all that would prove is that I can write a spec to match the code. >>> >>> It would also allow

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Ian Molton
On 28/10/10 15:24, Avi Kivity wrote: >> The caller is intended to block as the host must perform GL rendering >> before allowing the guests process to continue. > > Why is that? Can't we pipeline the process? No, not really. the guest may call for the scene to be rendered at any time and we have

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Ian Molton
On 28/10/10 15:43, Anthony Liguori wrote: > On 10/28/2010 09:24 AM, Avi Kivity wrote: >> On 10/28/2010 01:54 PM, Ian Molton wrote: > >>> True, but then all that would prove is that I can write a spec to >>> match the code. >> >> It would also allow us to check that the spec matches the >> requireme

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Anthony Liguori
On 10/28/2010 09:24 AM, Avi Kivity wrote: > On 10/28/2010 01:54 PM, Ian Molton wrote: >>> Well, I like to review an implementation against a spec. >> >> >> True, but then all that would prove is that I can write a spec to >> match the code. > > It would also allow us to check that the spec matche

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Avi Kivity
On 10/28/2010 01:54 PM, Ian Molton wrote: >> Well, I like to review an implementation against a spec. > > > True, but then all that would prove is that I can write a spec to > match the code. It would also allow us to check that the spec matches the requirements. Those two steps are easier th

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Ian Molton
On 28/10/10 10:27, Avi Kivity wrote: > On 10/27/2010 03:00 PM, Ian Molton wrote: >> On 19/10/10 11:39, Avi Kivity wrote: >>> On 10/19/2010 12:31 PM, Ian Molton wrote: >> > 2. should start with a patch to the virtio-pci spec to document what > you're doing Where can I find that spe

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-10-28 Thread Avi Kivity
On 10/27/2010 03:00 PM, Ian Molton wrote: > On 19/10/10 11:39, Avi Kivity wrote: >> On 10/19/2010 12:31 PM, Ian Molton wrote: > 2. should start with a patch to the virtio-pci spec to document what you're doing >>> >>> Where can I find that spec? >> >> http://ozlabs.org/~rusty/virtio-spe