Re: Problem with multiple hvc consoles via virtio-console

2010-03-25 Thread Amit Shah
On (Wed) Mar 24 2010 [21:04:08], Amit Shah wrote: > Hello, > > When multiple hvc console ports are initialised and used via the > virtio_console driver, I can interact with only the first console, the > 2nd one doesn't respond. > > If I call hvc_kick() even if hvc_poll() returns 0, the 2nd consol

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 06:40 PM, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2010 at 06:32:15PM +0200, Avi Kivity wrote: > >> On 03/25/2010 06:23 PM, Anthony Liguori wrote: >> There has been previous discussion of virtio, however while virtio is good for exporting guest memory, it's not

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 06:32:15PM +0200, Avi Kivity wrote: > On 03/25/2010 06:23 PM, Anthony Liguori wrote: >>> There has been previous discussion of virtio, however while virtio is >>> good for exporting guest memory, it's not ideal for importing memory >>> into a guest. >> >> virtio is a DMA-bas

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 11:23:05AM -0500, Anthony Liguori wrote: > On 03/25/2010 11:18 AM, Cam Macdonell wrote: >> On Thu, Mar 25, 2010 at 3:15 AM, Michael S. Tsirkin wrote: >> >>> On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: >>> This patch adds a driver for my sha

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 06:23 PM, Anthony Liguori wrote: >> There has been previous discussion of virtio, however while virtio is >> good for exporting guest memory, it's not ideal for importing memory >> into a guest. > > virtio is a DMA-based API which means that it doesn't assume cache > coherent shared

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Anthony Liguori
On 03/25/2010 11:18 AM, Cam Macdonell wrote: > On Thu, Mar 25, 2010 at 3:15 AM, Michael S. Tsirkin wrote: > >> On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: >> >>> This patch adds a driver for my shared memory PCI device using the uio_pci >>> interface. The driver has t

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Cam Macdonell
On Thu, Mar 25, 2010 at 3:15 AM, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: >> This patch adds a driver for my shared memory PCI device using the uio_pci >> interface.  The driver has three memory regions.  The first memory region is >> for >> devic

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 11:58:30AM +0200, Avi Kivity wrote: > On 03/25/2010 11:44 AM, Michael S. Tsirkin wrote: >> On Thu, Mar 25, 2010 at 11:40:09AM +0200, Avi Kivity wrote: >> >>> On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: >>> - Why are you using 32 bit long memory accesses

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 11:44 AM, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2010 at 11:40:09AM +0200, Avi Kivity wrote: > >> On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: >> >>> - Why are you using 32 bit long memory accesses for interrupts? >>> 16 bit IO eould be enough and it's faster.

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 11:40:09AM +0200, Avi Kivity wrote: > On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: >> >> - Why are you using 32 bit long memory accesses for interrupts? >>16 bit IO eould be enough and it's faster. This what virtio-pci does. >> >> > > Why is 16 bit io faster? S

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Avi Kivity
On 03/25/2010 11:15 AM, Michael S. Tsirkin wrote: > > - Why are you using 32 bit long memory accesses for interrupts? >16 bit IO eould be enough and it's faster. This what virtio-pci does. > > Why is 16 bit io faster? -- error compiling committee.c: too many arguments to function __

Re: [PATCH v3 1/1] Shared memory uio_pci driver

2010-03-25 Thread Michael S. Tsirkin
On Thu, Mar 25, 2010 at 12:09:36AM -0600, Cam Macdonell wrote: > This patch adds a driver for my shared memory PCI device using the uio_pci > interface. The driver has three memory regions. The first memory region is > for > device registers for sending interrupts. The second BAR is for receivin