Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread David Miller
From: Herbert Xu Date: Sat, 4 Jul 2009 11:08:30 +0800 > On Fri, Jul 03, 2009 at 08:02:54PM -0700, David Miller wrote: >> >> In particular the case of handling a device without usable TX >> completion event indications is still quite troublesome. > e > Which particular devices do you have in mind?

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread Herbert Xu
On Fri, Jul 03, 2009 at 08:02:54PM -0700, David Miller wrote: > > In particular the case of handling a device without usable TX > completion event indications is still quite troublesome. Which particular devices do you have in mind? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: He

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread David Miller
From: Herbert Xu Date: Fri, 3 Jul 2009 15:55:30 +0800 > Calling skb_orphan like this should be forbidden. Apart from the > problems already raised, it is a sign that the driver is trying to > paper over a more serious issue of not cleaning up skb's timely. > > Yes skb_orphan will work for the c

[PATCH] virtio-serial: virtio device for simple host <-> guest communication

2009-07-03 Thread Amit Shah
This interface presents a char device from which bits can be sent and read. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users, clipboard copy-paste, etc. for online usage. Signed-off-by: Amit S

[PATCH] virtio_serial: A char device for simple guest <-> host communication

2009-07-03 Thread Amit Shah
We expose multiple char devices ("ports") for simple communication between the host userspace and guest. This is mainly intended for obtaining information from the guest. Sample offline usages can be: poking around in a guest to find out the file systems used, applications installed, etc. Online u

[RFC PATCH v3] virito-serial: A guest <-> host interface

2009-07-03 Thread Amit Shah
Hello, This is a new iteration of the patches that implement virtio-serial. Changes include: * Adding support for port hot-add * Creating ports at specific ids that can be bound to specific apps / usage * Cleanups This code still doesn't get rid of the support for assigning names to ports but

Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

2009-07-03 Thread Herbert Xu
David Miller wrote: > >> I think I'll do this in the driver for now, and let's revisit doing it >> generically later? > > That might be the best course of action for the time being. > This whole area is a rat's nest. Calling skb_orphan like this should be forbidden. Apart from the problems alr