Re: [PATCH 2/4] virtio_net: return NETDEV_TX_BUSY instead of queueing an extra skb.

2009-06-13 Thread Herbert Xu
On Sat, Jun 13, 2009 at 10:00:37PM +0930, Rusty Russell wrote: > > But re your comment that the 67 drivers using TX_BUSY are doing it because of > driver bugs, that's hard to believe. It either hardly ever happens (in which > case just drop the packet), or it happens (in which case we should ha

Re: [PATCH 2/4] virtio_net: return NETDEV_TX_BUSY instead of queueing an extra skb.

2009-06-13 Thread Rusty Russell
On Mon, 8 Jun 2009 02:52:47 pm Herbert Xu wrote: > No you've misunderstood my complaint. I'm not trying to get you > to replace NETDEV_TX_BUSY by the equally abhorrent queue in the > driver, I'm saying that you should stop the queue before you get > a packet that overflows by looking at the amount

[PATCH 3/3] xen/dev-evtchn: remove duplicated #include

2009-06-13 Thread Huang Weiyi
Signed-off-by: Huang Weiyi --- drivers/xen/evtchn.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index af03195..79bedba 100644 --- a/drivers/xen/evtchn.c +++ b/drivers/xen/evtchn.c @@ -38,7 +38,6 @@ #include #include #in