Re: [PATCH] virtio-rng: Remove false BUG for spurious callbacks

2009-04-24 Thread Linus Torvalds
On Thu, 23 Apr 2009, Rusty Russell wrote: > > From: Christian Borntraeger > > The virtio-rng drivers checks for spurious callbacks. Since > callbacks can be implemented via shared interrupts (e.g. PCI) this > could lead to guest kernel oopses with lots of virtio devices. > > Signed-off-by: Chr

Re: [1/2] tun: Only free a netdev when all tun descriptors are closed

2009-04-24 Thread Christian Borntraeger
Am Friday 24 April 2009 14:11:56 schrieb Herbert Xu: > The patch you qouted has been superceded by many versions :) Yes, I got lost in this mail thread... > Can you please test the latest that's in davem's tree? Done. With http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fdavem%2Fnet-2.6.git;a=co

Re: [1/2] tun: Only free a netdev when all tun descriptors are closed

2009-04-24 Thread Herbert Xu
On Fri, Apr 24, 2009 at 10:55:49AM +0200, Christian Borntraeger wrote: > Am Thursday 16 April 2009 13:08:18 schrieb Herbert Xu: > > > Here's the patch. I'd appreciate if everyone can review it > > and see if they can recreate the original race by > > > > 1) Starting a process using tun and polls

Re: [1/2] tun: Only free a netdev when all tun descriptors are closed

2009-04-24 Thread Christian Borntraeger
Am Thursday 16 April 2009 13:08:18 schrieb Herbert Xu: > On Wed, Apr 15, 2009 at 10:38:34PM +0800, Herbert Xu wrote: > > > > So how about this? We replace the dev destructor with our own that > > doesn't immediately call free_netdev. We only call free_netdev once > > all tun fd's attached to the