Re: [PATCH 3/3] virtio_net: Fix skb->csum_start computation

2008-05-28 Thread Herbert Xu
On Tue, May 27, 2008 at 12:20:47PM +0100, Mark McLoughlin wrote: > hdr->csum_start is the offset from the start of the ethernet > header to the transport layer checksum field. skb->csum_start > is the offset from skb->head. > > skb_partial_csum_set() assumes that skb->data points to the > ethernet

Re: [PATCH 2/3] virtio_net: Trivial coding style fix

2008-05-28 Thread Rusty Russell
On Tuesday 27 May 2008 21:20:46 Mark McLoughlin wrote: > - if (!skb_partial_csum_set(skb,hdr->csum_start,hdr->csum_offset)) > + if (!skb_partial_csum_set(skb, hdr->csum_start, > hdr->csum_offset)) I compressed the whitespace to avoid going over 80 cols. A choice of lesser

Re: linux-next 20080528: XEN build error when no Power Mgt enabled

2008-05-28 Thread Jeremy Fitzhardinge
Randy Dunlap wrote: > linux-next-20080528/drivers/xen/manage.c: In function 'xen_suspend': > linux-next-20080528/drivers/xen/manage.c:43: error: implicit declaration of > function 'device_power_down' > linux-next-20080528/drivers/xen/manage.c:65: error: imp

linux-next 20080528: XEN build error when no Power Mgt enabled

2008-05-28 Thread Randy Dunlap
linux-next-20080528/drivers/xen/manage.c: In function 'xen_suspend': linux-next-20080528/drivers/xen/manage.c:43: error: implicit declaration of function 'device_power_down' linux-next-20080528/drivers/xen/manage.c:65: error: implicit declaration of function 'de

RE: [PATCH 00/17] ia64/pv_ops take 6

2008-05-28 Thread Luck, Tony
> Since the effort to reduce code size had already been made, so > it is difficult to go further. By moving all of them, it would > be consistent and we don't have to worry about code size anymore. I've been caught by these a number of times while adding debug/monitor hooks to ivt.S code. Moving

Re: [PATCH 00/17] ia64/pv_ops take 6

2008-05-28 Thread Isaku Yamahata
On Tue, May 27, 2008 at 04:26:45PM -0700, Luck, Tony wrote: > I had to spend time on a bugfix. The bugfix is posted > in my 'release' branch. The pv_ops series (including the > documentation) is now in the 'test' branch. Take a close > look at arch/is64/kernel/minstate.h as I had to re-merge > y