Re: [kvm-devel] [PATCH 2/2] KVM: Handle interrupts for PCI passthrough devices

2008-05-02 Thread Avi Kivity
Amit Shah wrote: > >> Seems to me the only choice here is to mask the interrupt at the ioapic >> level, wait until the guest acks the interrupt, then unmask the interrupt. >> > > OK; will that create problems if the line is shared? > > It will not work with shared interrupts (unless all us

Re: [kvm-devel] [PATCH 2/2] KVM: Handle interrupts for PCI passthrough devices

2008-05-02 Thread Amit Shah
On Friday 02 May 2008 16:05:17 Avi Kivity wrote: > Amit Shah wrote: > >>> +static irqreturn_t > >>> +kvm_pci_pt_dev_intr(int irq, void *dev_id) > >>> > >>> +{ > >>> + struct kvm_pci_pt_dev_list *match; > >>> + struct kvm *kvm = (struct kvm *) dev_id; > >>> + > >>> + if (!test_bit(irq, pt_irq_handle

[PULL] virtio & lguest changes for 2.6.26

2008-05-02 Thread Rusty Russell
The following changes since commit 886c35fbcf6fb2eee15687efc2d64d99b6ad9a4a: Linus Torvalds (1): Merge branch 'for-linus' of git://git.kernel.org/.../ieee1394/linux1394-2.6 are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-l

Re: [PATCH] virtio_net: free transmit skbs in a timer

2008-05-02 Thread Rusty Russell
On Thursday 01 May 2008 00:31:46 Mark McLoughlin wrote: > virtio_net currently only frees old transmit skbs just > before queueing new ones. If the queue is full, it then > enables interrupts and waits for notification that more > work has been performed. Hi Mark, This patch is fine, but it's

Re: [kvm-devel] [PATCH 2/2] KVM: Handle interrupts for PCI passthrough devices

2008-05-02 Thread Avi Kivity
Amit Shah wrote: > >>> +static irqreturn_t >>> +kvm_pci_pt_dev_intr(int irq, void *dev_id) >>> >>> +{ >>> + struct kvm_pci_pt_dev_list *match; >>> + struct kvm *kvm = (struct kvm *) dev_id; >>> + >>> + if (!test_bit(irq, pt_irq_handled)) >>> + return IRQ_NONE; >>> + >>> +