Re: [PATCH 1/4] virtio: wean net driver off NETDEV_TX_BUSY

2008-04-28 Thread Herbert Xu
On Tue, Apr 29, 2008 at 01:16:05AM +1000, Rusty Russell wrote: > > + /* If we has a buffer left over from last time, send it now. */ > + if (vi->last_xmit_skb) { > + if (xmit_skb(vi, vi->last_xmit_skb) != 0) { > + /* Drop this skb: we only queue one. */ > +

[PATCH 1/4] virtio: wean net driver off NETDEV_TX_BUSY

2008-04-28 Thread Rusty Russell
Herbert tells me that returning NETDEV_TX_BUSY from hard_start_xmit is seen as a poor thing to do; we should cache the packet and stop the queue. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/net/virtio_net.c | 58 --- 1 file changed, 4

[PATCH 3/4] virtio: net: Add ethtool ops for SG/GSO

2008-04-28 Thread Rusty Russell
Date: Fri, 18 Apr 2008 11:21:42 +0800 From: Herbert Xu <[EMAIL PROTECTED]> This patch adds some basic ethtool operations to virtio_net so I could test SG without GSO (which was really useful because TSO turned out to be buggy :) Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> (remove MTU setting

[PATCH 4/4] virtio: net: Allow receiving SG packets

2008-04-28 Thread Rusty Russell
Date: Fri, 18 Apr 2008 11:24:27 +0800 From: Herbert Xu <[EMAIL PROTECTED]> Finally this patch lets virtio_net receive GSO packets in addition to sending them. This can definitely be optimised for the non-GSO case. For comparison the Xen approach stores one page in each skb and uses subsequent sk

[PATCH 2/4] virtio: finer-grained features for virtio_net

2008-04-28 Thread Rusty Russell
So, we previously had a 'VIRTIO_NET_F_GSO' bit which meant that 'the host can handle csum offload, and any TSO (v4&v6 incl ECN) or UFO packets you might want to send. I thought this was good enough for Linux, but it actually isn't, since we don't do UFO in software. So, add separate feature bits

Re: [PATCH 2/2] dm-ioband: I/O bandwidth controller v0.0.4: Document

2008-04-28 Thread Ryo Tsuruta
Hi, > Most writes are performed by pdflush, kswapd, etc. This will lead to large > inaccuracy. > > It isn't trivial to fix. We'd need deep, long tracking of ownership > probably all the way up to the pagecache page. The same infrastructure > would be needed to make Sergey's "BSD acct: disk I/O