On 4/11/07, Rusty Russell <[EMAIL PROTECTED]> wrote:
> What a question! end_request() doesn't end a request! What a crazy
> idea!
Aah, indeed, end_request() uses req->hard_cur_sectors while
end_entire_request() uses req->hard_nr_sectors which I missed.
On 4/11/07, Rusty Russell <[EMAIL PROTECTE
On Tue, 2007-04-10 at 10:36 -0700, H. Peter Anvin wrote:
> This patch is based on Rusty's recent cleanup of the EFLAGS-related
> macros; it extends the same kind of cleanup to control registers and
> MSRs.
Thanks hpa, this looks nice.
Cheers,
Rusty.
_
On Tue, 2007-04-10 at 10:31 -0700, H. Peter Anvin wrote:
> Jeremy Fitzhardinge wrote:
> >
> > Is having separate bit numbers and masks useful? If so, is it worth
> > doing for the others?
> >
>
> I presume it's useful, or at least *used* in the current code, since
> that was there already. If
On Tue, 2007-04-10 at 14:36 +0300, Pekka Enberg wrote:
> On 4/10/07, Rusty Russell <[EMAIL PROTECTED]> wrote:
> > > +/* Jens gave me this nice helper to end all chunks of a request. */
> > > +static void end_entire_request(struct request *req, int uptodate)
> > > +{
> > > + if (end_that_reque
* Zachary Amsden ([EMAIL PROTECTED]) wrote:
> Jeremy Fitzhardinge wrote:
> >Seems to work OK for native and Xen. I had to play a bit with the
> >paravirt-sched-clock patch to deal with the VMI changes. Zach, can you
> >check that it still works?
>
> I'm on it.
Not sure about cycles_2_ns...
arc
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote:
> Seems to work OK for native and Xen. I had to play a bit with the
> paravirt-sched-clock patch to deal with the VMI changes. Zach, can you
> check that it still works?
Cool, thanks for the rebase. Here's some small fixes.
Minor issue with CONF
Jeremy Fitzhardinge wrote:
> Seems to work OK for native and Xen. I had to play a bit with the
> paravirt-sched-clock patch to deal with the VMI changes. Zach, can you
> check that it still works?
>
> Thanks,
>
Thanks, btw.
Zach
___
Virtualization
Jeremy Fitzhardinge wrote:
> Seems to work OK for native and Xen. I had to play a bit with the
> paravirt-sched-clock patch to deal with the VMI changes. Zach, can you
> check that it still works?
>
I'm on it.
Zach
___
Virtualization mailing list
V
Seems to work OK for native and Xen. I had to play a bit with the
paravirt-sched-clock patch to deal with the VMI changes. Zach, can you
check that it still works?
Thanks,
J
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
Chris Wright wrote:
> * Zachary Amsden ([EMAIL PROTECTED]) wrote:
>
>> Yes, but unfortunately that is a nop:
>>
>> /*
>> * Avoid unnecessary state transitions, as it confuses
>> * Geode / Cyrix based boxen.
>> */
>> case CLOCK_EVT_MODE_SHUTDOWN:
>>
* Zachary Amsden ([EMAIL PROTECTED]) wrote:
> Jeremy Fitzhardinge wrote:
> >Why not submit a patch to do what you need here? (The Geode comment is
> >a bit worrying though.)
>
> Why should VMI add workaround into PIT code?
I'm not sure it's a workaround, seems more like a subtle diff (perhaps
it
Jeremy Fitzhardinge wrote:
> Why not submit a patch to do what you need here? (The Geode comment is
> a bit worrying though.)
>
Why should VMI add workaround into PIT code? PIT code wants to know
nothing about VMI. It understands PIT timers on hardware. VMI, on the
other hand, is special
* Zachary Amsden ([EMAIL PROTECTED]) wrote:
> Yes, but unfortunately that is a nop:
>
> /*
> * Avoid unnecessary state transitions, as it confuses
> * Geode / Cyrix based boxen.
> */
> case CLOCK_EVT_MODE_SHUTDOWN:
> if (evt->mode == CLOCK
Zachary Amsden wrote:
>/*
> * Avoid unnecessary state transitions, as it confuses
> * Geode / Cyrix based boxen.
> */
>case CLOCK_EVT_MODE_SHUTDOWN:
>if (evt->mode == CLOCK_EVT_MODE_UNUSED)
>break;
>case CLOCK_E
Chris Wright wrote:
> * Zachary Amsden ([EMAIL PROTECTED]) wrote:
>
+void __init vmi_time_init(void)
+{
+ /* Disable PIT: BIOSes start PIT CH0 with 18.2hz peridic. */
+ outb_p(0x3a, PIT_MODE); /* binary, mode 5, LSB/MSB, ch 0 */
>>> That shouldn't be necessary
On Tue, 10 Apr 2007 20:07:48 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote:
> On Wednesday 04 April 2007 03:06:59 Jeremy Fitzhardinge wrote:
> > The other symbols used to delineate the alt-instructions sections have
> > the form __foo/__foo_end. Rename parainstructions to match.
>
> This patch brea
On Tuesday 10 April 2007 19:36:44 H. Peter Anvin wrote:
> This patch is based on Rusty's recent cleanup of the EFLAGS-related
> macros; it extends the same kind of cleanup to control registers and
> MSRs.
Applied. Although it was somewhat painful because there were other
changes in the tree you di
On Wednesday 04 April 2007 03:06:59 Jeremy Fitzhardinge wrote:
> The other symbols used to delineate the alt-instructions sections have
> the form __foo/__foo_end. Rename parainstructions to match.
This patch breaks x86-64
-Andi
>
___
Virtualization
This patch is based on Rusty's recent cleanup of the EFLAGS-related
macros; it extends the same kind of cleanup to control registers and
MSRs.
It also unifies these between i386 and x86-64; at least with regards
to MSRs, the two had definitely gotten out of sync.
Signed-off-by: H. Peter Anvin <[E
Jeremy Fitzhardinge wrote:
>
> Is having separate bit numbers and masks useful? If so, is it worth
> doing for the others?
>
I presume it's useful, or at least *used* in the current code, since
that was there already. If deemed useful, it's something we could add
to the other bitmasks.
* Zachary Amsden ([EMAIL PROTECTED]) wrote:
> >>+void __init vmi_time_init(void)
> >>+{
> >>+ /* Disable PIT: BIOSes start PIT CH0 with 18.2hz peridic. */
> >>+ outb_p(0x3a, PIT_MODE); /* binary, mode 5, LSB/MSB, ch 0 */
> >
> >That shouldn't be necessary using clockevents.
>
> Actually, I'm n
Chris Wright wrote:
Thanks for the review! Comments inline.
>> +/* paravirt_ops.get_wallclock = vmi_get_wallclock */
>>
>
> Style nit, these pv_ops.foo = vmi_foo style comments aren't really useful.
>
>
Yeah, and easy to get out of sync. I'll drop them.
>> +.rating = 1000
H. Peter Anvin wrote:
> [PATCH] Clean up x86 control register and MSR macros
>
> This patch is based on Rusty's recent cleanup of the EFLAGS-related
> macros; it extends the same kind of cleanup to control registers and
> MSRs.
>
> It also unifies these between i386 and x86-64; at least with regard
[PATCH] Clean up x86 control register and MSR macros
This patch is based on Rusty's recent cleanup of the EFLAGS-related
macros; it extends the same kind of cleanup to control registers and
MSRs.
It also unifies these between i386 and x86-64; at least with regards
to MSRs, the two had definitely
On 10/04/07, Zachary Amsden <[EMAIL PROTECTED]> wrote:
> No, just no. You do not use goto to skip a code block. You do not
> return an obvious variable from a singly-inlined function and give
> the function a return value. You don't put unexplained comments
> about kmalloc in code which doesn't
Zachary Amsden wrote:
> No, just no. You do not use goto to skip a code block. You do not
> return an obvious variable from a singly-inlined function and give
> the function a return value. You don't put unexplained comments
> about kmalloc in code which doesn't do dynamic allocation. And
> you
On 4/10/07, Rusty Russell <[EMAIL PROTECTED]> wrote:
> > +/* Jens gave me this nice helper to end all chunks of a request. */
> > +static void end_entire_request(struct request *req, int uptodate)
> > +{
> > + if (end_that_request_first(req, uptodate, req->hard_nr_sectors))
> > +
Hi Rusty,
On 4/10/07, Rusty Russell <[EMAIL PROTECTED]> wrote:
> +/* Jens gave me this nice helper to end all chunks of a request. */
> +static void end_entire_request(struct request *req, int uptodate)
> +{
> + if (end_that_request_first(req, uptodate, req->hard_nr_sectors))
> +
A brief document describing how to use lguest. Because lguest doesn't
have an ABI we also include an example launcher in the Documentation
directory.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
Documentation/lguest/Makefile | 20
Documentation/lguest/lguest.c | 982 +
Lguest block driver
A simple block driver for lguest.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/block/Makefile |1
drivers/block/lguest_blk.c | 271
2 files changed, 272 insertions(+)
=
Lguest net driver
A simple net driver for lguest.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/net/Makefile |1
drivers/net/lguest_net.c | 355 ++
2 files changed, 356 insertions(+)
===
A simple net driver for lguest.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/net/Makefile |1
drivers/net/lguest_net.c | 355 ++
2 files changed, 356 insertions(+)
==
A simple console driver for lguest.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/char/Makefile |1
drivers/char/hvc_lguest.c | 99 +
2 files changed, 100 insertions(+)
=
This is the Kconfig and Makefile to allow lguest to actually be
compiled.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/Kconfig |2 ++
drivers/Makefile|1 +
drivers/lguest/Kconfig | 20
drivers/lguest/Makefile |7 +++
4 files
This is the structure offsets required by lg.ko's switcher.S.
Unfortunately we don't have infrastructure for private asm-offsets
creation.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
arch/i386/kernel/asm-offsets.c | 19 +++
1 file changed, 19 insertions(+)
===
This is the code and headers required to make an i386 kernel an lguest guest.
Signed-off-by: Rusty Russell <[EMAIL PROTECTED]>
---
drivers/lguest/lguest.c | 509 +++
drivers/lguest/lguest_asm.S | 59
drivers/lguest/lguest_bus.c | 148 ++
As promised to Andrew, and with much thanks to Andi Kleen for feedback,
this is the new series of lguest patches.
Main change is the move to drivers/lguest (for future non-i386
expansion), but lots of cleanups driven by Andi's feedback and the
documentation effort (which made me examine every line
37 matches
Mail list logo
