Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-17 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Sat, 17 Mar 2007 21:33:58 +1100 > On Fri, 2007-03-16 at 13:38 -0700, Jeremy Fitzhardinge wrote: > > David Miller wrote: > > > Perhaps the problem can be dealt with using ELF relocations. > > > > > > There is another case, discussed yesterday on netdev,

Re: [Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-17 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > On Fri, 2007-03-16 at 10:14 +0100, Ingo Molnar wrote: > >>> +unsigned long xen_pmd_val(pmd_t pmd) >>> +{ >>> + BUG(); >>> + return 0; >>> +} >>> >> make it noret. >> > > OK, I missed this one. How? > > Wondering if I've missed a trick here... No, I don't

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 13:38 -0700, Jeremy Fitzhardinge wrote: > David Miller wrote: > > Perhaps the problem can be dealt with using ELF relocations. > > > > There is another case, discussed yesterday on netdev, where run-time > > resolution of ELF relocations would be useful (for > > very-very-very

Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 11:39 -0700, Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: > >> + /* Make sure kernel address space is empty so that a pagetable > >> + will be allocated for it. */ > >> > > > > comment style. > > > > As you've noticed its a comment style I use quite often. Me

Re: [Xen-devel] Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 10:24 +0100, Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > Wrap a set of interesting paravirt_ops calls in a wrapper which makes > > the callsites available for patching. Unfortunately this is pretty > > ugly because there's no way to get gcc

Re: [patch 14/26] Xen-paravirt_ops: add common patching machinery

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 10:20 +0100, Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > Implement the actual patching machinery. paravirt_patch_default() > > contains the logic to automatically patch a callsite based on a few > > simple rules: > > > > - if the paravirt_

Re: [Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 10:14 +0100, Ingo Molnar wrote: > > +unsigned long xen_pmd_val(pmd_t pmd) > > +{ > > + BUG(); > > + return 0; > > +} > > make it noret. OK, I missed this one. How? Wondering if I've missed a trick here... Rusty. ___ Virtual

Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

2007-03-17 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: > I think the suggestion is much simpler. If you convince gcc/binutils to > leave the .reloc section in vmlinux, and make that available to the > kernel itself, then you can scan all the kernel's relocs to find ones > which refer to paravirt_ops, and use those to determi