Re: BHYVE SNAPSHOT image format proposal

On Saturday, July 15, 2023, Matthew Grooms wrote: > > > I don't know how to state it more clearly: Making binary copies of the > data structures is the problem. Something tells me that you'll continue to > ignore this, so I'll stop saying it. Maybe this is where our disconnect is? Can you give

Re: BHYVE SNAPSHOT image format proposal

On 7/15/23 12:31, Rob Wing wrote: On Saturday, July 15, 2023, Matthew Grooms > wrote: We'll overlook the fact that it does attempt to consolidate files ( 2 vs 3 ) and that there's no feedback requesting further consolidation after being open for two years

Re: BHYVE SNAPSHOT image format proposal

On Saturday, July 15, 2023, Matthew Grooms wrote: > > > We'll overlook the fact that it does attempt to consolidate files ( 2 vs 3 > ) and that there's no feedback requesting further consolidation after being > open for two years, but noted. You may as well abandon https://reviews.freebsd.org/D2

Re: BHYVE SNAPSHOT image format proposal

On 7/14/23 19:07, Rob Wing wrote: The review you referenced requires multiple files for a snapshot, which I think is a non-starter. We'll overlook the fact that it does attempt to consolidate files ( 2 vs 3 ) and that there's no feedback requesting further consolidation after being open for

Re: BHYVE SNAPSHOT image format proposal

The review you referenced requires multiple files for a snapshot, which I think is a non-starter. I was trying to ensure that the limitations described in the original snapshot commit message are addressed appropriately - but maybe I've mis-interpreted the message or that I don't fully understand

Re: BHYVE SNAPSHOT image format proposal

On 7/14/23 13:08, Rob Wing wrote: On Fri, Jul 14, 2023 at 9:40 AM Matthew Grooms > wrote: I see a need to define a format for bhyve so it's possible to mix different sections and encodings inside a unified stream. But all the data in your nvlist example

Re: BHYVE SNAPSHOT image format proposal

On 7/14/23 13:08, Rob Wing wrote: On Fri, Jul 14, 2023 at 9:40 AM Matthew Grooms > wrote: I see a need to define a format for bhyve so it's possible to mix different sections and encodings inside a unified stream. But all the data in your nvlist example

Re: BHYVE SNAPSHOT image format proposal

On Fri, Jul 14, 2023 at 9:40 AM Matthew Grooms wrote: > > I see a need to define a format for bhyve so it's possible to mix > different sections and encodings inside a unified stream. But all the > data in your nvlist example above can be easily be represented as text. > We already have JSON, YAM

Re: BHYVE SNAPSHOT image format proposal

On 6/7/23 13:25, Vitaliy Gusev wrote: Hi Corvin, On 6 Jun 2023, at 15:59, Corvin Köhne wrote: ... We may have different version of the format from the same produce. IMHO, it makes sense to have a dedicated IDENT and VERSION field to easily figure out 1) if the producer of the image is know

Re: BHYVE SNAPSHOT image format proposal

On Wed, 2023-06-07 at 21:25 +0300, Vitaliy Gusev wrote: > Hi Corvin,  > > > On 6 Jun 2023, at 15:59, Corvin Köhne wrote: > > > ... > > > > We may have different version of the format from the same produce. > > IMHO, it makes sense to have a dedicated IDENT and VERSION field to > > easily figure

Re: BHYVE SNAPSHOT image format proposal

Hi Corvin, > On 6 Jun 2023, at 15:59, Corvin Köhne wrote: >> ... > > We may have different version of the format from the same produce. > IMHO, it makes sense to have a dedicated IDENT and VERSION field to > easily figure out > > 1) if the producer of the image is known > 2) if we support that

Re: BHYVE SNAPSHOT image format proposal

Hi Vitaliy, thanks for your answers. See comments below. On Tue, 2023-06-06 at 14:25 +0300, Vitaliy Gusev wrote: > Hi Corvin,  > > Thanks for your comments and advices.  > > Answers are below, > > > On 5 Jun 2023, at 18:32, Corvin Köhne wrote: > > > > On Tue, 2023-05-23 at 19:05 +0300, Vital

Re: BHYVE SNAPSHOT image format proposal

Hi Corvin, Thanks for your comments and advices. Answers are below, > On 5 Jun 2023, at 18:32, Corvin Köhne wrote: > > On Tue, 2023-05-23 at 19:05 +0300, Vitaliy Gusev wrote: >> 2. HEADER PHYS format: >> >> 0+—+ >> |IDENT STRING

Re: BHYVE SNAPSHOT image format proposal

On Tue, 2023-05-23 at 19:05 +0300, Vitaliy Gusev wrote: > Hi, > > Here is a proposal for bhyve snapshot/checkpoint image format > improvements. > Hi Vitaliy, thank you very much for sending this proposal to the mailing list. > It implies moving snapshot code to nvlist engine.  > > Current sna

Re: BHYVE SNAPSHOT image format proposal

> On 25 May 2023, at 19:22, Mario Marietto wrote: > > Vitaliy, > > what happens if I clone your repo as source code on my FreeBSD system. Can I > test your code directly or not ? Anyway,I think that,before doing this,I need > to follow some kind of tutorial,to understand how the workflow is.

Re: BHYVE SNAPSHOT image format proposal

Vitaliy, what happens if I clone your repo as source code on my FreeBSD system. Can I test your code directly or not ? Anyway,I think that,before doing this,I need to follow some kind of tutorial,to understand how the workflow is. Otherwise I will be not able to test and stress it. On Thu, May 25

Re: BHYVE SNAPSHOT image format proposal

> On 25 May 2023, at 04:30, Tomek CEDRO wrote: > > On Wed, May 24, 2023 at 5:11 PM Vitaliy Gusev wrote: >> Protecting requires more efforts and it should be clearly defined: what is >> purpose. If >> purpose is having checksum with 99.9% reliability, NVLIST HEADER can be widen >> to have “chec

Re: BHYVE SNAPSHOT image format proposal

On Wed, May 24, 2023 at 5:11 PM Vitaliy Gusev wrote: > Protecting requires more efforts and it should be clearly defined: what is > purpose. If > purpose is having checksum with 99.9% reliability, NVLIST HEADER can be widen > to have “checksum” key/value for a Section. Well, this could be optiona

Re: BHYVE SNAPSHOT image format proposal

It is impossible. However, as first attempt you can verify that multidev branch works fine for you. https://github.com/gusev-vitaliy/freebsd/tree/dev/D35590 —— Vitaliy Gusev > On 24 May 2023, at 20:47, Mario Marietto wrote: > > Give me the internal git. I want to test it asap :) > > Il mer

Re: BHYVE SNAPSHOT image format proposal

Hi, > On 24 May 2023, at 20:46, Miroslav Lachman <000.f...@quip.cz> wrote: > > On 24/05/2023 17:10, Vitaliy Gusev wrote: > Current snapshot implementation has disadvantages: 3 files per snapshot: .meta, .kern, vram >>> >>> No problem, unless new single file will be protected against

Re: BHYVE SNAPSHOT image format proposal

Give me the internal git. I want to test it asap :) Il mer 24 mag 2023, 19:39 Vitaliy Gusev ha scritto: > It is ready but in internal git repo, and it needs time to port it to > CURRENT version. Probably week or so. > > When I create review, I will notify you. > > Thanks, > Vitaliy Gusev > > > O

Re: BHYVE SNAPSHOT image format proposal

On 24/05/2023 17:10, Vitaliy Gusev wrote: Current snapshot implementation has disadvantages: 3 files per snapshot: .meta, .kern, vram No problem, unless new single file will be protected against corruption (filesystem, transfer, application crash) and possible to be easily and cheaply modified

Re: BHYVE SNAPSHOT image format proposal

It is ready but in internal git repo, and it needs time to port it to CURRENT version. Probably week or so. When I create review, I will notify you. Thanks, Vitaliy Gusev > On 24 May 2023, at 20:33, Mario Marietto wrote: > > @gusev.vita...@gmail.com : Do you

Re: BHYVE SNAPSHOT image format proposal

@gusev.vita...@gmail.com : Do you want to explain to me how to test the new "snapshot" feature ? I'm interested to test and stress it on my system. Is it ready to be used ? On Wed, May 24, 2023 at 5:11 PM Vitaliy Gusev wrote: > Hi Tomek, > > Try to answer to the all questions below, please let

Re: BHYVE SNAPSHOT image format proposal

Hi Tomek, Try to answer to the all questions below, please let me know if I miss some important. > On 23 May 2023, at 21:58, Tomek CEDRO wrote: > > On Tue, May 23, 2023 at 6:06 PM Vitaliy Gusev wrote: >> Hi, >> Here is a proposal for bhyve snapshot/checkpoint image format improvements. >> It

Re: BHYVE SNAPSHOT image format proposal

On Tue, May 23, 2023 at 6:06 PM Vitaliy Gusev wrote: > Hi, > Here is a proposal for bhyve snapshot/checkpoint image format improvements. > It implies moving snapshot code to nvlist engine. Hey there Vitaliy :-) bhyve getting more and more traction, I am new user of bhyve and no expert, but new and

Re: BHYVE SNAPSHOT image format proposal

Hi, > On 23 May 2023, at 19:45, Poul-Henning Kamp wrote: > > >> 1. BHYVE SNAPSHOT image format: > > Please do not invent Yet Another Format, please ? > > Why not make it a tar(5) file ? > Tar cannot solve issues mentioned in “disadvantages”. Tar doesn’t have versions, it is just container