Re: Question about virtio_alloc_virtqueues

2023-09-10 Thread Mina Galić
that sounds like we can just remove the flags parameter from virtio_alloc_virtqueues() because it doesn't do anything I'm surprised i haven't seen… noticed any warnings about the flags parameter being unused. Kind regards, Mina Original Message On 9 Sept 2023, 11:53, Vincenzo

Re: Question about virtio_alloc_virtqueues

2023-09-09 Thread Vincenzo Maffione
Hi, Looking at the code, it looks like that comment was written at a time where per-virtqueue MSIX interrupts were not available, and virtio_alloc_virtqueues() API was already designed to receive a flag to indicate that per-virtqueue MSIX interrupts were requested. The code you quoted would likel

Question about virtio_alloc_virtqueues

2023-09-08 Thread Mina Galić
Hi folks, for the past two or so weeks, I've been trying to document the virtio functions: You can see some of my progress here: https://codeberg.org/meena/freebsd-src/commits/branch/improve/virtio I'm currently trying to document virtio_alloc_virtqueues. The second argument, flags, is only ever