Re: BHYVE_SNAPSHOT

2023-05-02 Thread Matthew Grooms
On 5/2/23 14:25, Rob Wing wrote: For future reference, if UPB does another project - might be worth trying to seek out a FreeBSD mentor that could guide the students and be willing to usher the changes in, not unlike a GSOC project. Good idea. That would be wonderful. -Matthew

Re: BHYVE_SNAPSHOT

2023-05-02 Thread Rob Wing
On Mon, May 1, 2023 at 10:16 PM Matthew Grooms wrote: > Yup. See above. I appreciate your input, but the goal of live migration > was set in 2016 with a prototype first demonstrated in 2018. How long do > you suggest a developer wait without review feedback before moving forward > out of tree? >

Re: BHYVE_SNAPSHOT

2023-05-02 Thread Vitaliy Gusev
> On 2 May 2023, at 18:38, Rob Wing wrote: > > Do you plan on saving the guest memory into the nvlist? If I have VM with 8 > gigs of memory, will the nvlist implementation allocate 8 gigs of memory for > the nvlist then write it out to disk? Or..? > > All the bullet points look good to me. >

Re: BHYVE_SNAPSHOT

2023-05-02 Thread Rob Wing
On Tue, May 2, 2023 at 3:00 AM Vitaliy Gusev wrote: > Just add some plans for me: > > 1. Describe snapshot file format: One file for snapshot. > > 2. Implement snapshot/resume via nvlist. > >*nvlist* implementation brings: > > >- Versioning >- Easy debugging, getting saved values, e

Re: BHYVE_SNAPSHOT

2023-05-02 Thread Vitaliy Gusev
Just add some plans for me: 1. Describe snapshot file format: One file for snapshot. 2. Implement snapshot/resume via nvlist. nvlist implementation brings: Versioning Easy debugging, getting saved values, etc. Validate restored variables: types, sized, etc. Add optional variables without b

Re: BHYVE_SNAPSHOT

2023-05-02 Thread Corvin Köhne
On Tue, 2023-05-02 at 01:16 -0500, Matthew Grooms wrote: > On 4/30/23 21:31, Rob Wing wrote: > >  Hey Matthew, > > > > On Sun, Apr 30, 2023 at 1:41 PM Matthew Grooms > > wrote: > > > > > >  Would you like to see support for VM snapshots in the generic > > > kernel? > > > > Is there a review ope

Re: BHYVE_SNAPSHOT

2023-05-01 Thread Matthew Grooms
On 4/30/23 21:31, Rob Wing wrote: Hey Matthew, On Sun, Apr 30, 2023 at 1:41 PM Matthew Grooms wrote: Would you like to see support for VM snapshots in the generic kernel? Is there a review open that addresses the limitations described in the commit message that brought the snapshot fea

Re: BHYVE_SNAPSHOT

2023-04-30 Thread Rob Wing
Hey Matthew, On Sun, Apr 30, 2023 at 1:41 PM Matthew Grooms wrote: > > Would you like to see support for VM snapshots in the generic kernel? > Is there a review open that addresses the limitations described in the commit message that brought the snapshot feature in? https://github.com/freebsd/f

Re: BHYVE_SNAPSHOT

2023-04-30 Thread Tomek CEDRO
On Mon, May 1, 2023 at 2:46 AM Mario Marietto wrote: > whats the meaning of o_O ? surprise / shock.. can't believe what i see.. in the context of "code is out there but never used" :-P -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info

Re: BHYVE_SNAPSHOT

2023-04-30 Thread Mario Marietto
> Where can I read up about the recently introduced BHYVE_SNAPSHOT ? >> > >> > I can only find terse information about what it does (in man 5 src.conf) >> > but not about how to use it and/or why. >> >> This began as sponsored student work with the Politehn

Re: BHYVE_SNAPSHOT

2023-04-30 Thread Tomek CEDRO
o_O -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info On Sun, Apr 30, 2023, 23:42 Matthew Grooms wrote: > On 4/29/23 06:17, void wrote: > > Hi, > > > > Where can I read up about the recently introduced BHYVE_SNAPSHOT ? > > > > I can only find terse informa

Re: BHYVE_SNAPSHOT

2023-04-30 Thread Matthew Grooms
On 4/29/23 06:17, void wrote: Hi, Where can I read up about the recently introduced BHYVE_SNAPSHOT ? I can only find terse information about what it does (in man 5 src.conf) but not about how to use it and/or why. This began as sponsored student work with the Politehnica University of

[Bug 271117] [bhyve] : Fix compilation on stable/13 and CURRENT with BHYVE_SNAPSHOT

2023-04-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271117 --- Comment #4 from florian.mil...@laposte.net --- thank you for the quick MFC. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 271117] [bhyve] : Fix compilation on stable/13 and CURRENT with BHYVE_SNAPSHOT

2023-04-28 Thread bugzilla-noreply
||corv...@freebsd.org Resolution|--- |FIXED --- Comment #3 from Corvin Köhne --- Done: https://cgit.freebsd.org/src/commit/?h=stable/13&id=b8cca0cdc0c1efe6282028de47ae7f56dc4fa6b1 I've verified that BHYVE_SNAPSHOT builds on stable/13 an

[Bug 271117] [bhyve] : Fix compilation on stable/13 and CURRENT with BHYVE_SNAPSHOT

2023-04-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271117 Vitaliy Gusev changed: What|Removed |Added CC||gusev.vita...@gmail.com --- Commen

[Bug 271117] [bhyve] : Fix compilation on stable/13 and CURRENT with BHYVE_SNAPSHOT

2023-04-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271117 --- Comment #1 from florian.mil...@laposte.net --- Created attachment 241816 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=241816&action=edit patch for CURRENT on top of revision bbfb244724e25933d7c7cf68b943e0c2a7d6e381 -- You

[Bug 271117] [bhyve] : Fix compilation on stable/13 and CURRENT with BHYVE_SNAPSHOT

2023-04-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271117 Bug ID: 271117 Summary: [bhyve] : Fix compilation on stable/13 and CURRENT with BHYVE_SNAPSHOT Product: Base System Version: CURRENT Hardware: Any OS