RE: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-07 Thread Corvin Köhne
Hi Rebecca and Peter, thank you very much for your feedback. Best regards Corvin Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-07 Thread Peter Grehan
On 4/7/22 3:24 PM, Corvin Köhne wrote: Hi Peter and Rebecca, thanks for your feedback. This patch is backward compatible. It checks if QemuFwCfg is available and if QemuFwCfg is missing it falls back to BhyveFwCtl. So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the commit mess

RE: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-07 Thread Corvin Köhne
Hi Mario, > im trying to test the patch on my pc,that has two graphic cards,the > intel coffee lake and the nvidia. i tried to start the pc from the > nvidia card and ive configured the xorg.conf file giving the > proper bus id value. in addition ive loaded the kernel.ko file > from the boot loade

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-07 Thread Mario Marietto
im trying to test the patch on my pc,that has two graphic cards,the intel coffee lake and the nvidia. i tried to start the pc from the nvidia card and ive configured the xorg.conf file giving the proper bus id value. in addition ive loaded the kernel.ko file from the boot loader.conf i have removed

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-07 Thread Rebecca Cran
I've just looked at the patch and it looks good, though I haven't tested it. So yes, please add: Acked-by: Rebecca Cran On 4/6/22 23:24, Corvin Köhne wrote: Hi Peter and Rebecca, thanks for your feedback. This patch is backward compatible. It checks if QemuFwCfg is available and if QemuFwC

RE: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Corvin Köhne
Hi Peter and Rebecca, thanks for your feedback. This patch is backward compatible. It checks if QemuFwCfg is available and if QemuFwCfg is missing it falls back to BhyveFwCtl. So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the commit message? Thanks Corvin Beckhoff Automation

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Peter Grehan
[re-posting from my personal email account, since my mail to > freebsd-virtualization got rejected]> > I seem to remember seeing previous feedback that Bhyve developers > strongly preferred the BhyveFwCtl mechanism. I've been out of the loop > though (busy with $dayjob) so I don't know if thing

Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg

2022-04-06 Thread Rebecca Cran
[re-posting from my personal email account, since my mail to freebsd-virtualization got rejected] I seem to remember seeing previous feedback that Bhyve developers strongly preferred the BhyveFwCtl mechanism. I've been out of the loop though (busy with $dayjob) so I don't know if things have c