[virtio-dev] Re: [PATCH RFC v7 2/8] Introduce group administration commands

2022-08-18 Thread Jason Wang
On Fri, Aug 19, 2022 at 11:28 AM Michael S. Tsirkin wrote: > > On Fri, Aug 19, 2022 at 08:26:50AM +0800, Jason Wang wrote: > > On Thu, Aug 18, 2022 at 4:51 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Aug 18, 2022 at 04:46:45PM +0800, Jason Wang wrote: > > > > On Sat, Aug 13, 2022 at 1:19 AM

Re: [virtio-dev] Re: [PATCH 5/6] virtio/vsock: add support for dgram

2022-08-18 Thread Arseniy Krasnov
On Tue, 2022-08-16 at 20:52 +, Bobby Eshleman wrote: > On Thu, Aug 18, 2022 at 08:35:48AM +, Arseniy Krasnov wrote: > > On Tue, 2022-08-16 at 09:58 +, Bobby Eshleman wrote: > > > On Wed, Aug 17, 2022 at 05:42:08AM +, Arseniy Krasnov wrote: > > > > On 17.08.2022 08:01, Arseniy Krasno

[virtio-dev] Re: [virtio] [PATCH RFC v7 6/8] ccw: disallow ADMIN_VQ

2022-08-18 Thread Michael S. Tsirkin
On Thu, Aug 18, 2022 at 03:39:58PM +0200, Halil Pasic wrote: > On Tue, 16 Aug 2022 11:48:43 -0400 > "Michael S. Tsirkin" wrote: > > > On Tue, Aug 16, 2022 at 04:48:11PM +0200, Halil Pasic wrote: > > > On Fri, 12 Aug 2022 13:19:20 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > Signed-of

[virtio-dev] Re: [PATCH RFC v7 4/8] Add admin_queue_index register to PCI common configuration structure

2022-08-18 Thread Michael S. Tsirkin
On Fri, Aug 19, 2022 at 08:28:41AM +0800, Jason Wang wrote: > On Thu, Aug 18, 2022 at 4:55 PM Max Gurtovoy wrote: > > > > > > On 8/18/2022 11:49 AM, Jason Wang wrote: > > > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin > > > wrote: > > >> From: Max Gurtovoy > > >> > > >> This new register

[virtio-dev] Re: [PATCH RFC v7 2/8] Introduce group administration commands

2022-08-18 Thread Michael S. Tsirkin
On Fri, Aug 19, 2022 at 08:26:50AM +0800, Jason Wang wrote: > On Thu, Aug 18, 2022 at 4:51 PM Michael S. Tsirkin wrote: > > > > On Thu, Aug 18, 2022 at 04:46:45PM +0800, Jason Wang wrote: > > > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin > > > wrote: > > > > > > > > From: Max Gurtovoy >

[virtio-dev] Re: [PATCH RFC v7 4/8] Add admin_queue_index register to PCI common configuration structure

2022-08-18 Thread Jason Wang
On Thu, Aug 18, 2022 at 4:55 PM Max Gurtovoy wrote: > > > On 8/18/2022 11:49 AM, Jason Wang wrote: > > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > >> From: Max Gurtovoy > >> > >> This new register will be used for querying the index of the admin > >> virtqueue of a virtio device.

[virtio-dev] Re: [PATCH RFC v7 2/8] Introduce group administration commands

2022-08-18 Thread Jason Wang
On Thu, Aug 18, 2022 at 4:51 PM Michael S. Tsirkin wrote: > > On Thu, Aug 18, 2022 at 04:46:45PM +0800, Jason Wang wrote: > > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > > > > > From: Max Gurtovoy > > > > > > These commands are used for essential administrative and management >

Re: [virtio-dev] Re: [PATCH 5/6] virtio/vsock: add support for dgram

2022-08-18 Thread Bobby Eshleman
On Thu, Aug 18, 2022 at 08:35:48AM +, Arseniy Krasnov wrote: > On Tue, 2022-08-16 at 09:58 +, Bobby Eshleman wrote: > > On Wed, Aug 17, 2022 at 05:42:08AM +, Arseniy Krasnov wrote: > > > On 17.08.2022 08:01, Arseniy Krasnov wrote: > > > > On 16.08.2022 05:32, Bobby Eshleman wrote: > > >

[virtio-dev] Re: [virtio] [PATCH RFC v7 6/8] ccw: disallow ADMIN_VQ

2022-08-18 Thread Halil Pasic
On Tue, 16 Aug 2022 11:48:43 -0400 "Michael S. Tsirkin" wrote: > On Tue, Aug 16, 2022 at 04:48:11PM +0200, Halil Pasic wrote: > > On Fri, 12 Aug 2022 13:19:20 -0400 > > "Michael S. Tsirkin" wrote: > > > > > Signed-off-by: Michael S. Tsirkin > > > --- > > > content.tex | 10 ++ > > >

Re: [virtio-dev] Re: [PATCH RFC v7 8/8] admin command list discovery

2022-08-18 Thread Michael S. Tsirkin
On Thu, Aug 18, 2022 at 04:56:43PM +0800, Zhu, Lingshan wrote: > > > On 8/18/2022 4:51 PM, Jason Wang wrote: > > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > > From: Max Gurtovoy > > > > > > Add commands to find out which commands does each group support. > > > This will be us

Re: [virtio-dev] Re: [PATCH RFC v7 8/8] admin command list discovery

2022-08-18 Thread Zhu, Lingshan
On 8/18/2022 4:51 PM, Jason Wang wrote: On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: From: Max Gurtovoy Add commands to find out which commands does each group support. This will be useful once we have multiple group types. I still wonder if it's better to just use different

[virtio-dev] Re: [PATCH RFC v7 1/8] Introduce device group

2022-08-18 Thread Michael S. Tsirkin
On Thu, Aug 18, 2022 at 04:37:33PM +0800, Jason Wang wrote: > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > > > From: Max Gurtovoy > > > > Each device group has a type. For now, define one initial type of device > > groups: SR-IOV type. > > > > SR-IOV type - A virtio PCI SR-IOV ph

[virtio-dev] Re: [PATCH RFC v7 8/8] admin command list discovery

2022-08-18 Thread Michael S. Tsirkin
On Thu, Aug 18, 2022 at 04:51:39PM +0800, Jason Wang wrote: > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > > > From: Max Gurtovoy > > > > Add commands to find out which commands does each group support. > > This will be useful once we have multiple group types. > > I still wonde

[virtio-dev] Re: [PATCH RFC v7 4/8] Add admin_queue_index register to PCI common configuration structure

2022-08-18 Thread Michael S. Tsirkin
On Thu, Aug 18, 2022 at 04:49:38PM +0800, Jason Wang wrote: > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > > > From: Max Gurtovoy > > > > This new register will be used for querying the index of the admin > > virtqueue of a virtio device. To configure, reset or enable the admin >

[virtio-dev] Re: [PATCH RFC v7 8/8] admin command list discovery

2022-08-18 Thread Jason Wang
On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > From: Max Gurtovoy > > Add commands to find out which commands does each group support. > This will be useful once we have multiple group types. I still wonder if it's better to just use different types of virtqueues, it seems more si

[virtio-dev] Re: [PATCH RFC v7 2/8] Introduce group administration commands

2022-08-18 Thread Michael S. Tsirkin
On Thu, Aug 18, 2022 at 04:46:45PM +0800, Jason Wang wrote: > On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > > > From: Max Gurtovoy > > > > These commands are used for essential administrative and management > > operations. > > > > Following patches will introduce an interface for

[virtio-dev] Re: [PATCH RFC v7 4/8] Add admin_queue_index register to PCI common configuration structure

2022-08-18 Thread Jason Wang
On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > From: Max Gurtovoy > > This new register will be used for querying the index of the admin > virtqueue of a virtio device. To configure, reset or enable the admin > virtqueue, the driver should follow existing queue configuration/setup

[virtio-dev] Re: [PATCH RFC v7 2/8] Introduce group administration commands

2022-08-18 Thread Jason Wang
On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > From: Max Gurtovoy > > These commands are used for essential administrative and management > operations. > > Following patches will introduce an interface for submitting these > commands to the device. > > Signed-off-by: Max Gurtovoy

[virtio-dev] Re: [PATCH RFC v7 1/8] Introduce device group

2022-08-18 Thread Jason Wang
On Sat, Aug 13, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > From: Max Gurtovoy > > Each device group has a type. For now, define one initial type of device > groups: SR-IOV type. > > SR-IOV type - A virtio PCI SR-IOV physical function (PF) and its > PCI SR-IOV virtual functions (VFs). This grou

Re: [virtio-dev] Re: [PATCH 5/6] virtio/vsock: add support for dgram

2022-08-18 Thread Arseniy Krasnov
On Tue, 2022-08-16 at 09:58 +, Bobby Eshleman wrote: > On Wed, Aug 17, 2022 at 05:42:08AM +, Arseniy Krasnov wrote: > > On 17.08.2022 08:01, Arseniy Krasnov wrote: > > > On 16.08.2022 05:32, Bobby Eshleman wrote: > > > > CC'ing virtio-dev@lists.oasis-open.org > > > > > > > > On Mon, Aug 15

Re: [virtio-dev] Re: [PATCH 5/6] virtio/vsock: add support for dgram

2022-08-18 Thread Arseniy Krasnov
On Tue, 2022-08-16 at 09:57 +, Bobby Eshleman wrote: > On Wed, Aug 17, 2022 at 05:01:00AM +, Arseniy Krasnov wrote: > > On 16.08.2022 05:32, Bobby Eshleman wrote: > > > CC'ing virtio-dev@lists.oasis-open.org > > > > > > On Mon, Aug 15, 2022 at 10:56:08AM -0700, Bobby Eshleman wrote: > > >